[OpenWrt-Devel,1/2] mac80211: add rtw88 driver
diff mbox series

Message ID 20191021191308.16311-1-mail@david-bauer.net
State Superseded
Headers show
Series
  • [OpenWrt-Devel,1/2] mac80211: add rtw88 driver
Related show

Commit Message

David Bauer Oct. 21, 2019, 7:13 p.m. UTC
This commits adds packaging for the new RTW88 driver from Realtek.
It supports the Realtek 8822BE/8822CE PCIe wireless chips.

For operation, the complementary firmware has to be loaded.

Signed-off-by: David Bauer <mail@david-bauer.net>
---
 package/kernel/mac80211/realtek.mk | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

Comments

John Crispin Oct. 21, 2019, 7:22 p.m. UTC | #1
On 21/10/2019 21:13, David Bauer wrote:
> +config-$(call config_package,rtw88) += RTW88
> +config-y += RTW88_CORE RTW88_PCI RTW88_8822BE RTW88_8822CE
> +

why not put it all behind config-$(call config_package,rtw88) ? of 
course kbuild will "is not set it" if the prior is not selected but you 
could be explicit here. its bikeshedding but I was wondering if I am 
missing the obvious here.
	John
David Bauer Oct. 21, 2019, 7:31 p.m. UTC | #2
Hello John

On 10/21/19 9:22 PM, John Crispin wrote:
> On 21/10/2019 21:13, David Bauer wrote:
>> +config-$(call config_package,rtw88) += RTW88
>> +config-y += RTW88_CORE RTW88_PCI RTW88_8822BE RTW88_8822CE
>> +
> 
> why not put it all behind config-$(call config_package,rtw88) ? of course kbuild will "is not set it" if the prior is not selected but you could be explicit here. its bikeshedding but I was wondering if I am missing the obvious here.

Good point, i will adjust this here. It's a leftover from when i thought building seperate packages
for each WiFi card is a good idea (which i don't think still is).

Best wishes
David

>     John
> 
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
John Crispin Oct. 21, 2019, 8:42 p.m. UTC | #3
On 21/10/2019 21:31, David Bauer wrote:
> Hello John
> 
> On 10/21/19 9:22 PM, John Crispin wrote:
>> On 21/10/2019 21:13, David Bauer wrote:
>>> +config-$(call config_package,rtw88) += RTW88
>>> +config-y += RTW88_CORE RTW88_PCI RTW88_8822BE RTW88_8822CE
>>> +
>>
>> why not put it all behind config-$(call config_package,rtw88) ? of course kbuild will "is not set it" if the prior is not selected but you could be explicit here. its bikeshedding but I was wondering if I am missing the obvious here.
> 
> Good point, i will adjust this here. It's a leftover from when i thought building seperate packages
> for each WiFi card is a good idea (which i don't think still is).
> 
> Best wishes
> David
> 

can you resend a V2 please, i'll mark this one as superseeded in that case
	John

Patch
diff mbox series

diff --git a/package/kernel/mac80211/realtek.mk b/package/kernel/mac80211/realtek.mk
index e7eb9e3117..311eca1b6a 100644
--- a/package/kernel/mac80211/realtek.mk
+++ b/package/kernel/mac80211/realtek.mk
@@ -2,7 +2,7 @@  PKG_DRIVERS += \
 	rtl8180 rtl8187 \
 	rtlwifi rtlwifi-pci rtlwifi-btcoexist rtlwifi-usb rtl8192c-common \
 	rtl8192ce rtl8192se rtl8192de rtl8192cu rtl8821ae \
-	rtl8xxxu
+	rtl8xxxu rtw88
 
 config-$(call config_package,rtl8180) += RTL8180
 config-$(call config_package,rtl8187) += RTL8187
@@ -22,6 +22,9 @@  config-$(CONFIG_PACKAGE_RTLWIFI_DEBUG) += RTLWIFI_DEBUG
 config-$(call config_package,rtl8xxxu) += RTL8XXXU
 config-y += RTL8XXXU_UNTESTED
 
+config-$(call config_package,rtw88) += RTW88
+config-y += RTW88_CORE RTW88_PCI RTW88_8822BE RTW88_8822CE
+
 define KernelPackage/rtl818x/Default
   $(call KernelPackage/mac80211/Default)
   TITLE:=Realtek Drivers for RTL818x devices
@@ -168,3 +171,12 @@  define KernelPackage/rtl8xxxu/description
 
   Please report your results!
 endef
+
+define KernelPackage/rtw88
+  $(call KernelPackage/mac80211/Default)
+  TITLE:=Realtek RTL8822BE/RTL8822CE
+  DEPENDS+= @(PCI_SUPPORT) +kmod-mac80211 +@DRIVER_11N_SUPPORT +@DRIVER_11W_SUPPORT
+  FILES:=$(PKG_BUILD_DIR)/drivers/net/wireless/realtek/rtw88/rtw88.ko	\
+	$(PKG_BUILD_DIR)/drivers/net/wireless/realtek/rtw88/rtwpci.ko
+  AUTOLOAD:=$(call AutoProbe,rtwpci)
+endef