[1/2] dt-bindings: asoc: adau7118: Cleanup
diff mbox series

Message ID 20191021140816.262401-2-nuno.sa@analog.com
State Not Applicable
Headers show
Series
  • Update adau7118 dt-bindings
Related show

Checks

Context Check Description
robh/checkpatch success

Commit Message

Sa, Nuno Oct. 21, 2019, 2:08 p.m. UTC
This changes are in accordance with the review done to this bindings.
This is a follow-up patch to 969d49b2cdc8.

Signed-off-by: Nuno Sá <nuno.sa@analog.com>
---
 .../bindings/sound/adi,adau7118.yaml          | 25 ++++++++-----------
 1 file changed, 10 insertions(+), 15 deletions(-)

Comments

Mark Brown Oct. 21, 2019, 2:52 p.m. UTC | #1
On Mon, Oct 21, 2019 at 04:08:15PM +0200, Nuno Sá wrote:
> This changes are in accordance with the review done to this bindings.
> This is a follow-up patch to 969d49b2cdc8.

Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.
Sa, Nuno Oct. 22, 2019, 8:05 a.m. UTC | #2
Hi Mark,

On Mon, 2019-10-21 at 15:52 +0100, Mark Brown wrote:]
> 
> On Mon, Oct 21, 2019 at 04:08:15PM +0200, Nuno Sá wrote:
> > This changes are in accordance with the review done to this
> > bindings.
> > This is a follow-up patch to 969d49b2cdc8.
> 
> Please include human readable descriptions of things like commits and
> issues being discussed in e-mail in your mails, this makes them much
> easier for humans to read especially when they have no internet
> access.
> I do frequently catch up on my mail on flights or while otherwise
> travelling so this is even more pressing for me than just being about
> making things a bit easier to read.

Noted, I won't use commit hashes like this anymore. Also, I saw that you
applied the patch already and just FYI, the patch:

b2d6ee753126 (origin/for-5.5) ASOC: adau7118: Change regulators id

is pointing to b670e44fc3bd in it's description which does not exist.

I see that descriptions like this can lead to this situations. Sorry about
this...

Regards,
Nuno Sá
Rob Herring Oct. 28, 2019, 11:29 p.m. UTC | #3
On Mon, Oct 21, 2019 at 9:08 AM Nuno Sá <nuno.sa@analog.com> wrote:
>
> This changes are in accordance with the review done to this bindings.
> This is a follow-up patch to 969d49b2cdc8.
>
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> ---
>  .../bindings/sound/adi,adau7118.yaml          | 25 ++++++++-----------
>  1 file changed, 10 insertions(+), 15 deletions(-)

Still some issues here...

>
> diff --git a/Documentation/devicetree/bindings/sound/adi,adau7118.yaml b/Documentation/devicetree/bindings/sound/adi,adau7118.yaml
> index cfcef602b3d9..c3f10afbdd6f 100644
> --- a/Documentation/devicetree/bindings/sound/adi,adau7118.yaml
> +++ b/Documentation/devicetree/bindings/sound/adi,adau7118.yaml
> @@ -26,13 +26,11 @@ properties:
>    "#sound-dai-cells":
>      const: 0
>
> -  IOVDD-supply:
> +  iovdd-supply:
>      description: Digital Input/Output Power Supply.
> -    $ref: "/schemas/types.yaml#/definitions/phandle"
>
> -  DVDD-supply:
> +  dvdd-supply:
>      description: Internal Core Digital Power Supply.
> -    $ref: "/schemas/types.yaml#/definitions/phandle"
>
>    adi,decimation-ratio:
>      description: |
> @@ -58,23 +56,21 @@ properties:
>  required:
>    - "#sound-dai-cells"
>    - compatible
> -  - IOVDD-supply
> -  - DVDD-supply
> +  - iovdd-supply
> +  - dvdd-supply
>
>  examples:
>    - |
> -    i2c0 {
> +    i2c {
>          /* example with i2c support */
>          #address-cells = <1>;
>          #size-cells = <0>;
> -        status = "okay";
> -        adau7118_codec: adau7118-codec@14 {
> +        adau7118_codec: audio-codec@14 {

Documentation/devicetree/bindings/sound/adi,adau7118.example.dts:21.44-29.15:
Warning (i2c_bus_reg): /example-0/i2c/audio-codec@14: I2C bus unit
address format error, expected "e"

Unit-address should be in hex.

>                  compatible = "adi,adau7118";
>                  reg = <14>;
>                  #sound-dai-cells = <0>;
> -                status = "okay";
> -                IOVDD-supply = <&supply>;
> -                DVDD-supply = <&supply>;
> +                iovdd-supply = <&supply>;
> +                dvdd-supply = <&supply>;
>                  adi,pdm-clk-map = <1 1 0 0>;
>                  adi,decimation-ratio = <16>;
>          };
> @@ -84,7 +80,6 @@ examples:
>      adau7118_codec_hw: adau7118-codec-hw {
>              compatible = "adi,adau7118";
>              #sound-dai-cells = <0>;
> -            status = "okay";
> -            IOVDD-supply = <&supply>;
> -            DVDD-supply = <&supply>;
> +            iovdd-supply = <&supply>;
> +            dvdd-supply = <&supply>;
>      };
> --
> 2.23.0
>

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/sound/adi,adau7118.yaml b/Documentation/devicetree/bindings/sound/adi,adau7118.yaml
index cfcef602b3d9..c3f10afbdd6f 100644
--- a/Documentation/devicetree/bindings/sound/adi,adau7118.yaml
+++ b/Documentation/devicetree/bindings/sound/adi,adau7118.yaml
@@ -26,13 +26,11 @@  properties:
   "#sound-dai-cells":
     const: 0
 
-  IOVDD-supply:
+  iovdd-supply:
     description: Digital Input/Output Power Supply.
-    $ref: "/schemas/types.yaml#/definitions/phandle"
 
-  DVDD-supply:
+  dvdd-supply:
     description: Internal Core Digital Power Supply.
-    $ref: "/schemas/types.yaml#/definitions/phandle"
 
   adi,decimation-ratio:
     description: |
@@ -58,23 +56,21 @@  properties:
 required:
   - "#sound-dai-cells"
   - compatible
-  - IOVDD-supply
-  - DVDD-supply
+  - iovdd-supply
+  - dvdd-supply
 
 examples:
   - |
-    i2c0 {
+    i2c {
         /* example with i2c support */
         #address-cells = <1>;
         #size-cells = <0>;
-        status = "okay";
-        adau7118_codec: adau7118-codec@14 {
+        adau7118_codec: audio-codec@14 {
                 compatible = "adi,adau7118";
                 reg = <14>;
                 #sound-dai-cells = <0>;
-                status = "okay";
-                IOVDD-supply = <&supply>;
-                DVDD-supply = <&supply>;
+                iovdd-supply = <&supply>;
+                dvdd-supply = <&supply>;
                 adi,pdm-clk-map = <1 1 0 0>;
                 adi,decimation-ratio = <16>;
         };
@@ -84,7 +80,6 @@  examples:
     adau7118_codec_hw: adau7118-codec-hw {
             compatible = "adi,adau7118";
             #sound-dai-cells = <0>;
-            status = "okay";
-            IOVDD-supply = <&supply>;
-            DVDD-supply = <&supply>;
+            iovdd-supply = <&supply>;
+            dvdd-supply = <&supply>;
     };