| Message ID | 20191021170608.26412-3-beniamin.bia@analog.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | None | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success |
On Mon, Oct 21, 2019 at 08:06:07PM +0300, Beniamin Bia wrote: > Documentation for AD7091R5 ADC was added. > > Signed-off-by: Beniamin Bia <beniamin.bia@analog.com> > --- > .../bindings/iio/adc/adi,ad7091r5.yaml | 53 +++++++++++++++++++ > 1 file changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml > new file mode 100644 > index 000000000000..d041cd76804e > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml > @@ -0,0 +1,53 @@ > +# SPDX-License-Identifier: GPL-2.0 (GPL-2.0-only OR BSD-2-Clause) for new bindings please. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/adi,ad7091r5.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices AD7091R5 4-Channel 12-Bit ADC > + > +maintainers: > + - Beniamin Bia <beniamin.bia@analog.com> > + > +description: | > + Analog Devices AD7091R5 4-Channel 12-Bit ADC > + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7091r-5.pdf > + > +properties: > + compatible: > + enum: > + - adi,ad7091R5 lowercase 'r' or be consistent with the filename. > + > + reg: > + maxItems: 1 > + > + avcc-supply: > + description: > + Phandle to the Avcc power supply > + maxItems: 1 Not an array, so you can drop this. > + > + interrupts: > + maxItems: 1 > + > + > +required: > + - compatible > + - reg Add: additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + adc@0 { adc@2f > + compatible = "adi,ad7091r5"; Doesn't match the schema. > + reg = <0x2F>; Lowercase hex. > + > + interrupts = <25 IRQ_TYPE_EDGE_FALLING>; > + interrupt-parent = <&gpio>; > + }; > + }; > +... > -- > 2.17.1 >
diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml new file mode 100644 index 000000000000..d041cd76804e --- /dev/null +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml @@ -0,0 +1,53 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/adc/adi,ad7091r5.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Analog Devices AD7091R5 4-Channel 12-Bit ADC + +maintainers: + - Beniamin Bia <beniamin.bia@analog.com> + +description: | + Analog Devices AD7091R5 4-Channel 12-Bit ADC + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7091r-5.pdf + +properties: + compatible: + enum: + - adi,ad7091R5 + + reg: + maxItems: 1 + + avcc-supply: + description: + Phandle to the Avcc power supply + maxItems: 1 + + interrupts: + maxItems: 1 + + +required: + - compatible + - reg + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + #include <dt-bindings/interrupt-controller/irq.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + + adc@0 { + compatible = "adi,ad7091r5"; + reg = <0x2F>; + + interrupts = <25 IRQ_TYPE_EDGE_FALLING>; + interrupt-parent = <&gpio>; + }; + }; +...
Documentation for AD7091R5 ADC was added. Signed-off-by: Beniamin Bia <beniamin.bia@analog.com> --- .../bindings/iio/adc/adi,ad7091r5.yaml | 53 +++++++++++++++++++ 1 file changed, 53 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml