| Message ID | 20191021133950.30490-1-narmstrong@baylibre.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | dt-bindings: soc: amlogic: canvas: convert to yaml | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | "total: 0 errors, 2 warnings, 49 lines checked" |
| robh/dt-meta-schema | success |
On Mon, Oct 21, 2019 at 3:40 PM Neil Armstrong <narmstrong@baylibre.com> wrote: > > Now that we have the DT validation in place, let's convert the device tree > bindings for the Amlogic Canvas over to a YAML schemas. > > Cc: Maxime Jourdan <mjourdan@baylibre.com> > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> one nit-pick below, but I leave it up to Maxime to decide whether it's needed: Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> [...] > diff --git a/Documentation/devicetree/bindings/soc/amlogic/amlogic,canvas.yaml b/Documentation/devicetree/bindings/soc/amlogic/amlogic,canvas.yaml > new file mode 100644 > index 000000000000..4322f876753d > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/amlogic/amlogic,canvas.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright 2019 BayLibre, SAS > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/soc/amlogic/amlogic,canvas.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Amlogic Canvas personally I prefer "Amlogic Canvas Video Lookup Table" because that's also what we use (abbreviated as video-lut) for the node name Martin
On Mon, 21 Oct 2019 15:39:50 +0200, Neil Armstrong wrote: > Now that we have the DT validation in place, let's convert the device tree > bindings for the Amlogic Canvas over to a YAML schemas. > > Cc: Maxime Jourdan <mjourdan@baylibre.com> > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > --- > .../bindings/soc/amlogic/amlogic,canvas.txt | 33 ------------- > .../bindings/soc/amlogic/amlogic,canvas.yaml | 49 +++++++++++++++++++ > 2 files changed, 49 insertions(+), 33 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/soc/amlogic/amlogic,canvas.txt > create mode 100644 Documentation/devicetree/bindings/soc/amlogic/amlogic,canvas.yaml > Updated 'title' and applied, thanks. Rob
diff --git a/Documentation/devicetree/bindings/soc/amlogic/amlogic,canvas.txt b/Documentation/devicetree/bindings/soc/amlogic/amlogic,canvas.txt deleted file mode 100644 index e876f3ce54f6..000000000000 --- a/Documentation/devicetree/bindings/soc/amlogic/amlogic,canvas.txt +++ /dev/null @@ -1,33 +0,0 @@ -Amlogic Canvas -================================ - -A canvas is a collection of metadata that describes a pixel buffer. -Those metadata include: width, height, phyaddr, wrapping and block mode. -Starting with GXBB the endianness can also be described. - -Many IPs within Amlogic SoCs rely on canvas indexes to read/write pixel data -rather than use the phy addresses directly. For instance, this is the case for -the video decoders and the display. - -Amlogic SoCs have 256 canvas. - -Device Tree Bindings: ---------------------- - -Video Lookup Table --------------------------- - -Required properties: -- compatible: has to be one of: - - "amlogic,meson8-canvas", "amlogic,canvas" on Meson8 - - "amlogic,meson8b-canvas", "amlogic,canvas" on Meson8b - - "amlogic,meson8m2-canvas", "amlogic,canvas" on Meson8m2 - - "amlogic,canvas" on GXBB and newer -- reg: Base physical address and size of the canvas registers. - -Example: - -canvas: video-lut@48 { - compatible = "amlogic,canvas"; - reg = <0x0 0x48 0x0 0x14>; -}; diff --git a/Documentation/devicetree/bindings/soc/amlogic/amlogic,canvas.yaml b/Documentation/devicetree/bindings/soc/amlogic/amlogic,canvas.yaml new file mode 100644 index 000000000000..4322f876753d --- /dev/null +++ b/Documentation/devicetree/bindings/soc/amlogic/amlogic,canvas.yaml @@ -0,0 +1,49 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +# Copyright 2019 BayLibre, SAS +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/soc/amlogic/amlogic,canvas.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Amlogic Canvas + +maintainers: + - Neil Armstrong <narmstrong@baylibre.com> + - Maxime Jourdan <mjourdan@baylibre.com> + +description: | + A canvas is a collection of metadata that describes a pixel buffer. + Those metadata include: width, height, phyaddr, wrapping and block mode. + Starting with GXBB the endianness can also be described. + + Many IPs within Amlogic SoCs rely on canvas indexes to read/write pixel data + rather than use the phy addresses directly. For instance, this is the case for + the video decoders and the display. + + Amlogic SoCs have 256 canvas. + +properties: + compatible: + oneOf: + - items: + - enum: + - amlogic,meson8-canvas + - amlogic,meson8b-canvas + - amlogic,meson8m2-canvas + - const: amlogic,canvas + - const: amlogic,canvas # GXBB and newer SoCs + + reg: + maxItems: 1 + +required: + - compatible + - reg + +examples: + - | + canvas: video-lut@48 { + compatible = "amlogic,canvas"; + reg = <0x48 0x14>; + }; +
Now that we have the DT validation in place, let's convert the device tree bindings for the Amlogic Canvas over to a YAML schemas. Cc: Maxime Jourdan <mjourdan@baylibre.com> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> --- .../bindings/soc/amlogic/amlogic,canvas.txt | 33 ------------- .../bindings/soc/amlogic/amlogic,canvas.yaml | 49 +++++++++++++++++++ 2 files changed, 49 insertions(+), 33 deletions(-) delete mode 100644 Documentation/devicetree/bindings/soc/amlogic/amlogic,canvas.txt create mode 100644 Documentation/devicetree/bindings/soc/amlogic/amlogic,canvas.yaml