From patchwork Sat Oct 19 23:47:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 1179922 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amsat.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="adqvvPr6"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46wfsc1C44z9sPK for ; Sun, 20 Oct 2019 10:55:16 +1100 (AEDT) Received: from localhost ([::1]:42194 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLyYz-0001QW-Kc for incoming@patchwork.ozlabs.org; Sat, 19 Oct 2019 19:55:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34717) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLyRk-0000Y1-KM for qemu-devel@nongnu.org; Sat, 19 Oct 2019 19:47:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iLyRj-0005h4-Gp for qemu-devel@nongnu.org; Sat, 19 Oct 2019 19:47:44 -0400 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:56112) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iLyRj-0005gV-Ar; Sat, 19 Oct 2019 19:47:43 -0400 Received: by mail-wm1-x344.google.com with SMTP id g24so376050wmh.5; Sat, 19 Oct 2019 16:47:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bG9RMPIGC9ljNya02ZnuD6xFZnx6LHmfx6JD2fgLckE=; b=adqvvPr6OvliCpivqvTDkGK5pQwwU3ewhTuLsLRCQEk84kVmVPjdrMkB0UNfCg7zlB oBcYILWfOQZ5/xZYuqggf1n4qHUx22Lc4oLoSjP6lV7GDKAz1h1VMG+cWnwhvkwF0XP9 lQ3CeE3jffuGat5ctNihyts9U1Xo/aIOiy+HMP54f/qmasHdf3gJL9j2lcTpxhfZ3Omy 5UwntNzjxICuMpA7S8Sf8cuXtSWhqtTOZ6Ka4Q436UZnmW9UpQQsJfl17/ry9G43NJ7f Ns0nopxdld0vPWVvKNwQHCE21zoUayIkXKNf7zp1vISoauT3CbkT4UQxcr2rcuqTZFb9 Xg0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=bG9RMPIGC9ljNya02ZnuD6xFZnx6LHmfx6JD2fgLckE=; b=Fc1uG7ml7wE9H+TPyRdbSi0aL6fehvn5mFo4nIOXZEImvIhn0z56cS1LBaB4D0ABg+ PPZhOon46O7suX3ElkzQJg+BIz0vZWRKlgwkWenyLNcD+G5aAVPVR50CmB19/R/ZGXOi CEsLaU8yPz6LpoUME85xNDjxf/QM2aO33Gpa1hUaEmlj4FLO6bKXXf3iDTuCgKMNnTBD EG4EsiEcSKMnJaekbjxlBp9yzAZvKTZMWtt3plldKPXD/mvy1kSHnFS2wBAhJxK5nXx5 bfg+mYWDeHKV+Rq24i6gBobiQ1VgQhpJoXaQwNCtuH/wbVSt0S4mkJVHSmpWVE+FpBUE cOSA== X-Gm-Message-State: APjAAAXjzQe4crn2UhMaMjYsG7VPALakgJecBoSlnWYB+ZK2+tvGlDOv i6blnOm/IP53hQx9M590QqP5sOfG X-Google-Smtp-Source: APXvYqz+Xqeje+XUM0XtNWaXzciQQtB5xpxZpONv7PQ1gUn8R2r0pxMj5A7UANd8hdkOjpZgaRmi1Q== X-Received: by 2002:a1c:9c0c:: with SMTP id f12mr7379593wme.133.1571528862229; Sat, 19 Oct 2019 16:47:42 -0700 (PDT) Received: from x1w.redhat.com (14.red-88-21-201.staticip.rima-tde.net. [88.21.201.14]) by smtp.gmail.com with ESMTPSA id u1sm10433763wrp.56.2019.10.19.16.47.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Oct 2019 16:47:41 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v3 14/16] hw/arm/highbank: Use AddressSpace when using write_secondary_boot() Date: Sun, 20 Oct 2019 01:47:13 +0200 Message-Id: <20191019234715.25750-15-f4bug@amsat.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20191019234715.25750-1-f4bug@amsat.org> References: <20191019234715.25750-1-f4bug@amsat.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::344 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Matthias Brugger , Rob Herring , Alistair Francis , Richard Henderson , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Andrew Baumann , Esteban Bosse , "Emilio G . Cota" , Clement Deschamps , qemu-arm@nongnu.org, Cleber Rosa , Laurent Bonnans , Cheng Xiang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Pekka Enberg , Pete Batard Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" write_secondary_boot() is used in SMP configurations where the CPU address space might not be the main System Bus. The rom_add_blob_fixed_as() function allow us to specify an address space. Use it to write each boot blob in the corresponding CPU address space. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/arm/highbank.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c index f1724d6929..518d935fdf 100644 --- a/hw/arm/highbank.c +++ b/hw/arm/highbank.c @@ -78,7 +78,8 @@ static void hb_write_secondary(ARMCPU *cpu, const struct arm_boot_info *info) for (n = 0; n < ARRAY_SIZE(smpboot); n++) { smpboot[n] = tswap32(smpboot[n]); } - rom_add_blob_fixed("smpboot", smpboot, sizeof(smpboot), SMP_BOOT_ADDR); + rom_add_blob_fixed_as("smpboot", smpboot, sizeof(smpboot), SMP_BOOT_ADDR, + arm_boot_address_space(cpu, info)); } static void hb_reset_secondary(ARMCPU *cpu, const struct arm_boot_info *info)