[v2,01/11] Documentation: dt: wireless: update wl1251 for sdio
diff mbox series

Message ID 741828f69eca2a9c9a0a7e80973c91f50cc71f9b.1571510481.git.hns@goldelico.com
State Changes Requested
Headers show
Series
  • OpenPandora: make wl1251 connected to mmc3 sdio port of OpenPandora work again
Related show

Checks

Context Check Description
robh/checkpatch success

Commit Message

H. Nikolaus Schaller Oct. 19, 2019, 6:41 p.m. UTC
The standard method for sdio devices connected to
an sdio interface is to define them as a child node
like we can see with wlcore.

Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
Acked-by: Kalle Valo <kvalo@codeaurora.org>
---
 .../bindings/net/wireless/ti,wl1251.txt       | 26 +++++++++++++++++++
 1 file changed, 26 insertions(+)

Comments

Rob Herring Oct. 25, 2019, 9:13 p.m. UTC | #1
On Sat, Oct 19, 2019 at 08:41:16PM +0200, H. Nikolaus Schaller wrote:
> The standard method for sdio devices connected to
> an sdio interface is to define them as a child node
> like we can see with wlcore.
> 
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> Acked-by: Kalle Valo <kvalo@codeaurora.org>
> ---
>  .../bindings/net/wireless/ti,wl1251.txt       | 26 +++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt b/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt
> index bb2fcde6f7ff..88612ff29f2d 100644
> --- a/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt
> +++ b/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt
> @@ -35,3 +35,29 @@ Examples:
>  		ti,power-gpio = <&gpio3 23 GPIO_ACTIVE_HIGH>; /* 87 */
>  	};
>  };
> +
> +&mmc3 {
> +	vmmc-supply = <&wlan_en>;
> +
> +	bus-width = <4>;
> +	non-removable;
> +	ti,non-removable;
> +	cap-power-off-card;
> +
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&mmc3_pins>;

None of the above are really relevant to this binding.

> +
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +
> +	wlan: wl1251@1 {

wifi@1

> +		compatible = "ti,wl1251";
> +
> +		reg = <1>;
> +
> +		interrupt-parent = <&gpio1>;
> +		interrupts = <21 IRQ_TYPE_LEVEL_HIGH>;	/* GPIO_21 */
> +
> +		ti,wl1251-has-eeprom;
> +	};
> +};
> -- 
> 2.19.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
H. Nikolaus Schaller Oct. 26, 2019, 8:24 a.m. UTC | #2
> Am 25.10.2019 um 23:13 schrieb Rob Herring <robh@kernel.org>:
> 
> On Sat, Oct 19, 2019 at 08:41:16PM +0200, H. Nikolaus Schaller wrote:
>> The standard method for sdio devices connected to
>> an sdio interface is to define them as a child node
>> like we can see with wlcore.
>> 
>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
>> Acked-by: Kalle Valo <kvalo@codeaurora.org>
>> ---
>> .../bindings/net/wireless/ti,wl1251.txt       | 26 +++++++++++++++++++
>> 1 file changed, 26 insertions(+)
>> 
>> diff --git a/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt b/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt
>> index bb2fcde6f7ff..88612ff29f2d 100644
>> --- a/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt
>> +++ b/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt
>> @@ -35,3 +35,29 @@ Examples:
>> 		ti,power-gpio = <&gpio3 23 GPIO_ACTIVE_HIGH>; /* 87 */
>> 	};
>> };
>> +
>> +&mmc3 {
>> +	vmmc-supply = <&wlan_en>;
>> +
>> +	bus-width = <4>;
>> +	non-removable;
>> +	ti,non-removable;
>> +	cap-power-off-card;
>> +
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&mmc3_pins>;
> 
> None of the above are really relevant to this binding.

Ok, but how and where do we document that they are needed to make both ends of the interface work together?

> 
>> +
>> +	#address-cells = <1>;
>> +	#size-cells = <0>;
>> +
>> +	wlan: wl1251@1 {
> 
> wifi@1

Ok.

> 
>> +		compatible = "ti,wl1251";
>> +
>> +		reg = <1>;
>> +
>> +		interrupt-parent = <&gpio1>;
>> +		interrupts = <21 IRQ_TYPE_LEVEL_HIGH>;	/* GPIO_21 */
>> +
>> +		ti,wl1251-has-eeprom;
>> +	};
>> +};
>> -- 
>> 2.19.1
>> 

BR and thanks,
Nikolaus

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt b/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt
index bb2fcde6f7ff..88612ff29f2d 100644
--- a/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt
+++ b/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt
@@ -35,3 +35,29 @@  Examples:
 		ti,power-gpio = <&gpio3 23 GPIO_ACTIVE_HIGH>; /* 87 */
 	};
 };
+
+&mmc3 {
+	vmmc-supply = <&wlan_en>;
+
+	bus-width = <4>;
+	non-removable;
+	ti,non-removable;
+	cap-power-off-card;
+
+	pinctrl-names = "default";
+	pinctrl-0 = <&mmc3_pins>;
+
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	wlan: wl1251@1 {
+		compatible = "ti,wl1251";
+
+		reg = <1>;
+
+		interrupt-parent = <&gpio1>;
+		interrupts = <21 IRQ_TYPE_LEVEL_HIGH>;	/* GPIO_21 */
+
+		ti,wl1251-has-eeprom;
+	};
+};