From patchwork Sat Oct 19 12:27:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabrice Fontaine X-Patchwork-Id: 1179802 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.138; helo=whitealder.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Sm24ZK0+"; dkim-atps=neutral Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46wMc20L0sz9sNx for ; Sat, 19 Oct 2019 23:27:29 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 334F286BC4; Sat, 19 Oct 2019 12:27:28 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id n1drYrSuifIQ; Sat, 19 Oct 2019 12:27:27 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 0D66086A0B; Sat, 19 Oct 2019 12:27:27 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 39FEC1BF31F for ; Sat, 19 Oct 2019 12:27:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 3566B87EB0 for ; Sat, 19 Oct 2019 12:27:26 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kzKQj2RrbpG0 for ; Sat, 19 Oct 2019 12:27:25 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by hemlock.osuosl.org (Postfix) with ESMTPS id C999287E34 for ; Sat, 19 Oct 2019 12:27:24 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id p4so8909940wrm.8 for ; Sat, 19 Oct 2019 05:27:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=wgQEA1XV1nSfe/b7/eT9oR4onyceCpZY8lMTuInD6Tk=; b=Sm24ZK0+T9FYShk1lbv7jPEctM5hWHYiWtSMbtECbHDZJrS1ud2cHM5gN5cESbC2ut tyiGZ/XlqcCUI8LA2pMxfwOQtB7d/32ARXvfOB+dK6GgZebyDFmbGlNc0HQ385D8G302 Jn0zWnSnhHDcfhv9t9A2OaPcekt0xkW5f6vn4OnJXpG81BHIR5PvNSYbfq415PSIXg5I LYj4WGUagqH5zloOfcFAyU8vuMNeCvnZZNuSw+oJoiyO8UHf562gdmFp8vBG8pEKF4fT 67Db6OLv4D3lX358DKIBOROEtal/Jm6cv63aRk572FNupwG7pGgnV/EAm9ksPVbskkLM lqpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=wgQEA1XV1nSfe/b7/eT9oR4onyceCpZY8lMTuInD6Tk=; b=i9R4kbhysFBym5h4PXPRGA8UJ4Fu9FEKhvBNayLS/IvzY/ERIvr7sOnDm4Dv+4zZTH iFyp8uyHvrrFQUPoAq16NwyMMefUM9f6cq47X0cKWG4ID2SlXV1uUHOIJ/HqayFz19bt qX40seCmv3+FXrxhXsNz8t+c1wWXgC4nrAwSNZpVgDE5qhQYt3kVvePSIh+jqqf4z34R 38DehB/jHrih3iW3WnhQ9qHKpbnvVfB2BBEk1HDznVcNTsBK0ohYAGdxOihTtdeCdFqC iMqmDEtFo+5cuk+WXCU/8/qpuye8vGcq5qXfz663/DufuGtfNHaAGbzV+IDTeve8VXvk lmHw== X-Gm-Message-State: APjAAAWgxXw9uCQc0/asPAEZjzHZ9Dlo25yS4nsvcDqBoNSQddk34uqa sa67BQ/oQSyPT4MWsGfxaXTkxmkJ X-Google-Smtp-Source: APXvYqxTqfVDjsOX02i2UNa2uhFxVQnSxT4WRYh2+lvcZ/NkuwF5sW6gDhF72nGB7HJdUbGvY9yCnw== X-Received: by 2002:adf:f402:: with SMTP id g2mr12225085wro.64.1571488042930; Sat, 19 Oct 2019 05:27:22 -0700 (PDT) Received: from kali.home (lfbn-1-3732-187.w86-229.abo.wanadoo.fr. [86.229.230.187]) by smtp.gmail.com with ESMTPSA id p10sm9941067wrx.2.2019.10.19.05.27.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Oct 2019 05:27:22 -0700 (PDT) From: Fabrice Fontaine To: buildroot@buildroot.org Date: Sat, 19 Oct 2019 14:27:59 +0200 Message-Id: <20191019122759.529-1-fontaine.fabrice@gmail.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Subject: [Buildroot] [PATCH v5, 1/1] package/libopenssl: set no-asm with generic architectures X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fabrice Fontaine Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Use no-asm when building with generic architectures such as gcc or linux-generic32, see https://github.com/openssl/openssl/issues/9839 This will fix a static build failure on x86_64 due to the removal of x86/x86_64 BSAES and AES_ASM support by https://github.com/openssl/openssl/commit/87bea6550ae0dda7c40937cff2e86cc2b0b09491 Fixes: - http://autobuild.buildroot.org/results/e4f04bb13ec1b82b73db645bea4933e52bca4185 Signed-off-by: Fabrice Fontaine --- Changes v4 -> v5 (after review of Thomas Petazzoni): - Reword commit message to remove statically Changes v3 -> v4 (after review of Thomas Petazzoni): - Fix copy/paste error and remove the second assignation Changes v2 -> v3 (after review of Thomas Petazzoni): - Set no-asm with linux-generic32 Changes v1 -> v2 (after review of Thomas Petazzoni): - Set no-asm with all static builds and not only x86_64 package/libopenssl/libopenssl.mk | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/package/libopenssl/libopenssl.mk b/package/libopenssl/libopenssl.mk index 4a430bcb4d..a1bbf9a900 100644 --- a/package/libopenssl/libopenssl.mk +++ b/package/libopenssl/libopenssl.mk @@ -12,7 +12,9 @@ LIBOPENSSL_LICENSE_FILES = LICENSE LIBOPENSSL_INSTALL_STAGING = YES LIBOPENSSL_DEPENDENCIES = zlib HOST_LIBOPENSSL_DEPENDENCIES = host-zlib -LIBOPENSSL_TARGET_ARCH = linux-generic32 +# no-asm is needed with generic architectures such as linux-generic32, see +# https://github.com/openssl/openssl/issues/9839 +LIBOPENSSL_TARGET_ARCH = linux-generic32 no-asm LIBOPENSSL_CFLAGS = $(TARGET_CFLAGS) LIBOPENSSL_PROVIDES = openssl @@ -55,7 +57,9 @@ endif ifeq ($(BR2_STATIC_LIBS),y) # Use "gcc" minimalistic target to disable DSO -LIBOPENSSL_TARGET_ARCH = gcc +# no-asm is needed with generic architectures such as gcc, see +# https://github.com/openssl/openssl/issues/9839 +LIBOPENSSL_TARGET_ARCH = gcc no-asm else # Some architectures are optimized in OpenSSL # Doesn't work for thumb-only (Cortex-M?)