lib: fwts_log_html: set max-width for line wrap
diff mbox series

Message ID 20191018182110.13513-1-alex.hung@canonical.com
State Accepted
Headers show
Series
  • lib: fwts_log_html: set max-width for line wrap
Related show

Commit Message

Alex Hung Oct. 18, 2019, 6:21 p.m. UTC
This is to avoid horizontal scroll bar.

This patch also fixes a typo from style_info to style_infos.

Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 src/lib/src/fwts_log_html.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

ivanhu Oct. 29, 2019, 7:49 a.m. UTC | #1
On 10/19/19 2:21 AM, Alex Hung wrote:
> This is to avoid horizontal scroll bar.
>
> This patch also fixes a typo from style_info to style_infos.
>
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/lib/src/fwts_log_html.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/lib/src/fwts_log_html.c b/src/lib/src/fwts_log_html.c
> index 20c08471..342f0e6c 100644
> --- a/src/lib/src/fwts_log_html.c
> +++ b/src/lib/src/fwts_log_html.c
> @@ -439,7 +439,7 @@ static void fwts_log_open_html(fwts_log_file *log_file)
>  		".style_error { background-color: orange; font-weight: bold; "
>  		"text-align: center; vertical-align: center }\n"
>  		".style_subtest { background-color: lightgray; }\n"
> -		".style_info { }\n"
> +		".style_infos { max-width:90em }\n"
>  		".style_code { font-family: \"courier\",\"mono\"; font-size:0.75em; overflow:auto; "
>  		"width:90%; line-height:1.08em; font-stretch:extra-condensed; word-wrap:normal }\n");
>  	fwts_log_html(log_file, "</STYLE>\n");


Acked-by: Ivan Hu <ivan.hu@canonical.com>
Colin Ian King Nov. 6, 2019, 10:49 a.m. UTC | #2
On 18/10/2019 19:21, Alex Hung wrote:
> This is to avoid horizontal scroll bar.
> 
> This patch also fixes a typo from style_info to style_infos.
> 
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/lib/src/fwts_log_html.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/lib/src/fwts_log_html.c b/src/lib/src/fwts_log_html.c
> index 20c08471..342f0e6c 100644
> --- a/src/lib/src/fwts_log_html.c
> +++ b/src/lib/src/fwts_log_html.c
> @@ -439,7 +439,7 @@ static void fwts_log_open_html(fwts_log_file *log_file)
>  		".style_error { background-color: orange; font-weight: bold; "
>  		"text-align: center; vertical-align: center }\n"
>  		".style_subtest { background-color: lightgray; }\n"
> -		".style_info { }\n"
> +		".style_infos { max-width:90em }\n"
>  		".style_code { font-family: \"courier\",\"mono\"; font-size:0.75em; overflow:auto; "
>  		"width:90%; line-height:1.08em; font-stretch:extra-condensed; word-wrap:normal }\n");
>  	fwts_log_html(log_file, "</STYLE>\n");
> 
Good catch.

Acked-by: Colin Ian King <colin.king@canonical.com>

Patch
diff mbox series

diff --git a/src/lib/src/fwts_log_html.c b/src/lib/src/fwts_log_html.c
index 20c08471..342f0e6c 100644
--- a/src/lib/src/fwts_log_html.c
+++ b/src/lib/src/fwts_log_html.c
@@ -439,7 +439,7 @@  static void fwts_log_open_html(fwts_log_file *log_file)
 		".style_error { background-color: orange; font-weight: bold; "
 		"text-align: center; vertical-align: center }\n"
 		".style_subtest { background-color: lightgray; }\n"
-		".style_info { }\n"
+		".style_infos { max-width:90em }\n"
 		".style_code { font-family: \"courier\",\"mono\"; font-size:0.75em; overflow:auto; "
 		"width:90%; line-height:1.08em; font-stretch:extra-condensed; word-wrap:normal }\n");
 	fwts_log_html(log_file, "</STYLE>\n");