From patchwork Fri Oct 18 16:56:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabrice Fontaine X-Patchwork-Id: 1179525 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="LZ+cixWx"; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46vscl3WlBz9sPT for ; Sat, 19 Oct 2019 03:56:20 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 4F4DE86AF4; Fri, 18 Oct 2019 16:56:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yO_nk4-iXl-R; Fri, 18 Oct 2019 16:56:15 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id A6D8E86A9D; Fri, 18 Oct 2019 16:56:15 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 993CE1BF31B for ; Fri, 18 Oct 2019 16:56:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 95BC0877D4 for ; Fri, 18 Oct 2019 16:56:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e5wyuYuhJKf4 for ; Fri, 18 Oct 2019 16:56:14 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by whitealder.osuosl.org (Postfix) with ESMTPS id A77E6877BB for ; Fri, 18 Oct 2019 16:56:13 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id b24so6762637wmj.5 for ; Fri, 18 Oct 2019 09:56:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QxGP7wUwfTOfCPVrq/ScdS9p/H3cuFHUL/2y3HbMqgw=; b=LZ+cixWxxOkG1MSOhrv+GwdsKWt8wRi8gW/sp6VRAEE2N/Gk4HbrfjrBx3TRa1+JW2 MeC8KE/G+bV9qnkw03XUxar5XW0TpQ4ITWmqHFZpxJDCVvspMCbaS/efMdnADxyQK6Of B3bqc8K/K+lYkzVhB8Ep/zPEDMyZ91cV+dtJOZLdZ+IeYCl4J1FRjz4eOQICk4IKCNzY Q/awINwlEg/p590gPe25HeaEg1BKZGb7InKXzXCLnZM/vXyLOGo1X8iGgDAnCN0TTnL6 wMDzbJ8AhEf3FdbU4CfyD2fKoRaFbX9kJABKXdFHU1VcG7pcxiXUtL44rg4dv2HrASY2 LwAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QxGP7wUwfTOfCPVrq/ScdS9p/H3cuFHUL/2y3HbMqgw=; b=mR3WqewhWyi0MT8llJw5TTeEwKrCUCliZEEB3Szi9h6Dr1QfR10irhV7q5YIfLcowD /LaOeY4Zu26a4FL5zg3zJAlgamtTFe8KrNxzp7t3QFZaQXRvTu/5d6jcP/4LjAl1DlgR d3GaG0b0wpIiDuzIJg8RKvaprpdmOhRQQjRSq6lB3v6AWpDNd1h7gmJc1PZO6OXLKCNI HL36pnhdeYk820DFFqNmgUfY0vMloUjVMT2+ih3bkCsgbnxCucWCLlY/CldtB4Mw6EMJ YYTbGNh/tuyzWDkktkLwxeZ/ZDf+4WE8ydREIAHHj4XfV/XvquzWu2JrAU6ItXncz1io NJhQ== X-Gm-Message-State: APjAAAWuxJbVn2A7rVZ7sMRqx3lHHrU/n/at9UhsRR4D4RjwgWCjACiz 2CQ3Z/ObSDstWCAnhiupfpL0yYAl X-Google-Smtp-Source: APXvYqyr/qDE0rq64v+c5jkCkfi7Jsc/Ndsntv7YCn46zrU3gl2GFz03tSEt0+OH8yvCM5U+MhuNDg== X-Received: by 2002:a1c:2604:: with SMTP id m4mr9032916wmm.112.1571417771614; Fri, 18 Oct 2019 09:56:11 -0700 (PDT) Received: from kali.home (lfbn-1-3732-187.w86-229.abo.wanadoo.fr. [86.229.230.187]) by smtp.gmail.com with ESMTPSA id u83sm12965486wme.0.2019.10.18.09.56.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2019 09:56:10 -0700 (PDT) From: Fabrice Fontaine To: buildroot@buildroot.org Date: Fri, 18 Oct 2019 18:56:44 +0200 Message-Id: <20191018165644.26442-1-fontaine.fabrice@gmail.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Subject: [Buildroot] [PATCH v4, 1/1] package/libopenssl: set no-asm with generic architectures X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fabrice Fontaine Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Use no-asm when building statically with a generic architecture such as gcc or linux-generic32, see https://github.com/openssl/openssl/issues/9839 This will fix a static build failure on x86_64 due to the removal of x86/x86_64 BSAES and AES_ASM support by https://github.com/openssl/openssl/commit/87bea6550ae0dda7c40937cff2e86cc2b0b09491 Fixes: - http://autobuild.buildroot.org/results/e4f04bb13ec1b82b73db645bea4933e52bca4185 Signed-off-by: Fabrice Fontaine --- Changes v3 -> v4 (after review of Thomas Petazzoni): - Fix copy/paste error and remove the second assignation Changes v2 -> v3 (after review of Thomas Petazzoni): - Set no-asm with linux-generic32 Changes v1 -> v2 (after review of Thomas Petazzoni): - Set no-asm with all static builds and not only x86_64 package/libopenssl/libopenssl.mk | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/package/libopenssl/libopenssl.mk b/package/libopenssl/libopenssl.mk index 4a430bcb4d..a1bbf9a900 100644 --- a/package/libopenssl/libopenssl.mk +++ b/package/libopenssl/libopenssl.mk @@ -12,7 +12,9 @@ LIBOPENSSL_LICENSE_FILES = LICENSE LIBOPENSSL_INSTALL_STAGING = YES LIBOPENSSL_DEPENDENCIES = zlib HOST_LIBOPENSSL_DEPENDENCIES = host-zlib -LIBOPENSSL_TARGET_ARCH = linux-generic32 +# no-asm is needed with generic architectures such as linux-generic32, see +# https://github.com/openssl/openssl/issues/9839 +LIBOPENSSL_TARGET_ARCH = linux-generic32 no-asm LIBOPENSSL_CFLAGS = $(TARGET_CFLAGS) LIBOPENSSL_PROVIDES = openssl @@ -55,7 +57,9 @@ endif ifeq ($(BR2_STATIC_LIBS),y) # Use "gcc" minimalistic target to disable DSO -LIBOPENSSL_TARGET_ARCH = gcc +# no-asm is needed with generic architectures such as gcc, see +# https://github.com/openssl/openssl/issues/9839 +LIBOPENSSL_TARGET_ARCH = gcc no-asm else # Some architectures are optimized in OpenSSL # Doesn't work for thumb-only (Cortex-M?)