| Message ID | 1317860006-18212-1-git-send-email-marek.vasut@gmail.com |
|---|---|
| State | Rejected |
| Headers | show |
On 10/05/2011 07:13 PM, Marek Vasut wrote: > Introduce CONFIG_SPL_NO_CPU_SUPPORT_CODE to avoid compiling the CPU support > library. This can be useful on some setups. > > Signed-off-by: Marek Vasut <marek.vasut@gmail.com> > Cc: Stefano Babic <sbabic@denx.de> > Cc: Wolfgang Denk <wd@denx.de> > Cc: Detlev Zundel <dzu@denx.de> > Cc: Scott Wood <scottwood@freescale.com> > --- > spl/Makefile | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/spl/Makefile b/spl/Makefile > index 91dd11a..fc9360f 100644 > --- a/spl/Makefile > +++ b/spl/Makefile > @@ -18,6 +18,11 @@ > CONFIG_SPL_BUILD := y > export CONFIG_SPL_BUILD > > +# In case we want to avoid the CPU support code, we need to define this: > +ifdef CONFIG_SPL_NO_CPU_SUPPORT_CODE > +export CONFIG_SPL_NO_CPU_SUPPORT_CODE > +endif Why do we need this here, but not for other config symbols that subordinate makefiles use (e.g. in the normal, non-SPL case)? Shouldn't the cpu makefile include config.mk, which includes autoconf.mk, which defines this symbol? -Scott
On Thursday, October 06, 2011 05:54:17 PM Scott Wood wrote: > On 10/05/2011 07:13 PM, Marek Vasut wrote: > > Introduce CONFIG_SPL_NO_CPU_SUPPORT_CODE to avoid compiling the CPU > > support library. This can be useful on some setups. > > > > Signed-off-by: Marek Vasut <marek.vasut@gmail.com> > > Cc: Stefano Babic <sbabic@denx.de> > > Cc: Wolfgang Denk <wd@denx.de> > > Cc: Detlev Zundel <dzu@denx.de> > > Cc: Scott Wood <scottwood@freescale.com> > > --- > > > > spl/Makefile | 5 +++++ > > 1 files changed, 5 insertions(+), 0 deletions(-) > > > > diff --git a/spl/Makefile b/spl/Makefile > > index 91dd11a..fc9360f 100644 > > --- a/spl/Makefile > > +++ b/spl/Makefile > > @@ -18,6 +18,11 @@ > > > > CONFIG_SPL_BUILD := y > > export CONFIG_SPL_BUILD > > > > +# In case we want to avoid the CPU support code, we need to define this: > > +ifdef CONFIG_SPL_NO_CPU_SUPPORT_CODE > > +export CONFIG_SPL_NO_CPU_SUPPORT_CODE > > +endif > > Why do we need this here, but not for other config symbols that > subordinate makefiles use (e.g. in the normal, non-SPL case)? > > Shouldn't the cpu makefile include config.mk, which includes > autoconf.mk, which defines this symbol? > > -Scott Right, you can ignore this patch and apply only 2/2. Cheers
diff --git a/spl/Makefile b/spl/Makefile index 91dd11a..fc9360f 100644 --- a/spl/Makefile +++ b/spl/Makefile @@ -18,6 +18,11 @@ CONFIG_SPL_BUILD := y export CONFIG_SPL_BUILD +# In case we want to avoid the CPU support code, we need to define this: +ifdef CONFIG_SPL_NO_CPU_SUPPORT_CODE +export CONFIG_SPL_NO_CPU_SUPPORT_CODE +endif + include $(TOPDIR)/config.mk # We want the final binaries in this directory
Introduce CONFIG_SPL_NO_CPU_SUPPORT_CODE to avoid compiling the CPU support library. This can be useful on some setups. Signed-off-by: Marek Vasut <marek.vasut@gmail.com> Cc: Stefano Babic <sbabic@denx.de> Cc: Wolfgang Denk <wd@denx.de> Cc: Detlev Zundel <dzu@denx.de> Cc: Scott Wood <scottwood@freescale.com> --- spl/Makefile | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)