[2/2] dt-bindings: msm: Add LLCC for SC7180
diff mbox series

Message ID 30f419d1612a3912e323287a96daa2b4fbe3dacd.1571406041.git.saiprakash.ranjan@codeaurora.org
State Superseded
Headers show
Series
  • Add LLCC support for SC7180
Related show

Checks

Context Check Description
robh/checkpatch success

Commit Message

Sai Prakash Ranjan Oct. 18, 2019, 1:57 p.m. UTC
Add LLCC compatible for SC7180 SoC.

Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
---
 Documentation/devicetree/bindings/arm/msm/qcom,llcc.txt | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Stephen Boyd Oct. 18, 2019, 2:32 p.m. UTC | #1
Quoting Sai Prakash Ranjan (2019-10-18 06:57:09)
> Add LLCC compatible for SC7180 SoC.
> 
> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
> ---
>  Documentation/devicetree/bindings/arm/msm/qcom,llcc.txt | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Can you convert this binding to YAML? Would be useful to make sure it's
used properly.

> 
> diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,llcc.txt b/Documentation/devicetree/bindings/arm/msm/qcom,llcc.txt
> index eaee06b2d8f2..f263aa539d47 100644
> --- a/Documentation/devicetree/bindings/arm/msm/qcom,llcc.txt
> +++ b/Documentation/devicetree/bindings/arm/msm/qcom,llcc.txt
> @@ -11,7 +11,9 @@ Properties:
>  - compatible:
>         Usage: required
>         Value type: <string>
> -       Definition: must be "qcom,sdm845-llcc"
> +       Definition: must be one of:
> +                   "qcom,sc7180-llcc",
> +                   "qcom,sdm845-llcc"
>
Sai Prakash Ranjan Oct. 18, 2019, 3:27 p.m. UTC | #2
On 2019-10-18 20:02, Stephen Boyd wrote:
> Quoting Sai Prakash Ranjan (2019-10-18 06:57:09)
>> Add LLCC compatible for SC7180 SoC.
>> 
>> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
>> ---
>>  Documentation/devicetree/bindings/arm/msm/qcom,llcc.txt | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> Can you convert this binding to YAML? Would be useful to make sure it's
> used properly.
> 

Ok will do in next version.

>> 
>> diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,llcc.txt 
>> b/Documentation/devicetree/bindings/arm/msm/qcom,llcc.txt
>> index eaee06b2d8f2..f263aa539d47 100644
>> --- a/Documentation/devicetree/bindings/arm/msm/qcom,llcc.txt
>> +++ b/Documentation/devicetree/bindings/arm/msm/qcom,llcc.txt
>> @@ -11,7 +11,9 @@ Properties:
>>  - compatible:
>>         Usage: required
>>         Value type: <string>
>> -       Definition: must be "qcom,sdm845-llcc"
>> +       Definition: must be one of:
>> +                   "qcom,sc7180-llcc",
>> +                   "qcom,sdm845-llcc"
>>

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,llcc.txt b/Documentation/devicetree/bindings/arm/msm/qcom,llcc.txt
index eaee06b2d8f2..f263aa539d47 100644
--- a/Documentation/devicetree/bindings/arm/msm/qcom,llcc.txt
+++ b/Documentation/devicetree/bindings/arm/msm/qcom,llcc.txt
@@ -11,7 +11,9 @@  Properties:
 - compatible:
 	Usage: required
 	Value type: <string>
-	Definition: must be "qcom,sdm845-llcc"
+	Definition: must be one of:
+		    "qcom,sc7180-llcc",
+		    "qcom,sdm845-llcc"
 
 - reg:
 	Usage: required