| Message ID | f5bf07dccd8b552a76c84d49e80b86c5aa071122.1571400024.git.jbenc@redhat.com |
|---|---|
| State | Accepted |
| Delegated to: | BPF Maintainers |
| Headers | show |
| Series | [bpf] selftests/bpf: More compatible nc options in test_tc_edt | expand |
On Fri, Oct 18, 2019 at 5:00 AM Jiri Benc <jbenc@redhat.com> wrote: > > Out of the three nc implementations widely in use, at least two (BSD netcat > and nmap-ncat) do not support -l combined with -s. Modify the nc invocation > to be accepted by all of them. > > Fixes: 7df5e3db8f63 ("selftests: bpf: tc-bpf flow shaping with EDT") > Cc: Peter Oskolkov <posk@google.com> > Signed-off-by: Jiri Benc <jbenc@redhat.com> > --- > tools/testing/selftests/bpf/test_tc_edt.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/bpf/test_tc_edt.sh b/tools/testing/selftests/bpf/test_tc_edt.sh > index f38567ef694b..daa7d1b8d309 100755 > --- a/tools/testing/selftests/bpf/test_tc_edt.sh > +++ b/tools/testing/selftests/bpf/test_tc_edt.sh > @@ -59,7 +59,7 @@ ip netns exec ${NS_SRC} tc filter add dev veth_src egress \ > > # start the listener > ip netns exec ${NS_DST} bash -c \ > - "nc -4 -l -s ${IP_DST} -p 9000 >/dev/null &" > + "nc -4 -l -p 9000 >/dev/null &" The test passes with the regular linux/debian nc. If it passes will the rest, Acked-by: Peter Oskolkov <posk@google.com> > declare -i NC_PID=$! > sleep 1 > > -- > 2.18.1 >
On Fri, Oct 18, 2019 at 02:00:42PM +0200, Jiri Benc wrote: > Out of the three nc implementations widely in use, at least two (BSD netcat > and nmap-ncat) do not support -l combined with -s. Modify the nc invocation > to be accepted by all of them. > > Fixes: 7df5e3db8f63 ("selftests: bpf: tc-bpf flow shaping with EDT") > Cc: Peter Oskolkov <posk@google.com> > Signed-off-by: Jiri Benc <jbenc@redhat.com> Applied, thanks!
diff --git a/tools/testing/selftests/bpf/test_tc_edt.sh b/tools/testing/selftests/bpf/test_tc_edt.sh index f38567ef694b..daa7d1b8d309 100755 --- a/tools/testing/selftests/bpf/test_tc_edt.sh +++ b/tools/testing/selftests/bpf/test_tc_edt.sh @@ -59,7 +59,7 @@ ip netns exec ${NS_SRC} tc filter add dev veth_src egress \ # start the listener ip netns exec ${NS_DST} bash -c \ - "nc -4 -l -s ${IP_DST} -p 9000 >/dev/null &" + "nc -4 -l -p 9000 >/dev/null &" declare -i NC_PID=$! sleep 1
Out of the three nc implementations widely in use, at least two (BSD netcat and nmap-ncat) do not support -l combined with -s. Modify the nc invocation to be accepted by all of them. Fixes: 7df5e3db8f63 ("selftests: bpf: tc-bpf flow shaping with EDT") Cc: Peter Oskolkov <posk@google.com> Signed-off-by: Jiri Benc <jbenc@redhat.com> --- tools/testing/selftests/bpf/test_tc_edt.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)