Patchwork [U-Boot,4/7] drivers/net/smc91111.c: fix warning: variable ... set but not used

login
register
mail settings
Submitter Wolfgang Denk
Date Oct. 5, 2011, 9:17 p.m.
Message ID <1317849453-8216-4-git-send-email-wd@denx.de>
Download mbox | patch
Permalink /patch/117919/
State Accepted
Commit bf513c2d752f233a9027c42b94b143de670c21ae
Headers show

Comments

Wolfgang Denk - Oct. 5, 2011, 9:17 p.m.
Fix:
smc91111.c: In function 'smc_phy_configure':
smc91111.c:1194:6: warning: variable 'failed' set but not used [-Wunused-but-set-variable]
smc91111.c:1190:7: warning: variable 'phyaddr' set but not used [-Wunused-but-set-variable]

Signed-off-by: Wolfgang Denk <wd@denx.de>
---
 drivers/net/smc91111.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)
Wolfgang Denk - Oct. 9, 2011, 8:42 p.m.
Dear Wolfgang Denk,

In message <1317849453-8216-4-git-send-email-wd@denx.de> you wrote:
> Fix:
> smc91111.c: In function 'smc_phy_configure':
> smc91111.c:1194:6: warning: variable 'failed' set but not used [-Wunused-but-set-variable]
> smc91111.c:1190:7: warning: variable 'phyaddr' set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> ---
>  drivers/net/smc91111.c |    8 --------
>  1 files changed, 0 insertions(+), 8 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Patch

diff --git a/drivers/net/smc91111.c b/drivers/net/smc91111.c
index ba9c67e..9b8236d 100644
--- a/drivers/net/smc91111.c
+++ b/drivers/net/smc91111.c
@@ -1187,18 +1187,12 @@  static void smc_wait_ms(unsigned int ms)
 static void smc_phy_configure (struct eth_device *dev)
 {
 	int timeout;
-	byte phyaddr;
 	word my_phy_caps;	/* My PHY capabilities */
 	word my_ad_caps;	/* My Advertised capabilities */
 	word status = 0;	/*;my status = 0 */
-	int failed = 0;
 
 	PRINTK3 ("%s: smc_program_phy()\n", SMC_DEV_NAME);
 
-
-	/* Get the detected phy address */
-	phyaddr = SMC_PHY_ADDR;
-
 	/* Reset the PHY, setting all other bits to zero */
 	smc_write_phy_register (dev, PHY_CNTL_REG, PHY_CNTL_RST);
 
@@ -1296,13 +1290,11 @@  static void smc_phy_configure (struct eth_device *dev)
 
 	if (timeout < 1) {
 		printf ("%s: PHY auto-negotiate timed out\n", SMC_DEV_NAME);
-		failed = 1;
 	}
 
 	/* Fail if we detected an auto-negotiate remote fault */
 	if (status & PHY_STAT_REM_FLT) {
 		printf ("%s: PHY remote fault detected\n", SMC_DEV_NAME);
-		failed = 1;
 	}
 
 	/* Re-Configure the Receive/Phy Control register */