diff mbox series

[U-Boot,1/2] armv8: dts: ls1088a: add PSCI binding for LS1088A

Message ID 20191018032754.65041-2-matt@traverse.com.au
State Accepted
Commit b50fe3fb7e0e3daf1ad4e1534bd7ba204f5a1699
Delegated to: Priyanka Jain
Headers show
Series armv8: fsl-layerscape: Allow use of PSCI handlers for ls1088a | expand

Commit Message

Mathew McBride Oct. 18, 2019, 3:27 a.m. UTC
This allows the use of PSCI calls to trusted firmware to
initiate reset and poweroff events with CONFIG_PSCI_RESET and
CONFIG_ARM_PSCI_FW. This is desirable, for example, if the target
board has implemented a custom reset or poweroff procedure in EL3.

Signed-off-by: Mathew McBride <matt@traverse.com.au>
Cc: Priyanka Jain <priyanka.jain@nxp.com>
---
 arch/arm/dts/fsl-ls1088a.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Priyanka Jain Oct. 18, 2019, 7:24 a.m. UTC | #1
>-----Original Message-----
>From: Mathew McBride <matt@traverse.com.au>
>Sent: Friday, October 18, 2019 8:58 AM
>To: u-boot@lists.denx.de
>Cc: Priyanka Jain <priyanka.jain@nxp.com>; Mathew McBride
><matt@traverse.com.au>
>Subject: [PATCH 1/2] armv8: dts: ls1088a: add PSCI binding for LS1088A
>
>This allows the use of PSCI calls to trusted firmware to initiate reset and
>poweroff events with CONFIG_PSCI_RESET and CONFIG_ARM_PSCI_FW. This is
>desirable, for example, if the target board has implemented a custom reset or
>poweroff procedure in EL3.
>
>Signed-off-by: Mathew McBride <matt@traverse.com.au>
>Cc: Priyanka Jain <priyanka.jain@nxp.com>
>---
> arch/arm/dts/fsl-ls1088a.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/arch/arm/dts/fsl-ls1088a.dtsi b/arch/arm/dts/fsl-ls1088a.dtsi index
>4be1ab87d2..abc8b21a11 100644
>--- a/arch/arm/dts/fsl-ls1088a.dtsi
>+++ b/arch/arm/dts/fsl-ls1088a.dtsi
>@@ -192,4 +192,9 @@
> 		status = "disabled";
> 	};
>
>+	psci {
>+		compatible = "arm,psci-0.2";
>+		method = "smc";
>+	};
>+
> };
>--
>2.19.1

Mathew, Have you tested this change on any standard NXP ls1088a board?

--priyankajain
Mathew McBride Oct. 18, 2019, 8:45 p.m. UTC | #2
Hell Priyanka,


>-----Original Message-----
>From: Mathew McBride <matt@traverse.com.au>
>Sent: Friday, October 18, 2019 8:58 AM
>To: u-boot@lists.denx.de
>Cc: Priyanka Jain <priyanka.jain@nxp.com>; Mathew McBride 
><matt@traverse.com.au>
>Subject: [PATCH 1/2] armv8: dts: ls1088a: add PSCI binding for LS1088A
>
>2.19.1
[snip]
> Mathew, Have you tested this change on any standard NXP ls1088a board?

> --priyankajain

Not yet - I can test it on an LS1088ARDB if needed.

In theory, this should have no effect on the NXP reference boards as they
are all blacklisted from CONFIG_PSCI_RESET in arch/arm/cpu/armv8/Kconfig.

Regards,
Mathew
Priyanka Jain Oct. 21, 2019, 5:50 a.m. UTC | #3
>-----Original Message-----
>From: Mathew McBride <matt@traverse.com.au>
>Sent: Saturday, October 19, 2019 2:16 AM
>To: Priyanka Jain <priyanka.jain@nxp.com>; u-boot@lists.denx.de; Pramod
>Kumar <pramod.kumar_1@nxp.com>
>Subject: RE: [PATCH 1/2] armv8: dts: ls1088a: add PSCI binding for LS1088A
>
>Hell Priyanka,
>
>
>>-----Original Message-----
>>From: Mathew McBride <matt@traverse.com.au>
>>Sent: Friday, October 18, 2019 8:58 AM
>>To: u-boot@lists.denx.de
>>Cc: Priyanka Jain <priyanka.jain@nxp.com>; Mathew McBride
>><matt@traverse.com.au>
>>Subject: [PATCH 1/2] armv8: dts: ls1088a: add PSCI binding for LS1088A
>>
>>2.19.1
>[snip]
>> Mathew, Have you tested this change on any standard NXP ls1088a board?
>
>> --priyankajain
>
>Not yet - I can test it on an LS1088ARDB if needed.
>
>In theory, this should have no effect on the NXP reference boards as they are
>all blacklisted from CONFIG_PSCI_RESET in arch/arm/cpu/armv8/Kconfig.
>
>Regards,
>Mathew
Thanks for confirming.

--priyankajain
Priyanka Jain Nov. 11, 2019, 8:53 a.m. UTC | #4
>-----Original Message-----
>From: Mathew McBride <matt@traverse.com.au>
>Sent: Friday, October 18, 2019 8:58 AM
>To: u-boot@lists.denx.de
>Cc: Priyanka Jain <priyanka.jain@nxp.com>; Mathew McBride
><matt@traverse.com.au>
>Subject: [PATCH 1/2] armv8: dts: ls1088a: add PSCI binding for LS1088A
>
>This allows the use of PSCI calls to trusted firmware to initiate reset and
>poweroff events with CONFIG_PSCI_RESET and CONFIG_ARM_PSCI_FW. This is
>desirable, for example, if the target board has implemented a custom reset or
>poweroff procedure in EL3.
>
>Signed-off-by: Mathew McBride <matt@traverse.com.au>
>Cc: Priyanka Jain <priyanka.jain@nxp.com>
>---
> arch/arm/dts/fsl-ls1088a.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/arch/arm/dts/fsl-ls1088a.dtsi b/arch/arm/dts/fsl-ls1088a.dtsi index
>4be1ab87d2..abc8b21a11 100644
>--- a/arch/arm/dts/fsl-ls1088a.dtsi
>+++ b/arch/arm/dts/fsl-ls1088a.dtsi
>@@ -192,4 +192,9 @@
> 		status = "disabled";
> 	};
>
>+	psci {
>+		compatible = "arm,psci-0.2";
>+		method = "smc";
>+	};
>+
> };
>--
>2.19.1

Applied to fsl-qoriq master, awaiting upstream.

Thanks
priyankajain
diff mbox series

Patch

diff --git a/arch/arm/dts/fsl-ls1088a.dtsi b/arch/arm/dts/fsl-ls1088a.dtsi
index 4be1ab87d2..abc8b21a11 100644
--- a/arch/arm/dts/fsl-ls1088a.dtsi
+++ b/arch/arm/dts/fsl-ls1088a.dtsi
@@ -192,4 +192,9 @@ 
 		status = "disabled";
 	};
 
+	psci {
+		compatible = "arm,psci-0.2";
+		method = "smc";
+	};
+
 };