| Message ID | 20191017122640.22976-29-yuehaibing@huawei.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | pinctrl: use devm_platform_ioremap_resource() to simplify code | expand |
On Thu, Oct 17, 2019 at 08:26:38PM +0800, YueHaibing wrote: > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Thanks, Mani > --- > drivers/pinctrl/actions/pinctrl-owl.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/pinctrl/actions/pinctrl-owl.c b/drivers/pinctrl/actions/pinctrl-owl.c > index 5dfe718..5a0c8e8 100644 > --- a/drivers/pinctrl/actions/pinctrl-owl.c > +++ b/drivers/pinctrl/actions/pinctrl-owl.c > @@ -915,7 +915,6 @@ static int owl_gpio_init(struct owl_pinctrl *pctrl) > int owl_pinctrl_probe(struct platform_device *pdev, > struct owl_pinctrl_soc_data *soc_data) > { > - struct resource *res; > struct owl_pinctrl *pctrl; > int ret, i; > > @@ -923,8 +922,7 @@ int owl_pinctrl_probe(struct platform_device *pdev, > if (!pctrl) > return -ENOMEM; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - pctrl->base = devm_ioremap_resource(&pdev->dev, res); > + pctrl->base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(pctrl->base)) > return PTR_ERR(pctrl->base); > > -- > 2.7.4 > >
diff --git a/drivers/pinctrl/actions/pinctrl-owl.c b/drivers/pinctrl/actions/pinctrl-owl.c index 5dfe718..5a0c8e8 100644 --- a/drivers/pinctrl/actions/pinctrl-owl.c +++ b/drivers/pinctrl/actions/pinctrl-owl.c @@ -915,7 +915,6 @@ static int owl_gpio_init(struct owl_pinctrl *pctrl) int owl_pinctrl_probe(struct platform_device *pdev, struct owl_pinctrl_soc_data *soc_data) { - struct resource *res; struct owl_pinctrl *pctrl; int ret, i; @@ -923,8 +922,7 @@ int owl_pinctrl_probe(struct platform_device *pdev, if (!pctrl) return -ENOMEM; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - pctrl->base = devm_ioremap_resource(&pdev->dev, res); + pctrl->base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(pctrl->base)) return PTR_ERR(pctrl->base);
Use devm_platform_ioremap_resource() to simplify the code a bit. This is detected by coccinelle. Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/pinctrl/actions/pinctrl-owl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)