| Message ID | 20191016153119.27599-1-pankaj.bansal@nxp.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Priyanka Jain |
| Headers | show |
| Series | [U-Boot] arm: freescale: ls102xa: add helper Macro to get the SVR | expand |
>-----Original Message----- >From: Pankaj Bansal >Sent: Wednesday, October 16, 2019 3:40 PM >To: Priyanka Jain <priyanka.jain@nxp.com>; Albert Aribaud ><albert.u.boot@aribaud.net>; Simon Glass <sjg@chromium.org> >Cc: u-boot@lists.denx.de; Pankaj Bansal <pankaj.bansal@nxp.com> >Subject: [PATCH] arm: freescale: ls102xa: add helper Macro to get the SVR > >32 bit System Version Register (SVR) in NXP SOCs contains information about >SOC such as: >1. SOC type (bits 8 - 31) >2. SOC Major Revision (bits 4 - 7) >3. SOC Minor Revision (bits 0 - 3) > >This Macro (SVR_DEV) strips the Major and Minor revision info, so that SOC >can be correctly identified. >This Macro is borrowed from Macro defined in arch/arm/include/asm/arch- >fsl-layerscape/soc.h > >Additinally this file doesn't contain any valid license. Therefore, add >GPLv2+ license in the file. >same as arch/arm/include/asm/arch-fsl-layerscape/soc.h > >Signed-off-by: Pankaj Bansal <pankaj.bansal@nxp.com> >--- > arch/arm/include/asm/arch-ls102xa/soc.h | 6 ++++++ > 1 file changed, 6 insertions(+) > >diff --git a/arch/arm/include/asm/arch-ls102xa/soc.h >b/arch/arm/include/asm/arch-ls102xa/soc.h >index e69de29bb2..672f126bba 100644 >--- a/arch/arm/include/asm/arch-ls102xa/soc.h >+++ b/arch/arm/include/asm/arch-ls102xa/soc.h >@@ -0,0 +1,6 @@ >+/* SPDX-License-Identifier: GPL-2.0+ */ >+/* >+ * Copyright 2019 NXP >+ */ The file have existed before 2019. Please check git log and update accordingly >+#define SVR_DEV(svr) ((svr) >> 8) Is this something ls102xa specific. Can't we make it generic? >+ >-- >2.17.1 --priyankajain
diff --git a/arch/arm/include/asm/arch-ls102xa/soc.h b/arch/arm/include/asm/arch-ls102xa/soc.h index e69de29bb2..672f126bba 100644 --- a/arch/arm/include/asm/arch-ls102xa/soc.h +++ b/arch/arm/include/asm/arch-ls102xa/soc.h @@ -0,0 +1,6 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* + * Copyright 2019 NXP + */ +#define SVR_DEV(svr) ((svr) >> 8) +
32 bit System Version Register (SVR) in NXP SOCs contains information about SOC such as: 1. SOC type (bits 8 - 31) 2. SOC Major Revision (bits 4 - 7) 3. SOC Minor Revision (bits 0 - 3) This Macro (SVR_DEV) strips the Major and Minor revision info, so that SOC can be correctly identified. This Macro is borrowed from Macro defined in arch/arm/include/asm/arch-fsl-layerscape/soc.h Additinally this file doesn't contain any valid license. Therefore, add GPLv2+ license in the file. same as arch/arm/include/asm/arch-fsl-layerscape/soc.h Signed-off-by: Pankaj Bansal <pankaj.bansal@nxp.com> --- arch/arm/include/asm/arch-ls102xa/soc.h | 6 ++++++ 1 file changed, 6 insertions(+)