[v1] dt-binding: eeprom: at24: add supply properties
diff mbox series

Message ID 20191016075110.8240-2-bibby.hsieh@mediatek.com
State Superseded
Headers show
Series
  • [v1] dt-binding: eeprom: at24: add supply properties
Related show

Commit Message

Bibby Hsieh Oct. 16, 2019, 7:51 a.m. UTC
In some platforms, they disable the power-supply of eeprom
and i2c due to power consumption reduction.

This patch add two supply properties: power-supply, i2c-supply.

Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
---
 Documentation/devicetree/bindings/eeprom/at24.txt | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Bartosz Golaszewski Oct. 16, 2019, 8:40 a.m. UTC | #1
śr., 16 paź 2019 o 09:51 Bibby Hsieh <bibby.hsieh@mediatek.com> napisał(a):
>
> In some platforms, they disable the power-supply of eeprom
> and i2c due to power consumption reduction.
>
> This patch add two supply properties: power-supply, i2c-supply.
>
> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> ---
>  Documentation/devicetree/bindings/eeprom/at24.txt | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.txt b/Documentation/devicetree/bindings/eeprom/at24.txt
> index 22aead844d0f..71a534577bcf 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.txt
> +++ b/Documentation/devicetree/bindings/eeprom/at24.txt
> @@ -78,6 +78,10 @@ Optional properties:
>
>    - num-addresses: total number of i2c slave addresses this device takes
>
> +  - power-supply: phandle of the regulator that provides the supply voltage.

The pin is called vcc in the datasheet, I think it would be better to
reflect that here.

Bart

> +
> +  - i2c-supply: phandle to the regulator that provides power to i2c.
> +
>  Example:
>
>  eeprom@52 {
> --
> 2.18.0
>
Bartosz Golaszewski Oct. 17, 2019, 7:18 a.m. UTC | #2
śr., 16 paź 2019 o 10:40 Bartosz Golaszewski
<bgolaszewski@baylibre.com> napisał(a):
>
> śr., 16 paź 2019 o 09:51 Bibby Hsieh <bibby.hsieh@mediatek.com> napisał(a):
> >
> > In some platforms, they disable the power-supply of eeprom
> > and i2c due to power consumption reduction.
> >
> > This patch add two supply properties: power-supply, i2c-supply.
> >
> > Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> > ---
> >  Documentation/devicetree/bindings/eeprom/at24.txt | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/eeprom/at24.txt b/Documentation/devicetree/bindings/eeprom/at24.txt
> > index 22aead844d0f..71a534577bcf 100644
> > --- a/Documentation/devicetree/bindings/eeprom/at24.txt
> > +++ b/Documentation/devicetree/bindings/eeprom/at24.txt
> > @@ -78,6 +78,10 @@ Optional properties:
> >
> >    - num-addresses: total number of i2c slave addresses this device takes
> >
> > +  - power-supply: phandle of the regulator that provides the supply voltage.
>
> The pin is called vcc in the datasheet, I think it would be better to
> reflect that here.
>
> Bart
>
> > +
> > +  - i2c-supply: phandle to the regulator that provides power to i2c.
> > +
> >  Example:
> >
> >  eeprom@52 {
> > --
> > 2.18.0
> >

Hi Bibby,

I noticed that my patch converting the at24 bindings to yaml is in
next now - please add this change on top of current next right away as
it will conflict during merge window.

Bart

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/eeprom/at24.txt b/Documentation/devicetree/bindings/eeprom/at24.txt
index 22aead844d0f..71a534577bcf 100644
--- a/Documentation/devicetree/bindings/eeprom/at24.txt
+++ b/Documentation/devicetree/bindings/eeprom/at24.txt
@@ -78,6 +78,10 @@  Optional properties:
 
   - num-addresses: total number of i2c slave addresses this device takes
 
+  - power-supply: phandle of the regulator that provides the supply voltage.
+
+  - i2c-supply: phandle to the regulator that provides power to i2c.
+
 Example:
 
 eeprom@52 {