From patchwork Tue Oct 4 23:27:24 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jeremy Stenglein (jstengle)" X-Patchwork-Id: 117713 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id C0D7B1007D1 for ; Wed, 5 Oct 2011 10:27:46 +1100 (EST) Received: (qmail 4918 invoked by alias); 4 Oct 2011 23:27:44 -0000 Received: (qmail 4908 invoked by uid 22791); 4 Oct 2011 23:27:43 -0000 X-SWARE-Spam-Status: No, hits=-10.2 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RP_MATCHES_RCVD, USER_IN_DEF_DKIM_WL X-Spam-Check-By: sourceware.org Received: from rcdn-iport-7.cisco.com (HELO rcdn-iport-7.cisco.com) (173.37.86.78) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 04 Oct 2011 23:27:26 +0000 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApUGAHGVi06tJXHA/2dsb2JhbABCmTqOUYEFgVUBAQMSAR0KUQEqBhgHVwEEEwgaoBmBJgGdaoZCYQSHeJEejDA Received: from rcdn-core2-5.cisco.com ([173.37.113.192]) by rcdn-iport-7.cisco.com with ESMTP; 04 Oct 2011 23:27:25 +0000 Received: from xbh-rcd-301.cisco.com (xbh-rcd-301.cisco.com [72.163.63.8]) by rcdn-core2-5.cisco.com (8.14.3/8.14.3) with ESMTP id p94NRP1n007588 for ; Tue, 4 Oct 2011 23:27:25 GMT Received: from xmb-rcd-104.cisco.com ([72.163.62.146]) by xbh-rcd-301.cisco.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 4 Oct 2011 18:27:25 -0500 Content-class: urn:content-classes:message MIME-Version: 1.0 Subject: Patch: [PR 50562]: configure: add target-libgloss to skipdirs when using --without-newlib Date: Tue, 4 Oct 2011 18:27:24 -0500 Message-ID: <13EBEADFAA5B5041B7FC8A3311E7DD1C0571D3C5@XMB-RCD-104.cisco.com> From: "Jeremy Stenglein (jstengle)" To: X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org As per PR 50562, when --without-newlib is passed to configure, target-newlib is added to skipdirs. But target-newlib is not added to noconfigdirs, so this check: # If we aren't building newlib, then don't build libgloss, since libgloss # depends upon some newlib header files. case "${noconfigdirs}" in *target-libgloss*) ;; *target-newlib*) noconfigdirs="$noconfigdirs target-libgloss" ;; esac Does not disable libgloss like it should when --without-newlib is passed. So the following patch adds target-libgloss to skipdirs when --without-newlib is passed. Testing: Bootstrapped/tested on x86_64-linux and sparc-sun-solaris2.10 with a gcc+newlib+libgloss combined tree. 2011-10-4 Jeremy Stenglein * configure.ac: --without-newlib should add libgloss to skipdirs * configure: Regenerate. Ok for trunk? Thanks, Jeremy Index: configure.ac =================================================================== --- configure.ac (revision 179505) +++ configure.ac (working copy) @@ -276,7 +276,7 @@ fi # Recognize --with-newlib/--without-newlib. case ${with_newlib} in - no) skipdirs="${skipdirs} target-newlib" ;; + no) skipdirs="${skipdirs} target-newlib target-libgloss" ;; yes) skipdirs=`echo " ${skipdirs} " | sed -e 's/ target-newlib / /'` ;; esac