Patchwork Patch: [PR 50562]: configure: add target-libgloss to skipdirs when using --without-newlib

login
register
mail settings
Submitter Jeremy Stenglein (jstengle)
Date Oct. 4, 2011, 11:27 p.m.
Message ID <13EBEADFAA5B5041B7FC8A3311E7DD1C0571D3C5@XMB-RCD-104.cisco.com>
Download mbox | patch
Permalink /patch/117713/
State New
Headers show

Comments

Jeremy Stenglein (jstengle) - Oct. 4, 2011, 11:27 p.m.
As per PR 50562, when --without-newlib is passed to configure,
target-newlib is added to skipdirs.  
But target-newlib is not added to noconfigdirs, so this check:
 
# If we aren't building newlib, then don't build libgloss, since
libgloss
# depends upon some newlib header files.
case "${noconfigdirs}" in
  *target-libgloss*) ;;
  *target-newlib*) noconfigdirs="$noconfigdirs target-libgloss" ;;
 esac

Does not disable libgloss like it should when 
--without-newlib is passed.  So the following 
patch adds target-libgloss to skipdirs when --without-newlib
is passed.

Testing: Bootstrapped/tested on x86_64-linux and sparc-sun-solaris2.10 
with a gcc+newlib+libgloss combined tree.

2011-10-4  Jeremy Stenglein  <jstengle@cisco.com>

       * configure.ac: --without-newlib should add libgloss to skipdirs
       * configure: Regenerate.


Ok for trunk?

Thanks,
Jeremy

Patch

Index: configure.ac
===================================================================
--- configure.ac        (revision 179505)
+++ configure.ac        (working copy)
@@ -276,7 +276,7 @@  fi

 # Recognize --with-newlib/--without-newlib.
 case ${with_newlib} in
-  no) skipdirs="${skipdirs} target-newlib" ;;
+  no) skipdirs="${skipdirs} target-newlib target-libgloss" ;;
   yes) skipdirs=`echo " ${skipdirs} " | sed -e 's/ target-newlib / /'`
;;
 esac