diff mbox series

[libnftnl,2/6] set_elem: Fix return code of nftnl_set_elem_set()

Message ID 20191015141658.11325-3-phil@nwl.cc
State Accepted
Delegated to: Pablo Neira
Headers show
Series A series of covscan-indicated fixes | expand

Commit Message

Phil Sutter Oct. 15, 2019, 2:16 p.m. UTC 
The function returned -1 on success.

Signed-off-by: Phil Sutter <phil@nwl.cc>
---
 src/set_elem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Pablo Neira Ayuso Oct. 15, 2019, 3:51 p.m. UTC | #1 
On Tue, Oct 15, 2019 at 04:16:54PM +0200, Phil Sutter wrote:
> The function returned -1 on success.
> 
> Signed-off-by: Phil Sutter <phil@nwl.cc>

Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
diff mbox series

Patch

diff --git a/src/set_elem.c b/src/set_elem.c
index 47965249691dd..3794f12594079 100644
--- a/src/set_elem.c
+++ b/src/set_elem.c
@@ -149,7 +149,7 @@  int nftnl_set_elem_set(struct nftnl_set_elem *s, uint16_t attr,
 		break;
 	}
 	s->flags |= (1 << attr);
-	return -1;
+	return 0;
 }
 
 EXPORT_SYMBOL(nftnl_set_elem_set_u32);