[OpenWrt-Devel,1/1] build: fix select uClibc
diff mbox series

Message ID 1571136743-95375-1-git-send-email-lxliu@ikuai8.com
State Not Applicable, archived
Headers show
Series
  • [OpenWrt-Devel,1/1] build: fix select uClibc
Related show

Commit Message

daxiong Oct. 15, 2019, 10:52 a.m. UTC
Signed-off-by: daxiong <lxliu@ikuai8.com>
---
 toolchain/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Hauke Mehrtens Oct. 19, 2019, 9:43 a.m. UTC | #1
On 10/15/19 12:52 PM, daxiong wrote:
> Signed-off-by: daxiong <lxliu@ikuai8.com>
> ---
>  toolchain/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/toolchain/Config.in b/toolchain/Config.in
> index 95087b7..0d288aa 100644
> --- a/toolchain/Config.in
> +++ b/toolchain/Config.in
> @@ -252,7 +252,7 @@ choice
>  		select USE_UCLIBC
>  		bool "Use uClibc"
>  		depends on !(aarch64 || aarch64_be || powerpc64)
> -		depends on BROKEN || !(arm || armeb || i386 || x86_64 || mips || mipsel || mips64 || mips64el || powerpc)
> +		depends on BROKEN || (arm || armeb || i386 || x86_64 || mips || mipsel || mips64 || mips64el || powerpc)
>  
>  	config LIBC_USE_MUSL
>  		select USE_MUSL
> 

I think this is intentional. uClibc should only be available on targets
which are not supported by musl libc, which is currently only arc.

Hauke
daxiong Oct. 20, 2019, 10:22 a.m. UTC | #2
Hi hauke,
    uClibc-ng  supported function: getcontext, makecontext, swapcontext,
    There are times when we need to use it to deal with the backtrace.
    I think it should be free to select.



爱生活,快连接
爱快流控路由,商业场景网络专家
刘礼雄  路由研发
官网:www.ikuai8.com
微信:BeiJiXiong008
电话:15110029194
Q Q:1724978665
 
From: Hauke Mehrtens
Date: 2019-10-19 17:43
To: daxiong; openwrt-devel
Subject: Re: [OpenWrt-Devel] [PATCH 1/1] build: fix select uClibc
On 10/15/19 12:52 PM, daxiong wrote:
> Signed-off-by: daxiong <lxliu@ikuai8.com>
> ---
>  toolchain/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/toolchain/Config.in b/toolchain/Config.in
> index 95087b7..0d288aa 100644
> --- a/toolchain/Config.in
> +++ b/toolchain/Config.in
> @@ -252,7 +252,7 @@ choice
>  select USE_UCLIBC
>  bool "Use uClibc"
>  depends on !(aarch64 || aarch64_be || powerpc64)
> - depends on BROKEN || !(arm || armeb || i386 || x86_64 || mips || mipsel || mips64 || mips64el || powerpc)
> + depends on BROKEN || (arm || armeb || i386 || x86_64 || mips || mipsel || mips64 || mips64el || powerpc)
>  
>  config LIBC_USE_MUSL
>  select USE_MUSL
> 
 
I think this is intentional. uClibc should only be available on targets
which are not supported by musl libc, which is currently only arc.
 
Hauke
Rosen Penev Oct. 20, 2019, 6:32 p.m. UTC | #3
On Sun, Oct 20, 2019 at 3:23 AM 大雄 <lxliu@ikuai8.com> wrote:
>
> Hi hauke,
>     uClibc-ng  supported function: getcontext, makecontext, swapcontext,
>     There are times when we need to use it to deal with the backtrace.
>     I think it should be free to select.
You can select if you enable "Show broken packages / platforms" under
Advanced configuration settings.
>
> ________________________________
> 爱生活,快连接
> 爱快流控路由,商业场景网络专家
> 刘礼雄  路由研发
> 官网:www.ikuai8.com
> 微信:BeiJiXiong008
> 电话:15110029194
> Q Q:1724978665
>
>
> From: Hauke Mehrtens
> Date: 2019-10-19 17:43
> To: daxiong; openwrt-devel
> Subject: Re: [OpenWrt-Devel] [PATCH 1/1] build: fix select uClibc
> On 10/15/19 12:52 PM, daxiong wrote:
> > Signed-off-by: daxiong <lxliu@ikuai8.com>
> > ---
> >  toolchain/Config.in | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/toolchain/Config.in b/toolchain/Config.in
> > index 95087b7..0d288aa 100644
> > --- a/toolchain/Config.in
> > +++ b/toolchain/Config.in
> > @@ -252,7 +252,7 @@ choice
> >  select USE_UCLIBC
> >  bool "Use uClibc"
> >  depends on !(aarch64 || aarch64_be || powerpc64)
> > - depends on BROKEN || !(arm || armeb || i386 || x86_64 || mips || mipsel || mips64 || mips64el || powerpc)
> > + depends on BROKEN || (arm || armeb || i386 || x86_64 || mips || mipsel || mips64 || mips64el || powerpc)
> >
> >  config LIBC_USE_MUSL
> >  select USE_MUSL
> >
>
> I think this is intentional. uClibc should only be available on targets
> which are not supported by musl libc, which is currently only arc.
>
> Hauke
>
>
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Patch
diff mbox series

diff --git a/toolchain/Config.in b/toolchain/Config.in
index 95087b7..0d288aa 100644
--- a/toolchain/Config.in
+++ b/toolchain/Config.in
@@ -252,7 +252,7 @@  choice
 		select USE_UCLIBC
 		bool "Use uClibc"
 		depends on !(aarch64 || aarch64_be || powerpc64)
-		depends on BROKEN || !(arm || armeb || i386 || x86_64 || mips || mipsel || mips64 || mips64el || powerpc)
+		depends on BROKEN || (arm || armeb || i386 || x86_64 || mips || mipsel || mips64 || mips64el || powerpc)
 
 	config LIBC_USE_MUSL
 		select USE_MUSL