Patchwork [lucid/fsl-imx51,maverick,maverick/ti-omap4,CVE,1/2] proc: restrict access to /proc/PID/io

login
register
mail settings
Submitter Andy Whitcroft
Date Oct. 4, 2011, 5:52 p.m.
Message ID <1317750762-19278-4-git-send-email-apw@canonical.com>
Download mbox | patch
Permalink /patch/117679/
State New
Headers show

Comments

Andy Whitcroft - Oct. 4, 2011, 5:52 p.m.
From: Vasiliy Kulikov <segoon@openwall.com>

/proc/PID/io may be used for gathering private information.  E.g.  for
openssh and vsftpd daemons wchars/rchars may be used to learn the
precise password length.  Restrict it to processes being able to ptrace
the target process.

ptrace_may_access() is needed to prevent keeping open file descriptor of
"io" file, executing setuid binary and gathering io information of the
setuid'ed process.

Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

(cherry picked from commit 1d1221f375c94ef961ba8574ac4f85c8870ddd51)
CVE-2011-2495
BugLink: http://bugs.launchpad.net/bugs/866025
Signed-off-by: Andy Whitcroft <apw@canonical.com>
---
 fs/proc/base.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

Patch

diff --git a/fs/proc/base.c b/fs/proc/base.c
index e28ac16..f238bf4 100644
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -2541,6 +2541,9 @@  static int do_io_accounting(struct task_struct *task, char *buffer, int whole)
 	struct task_io_accounting acct = task->ioac;
 	unsigned long flags;
 
+	if (!ptrace_may_access(task, PTRACE_MODE_READ))
+		return -EACCES;
+
 	if (whole && lock_task_sighand(task, &flags)) {
 		struct task_struct *t = task;
 
@@ -2667,7 +2670,7 @@  static const struct pid_entry tgid_base_stuff[] = {
 	REG("coredump_filter", S_IRUGO|S_IWUSR, proc_coredump_filter_operations),
 #endif
 #ifdef CONFIG_TASK_IO_ACCOUNTING
-	INF("io",	S_IRUGO, proc_tgid_io_accounting),
+	INF("io",	S_IRUSR, proc_tgid_io_accounting),
 #endif
 };
 
@@ -3003,7 +3006,7 @@  static const struct pid_entry tid_base_stuff[] = {
 	REG("make-it-fail", S_IRUGO|S_IWUSR, proc_fault_inject_operations),
 #endif
 #ifdef CONFIG_TASK_IO_ACCOUNTING
-	INF("io",	S_IRUGO, proc_tid_io_accounting),
+	INF("io",	S_IRUSR, proc_tid_io_accounting),
 #endif
 };