diff mbox series

[v2,1/3] net: phylink: switch to using fwnode_gpiod_get_index()

Message ID 20191014174022.94605-2-dmitry.torokhov@gmail.com
State Not Applicable
Delegated to: David Miller
Headers show
Series net: phy: switch to using fwnode_gpiod_get_index | expand

Commit Message

Dmitry Torokhov Oct. 14, 2019, 5:40 p.m. UTC
Instead of fwnode_get_named_gpiod() that I plan to hide away, let's use
the new fwnode_gpiod_get_index() that mimics gpiod_get_index(), but
works with arbitrary firmware node.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---

 drivers/net/phy/phylink.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Russell King (Oracle) Oct. 14, 2019, 5:55 p.m. UTC | #1
On Mon, Oct 14, 2019 at 10:40:20AM -0700, Dmitry Torokhov wrote:
> Instead of fwnode_get_named_gpiod() that I plan to hide away, let's use
> the new fwnode_gpiod_get_index() that mimics gpiod_get_index(), but
> works with arbitrary firmware node.
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Acked-by: David S. Miller <davem@davemloft.net>

Acked-by: Russell King <rmk+kernel@armlinux.org.uk>

> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> 
>  drivers/net/phy/phylink.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> index a5a57ca94c1a..c34ca644d47e 100644
> --- a/drivers/net/phy/phylink.c
> +++ b/drivers/net/phy/phylink.c
> @@ -168,8 +168,8 @@ static int phylink_parse_fixedlink(struct phylink *pl,
>  			pl->link_config.pause |= MLO_PAUSE_ASYM;
>  
>  		if (ret == 0) {
> -			desc = fwnode_get_named_gpiod(fixed_node, "link-gpios",
> -						      0, GPIOD_IN, "?");
> +			desc = fwnode_gpiod_get_index(fixed_node, "link", 0,
> +						      GPIOD_IN, "?");
>  
>  			if (!IS_ERR(desc))
>  				pl->link_gpio = desc;
> -- 
> 2.23.0.700.g56cf767bdb-goog
> 
>
diff mbox series

Patch

diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index a5a57ca94c1a..c34ca644d47e 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -168,8 +168,8 @@  static int phylink_parse_fixedlink(struct phylink *pl,
 			pl->link_config.pause |= MLO_PAUSE_ASYM;
 
 		if (ret == 0) {
-			desc = fwnode_get_named_gpiod(fixed_node, "link-gpios",
-						      0, GPIOD_IN, "?");
+			desc = fwnode_gpiod_get_index(fixed_node, "link", 0,
+						      GPIOD_IN, "?");
 
 			if (!IS_ERR(desc))
 				pl->link_gpio = desc;