| Message ID | 20191014090910.9701-2-jgross@suse.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | xen/netback: bug fix and cleanup | expand |
On Mon, 14 Oct 2019 at 10:09, Juergen Gross <jgross@suse.com> wrote: > > xenvif_connect_data() calls module_put() in case of error. This is > wrong as there is no related module_get(). > > Remove the superfluous module_put(). > > Fixes: 279f438e36c0a7 ("xen-netback: Don't destroy the netdev until the vif is shut down") > Cc: <stable@vger.kernel.org> # 3.12 > Signed-off-by: Juergen Gross <jgross@suse.com> Yes, looks like this should have been cleaned up a long time ago. Reviewed-by: Paul Durrant <paul@xen.org> > --- > drivers/net/xen-netback/interface.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c > index 240f762b3749..103ed00775eb 100644 > --- a/drivers/net/xen-netback/interface.c > +++ b/drivers/net/xen-netback/interface.c > @@ -719,7 +719,6 @@ int xenvif_connect_data(struct xenvif_queue *queue, > xenvif_unmap_frontend_data_rings(queue); > netif_napi_del(&queue->napi); > err: > - module_put(THIS_MODULE); > return err; > } > > -- > 2.16.4 >
diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c index 240f762b3749..103ed00775eb 100644 --- a/drivers/net/xen-netback/interface.c +++ b/drivers/net/xen-netback/interface.c @@ -719,7 +719,6 @@ int xenvif_connect_data(struct xenvif_queue *queue, xenvif_unmap_frontend_data_rings(queue); netif_napi_del(&queue->napi); err: - module_put(THIS_MODULE); return err; }
xenvif_connect_data() calls module_put() in case of error. This is wrong as there is no related module_get(). Remove the superfluous module_put(). Fixes: 279f438e36c0a7 ("xen-netback: Don't destroy the netdev until the vif is shut down") Cc: <stable@vger.kernel.org> # 3.12 Signed-off-by: Juergen Gross <jgross@suse.com> --- drivers/net/xen-netback/interface.c | 1 - 1 file changed, 1 deletion(-)