[1/1] package/libva: switch to virtual opengl provider
diff mbox series

Message ID 20191012153931.24484-1-bernd.kuhls@t-online.de
State Accepted
Headers show
Series
  • [1/1] package/libva: switch to virtual opengl provider
Related show

Commit Message

Bernd Kuhls Oct. 12, 2019, 3:39 p.m. UTC
This allows to use libva without mesa3d.

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/libva/libva.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Thomas Petazzoni Oct. 12, 2019, 7:45 p.m. UTC | #1
On Sat, 12 Oct 2019 17:39:31 +0200
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:

> diff --git a/package/libva/libva.mk b/package/libva/libva.mk
> index 6c8243da90..176f971128 100644
> --- a/package/libva/libva.mk
> +++ b/package/libva/libva.mk
> @@ -20,8 +20,8 @@ LIBVA_CONF_OPTS = \
>  ifeq ($(BR2_PACKAGE_XORG7),y)
>  LIBVA_DEPENDENCIES += xlib_libX11 xlib_libXext xlib_libXfixes
>  LIBVA_CONF_OPTS += --enable-x11
> -ifeq ($(BR2_PACKAGE_MESA3D_OPENGL_GLX),y)
> -LIBVA_DEPENDENCIES += mesa3d
> +ifeq ($(BR2_PACKAGE_HAS_LIBGL),y)
> +LIBVA_DEPENDENCIES += libgl
>  LIBVA_CONF_OPTS += --enable-glx

Do all OpenGL implementation provide GLX support ? I would assume that
in most practical cases, yes, but I'm wondering.

Thomas
Bernd Kuhls Oct. 19, 2019, 7:59 a.m. UTC | #2
Am Sat, 12 Oct 2019 21:45:04 +0200 schrieb Thomas Petazzoni:

> Do all OpenGL implementation provide GLX support ? I would assume that
> in most practical cases, yes, but I'm wondering.

Hi Thomas,

three packages contain "select BR2_PACKAGE_HAS_LIBGL":

- amd-catalyst
- mesa3d
- nvidia-driver

Building libva with glx support was successful with these defconfigs:

BR2_TOOLCHAIN_BUILDROOT_GLIBC=y
BR2_TOOLCHAIN_BUILDROOT_CXX=y
BR2_PACKAGE_XORG7=y
BR2_PACKAGE_XSERVER_XORG_SERVER=y
BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_17=y
BR2_PACKAGE_AMD_CATALYST=y
BR2_PACKAGE_LIBVA=y

BR2_TOOLCHAIN_BUILDROOT_GLIBC=y
BR2_TOOLCHAIN_BUILDROOT_CXX=y
BR2_PACKAGE_XORG7=y
BR2_PACKAGE_XSERVER_XORG_SERVER=y
BR2_PACKAGE_NVIDIA_DRIVER=y
BR2_PACKAGE_LIBVA=y

Regards, Bernd
Thomas Petazzoni Oct. 22, 2019, 8:59 p.m. UTC | #3
On Sat, 12 Oct 2019 17:39:31 +0200
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:

> This allows to use libva without mesa3d.
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/libva/libva.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas

Patch
diff mbox series

diff --git a/package/libva/libva.mk b/package/libva/libva.mk
index 6c8243da90..176f971128 100644
--- a/package/libva/libva.mk
+++ b/package/libva/libva.mk
@@ -20,8 +20,8 @@  LIBVA_CONF_OPTS = \
 ifeq ($(BR2_PACKAGE_XORG7),y)
 LIBVA_DEPENDENCIES += xlib_libX11 xlib_libXext xlib_libXfixes
 LIBVA_CONF_OPTS += --enable-x11
-ifeq ($(BR2_PACKAGE_MESA3D_OPENGL_GLX),y)
-LIBVA_DEPENDENCIES += mesa3d
+ifeq ($(BR2_PACKAGE_HAS_LIBGL),y)
+LIBVA_DEPENDENCIES += libgl
 LIBVA_CONF_OPTS += --enable-glx
 endif
 else