| Message ID | 610f9277-adff-2f4b-1f44-8f41b6c3ccb5@infradead.org |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: ethernet: broadcom: have drivers select DIMLIB as needed | expand |
On 10/11/2019 9:03 PM, Randy Dunlap wrote: > From: Randy Dunlap <rdunlap@infradead.org> > > NET_VENDOR_BROADCOM is intended to control a kconfig menu only. > It should not have anything to do with code generation. > As such, it should not select DIMLIB for all drivers under > NET_VENDOR_BROADCOM. Instead each driver that needs DIMLIB should > select it (being the symbols SYSTEMPORT, BNXT, and BCMGENET). > > Link: https://lkml.kernel.org/r/alpine.DEB.2.21.1907021810220.13058@ramsan.of.borg/ > > Fixes: 4f75da3666c0 ("linux/dim: Move implementation to .c files") > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
On Fri, Oct 11, 2019 at 09:03:33PM -0700, Randy Dunlap wrote: > From: Randy Dunlap <rdunlap@infradead.org> > > NET_VENDOR_BROADCOM is intended to control a kconfig menu only. > It should not have anything to do with code generation. > As such, it should not select DIMLIB for all drivers under > NET_VENDOR_BROADCOM. Instead each driver that needs DIMLIB should > select it (being the symbols SYSTEMPORT, BNXT, and BCMGENET). > > Link: https://lkml.kernel.org/r/alpine.DEB.2.21.1907021810220.13058@ramsan.of.borg/ > > Fixes: 4f75da3666c0 ("linux/dim: Move implementation to .c files") > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Uwe Kleine-König <uwe@kleine-koenig.org> > Cc: Tal Gilboa <talgi@mellanox.com> > Cc: Saeed Mahameed <saeedm@mellanox.com> > Cc: netdev@vger.kernel.org > Cc: linux-rdma@vger.kernel.org > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Jakub Kicinski <jakub.kicinski@netronome.com> > Cc: Doug Ledford <dledford@redhat.com> > Cc: Jason Gunthorpe <jgg@mellanox.com> > Cc: Leon Romanovsky <leonro@mellanox.com> > Cc: Or Gerlitz <ogerlitz@mellanox.com> > Cc: Sagi Grimberg <sagi@grimberg.me> > --- > drivers/net/ethernet/broadcom/Kconfig | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Thanks, Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
From: Randy Dunlap <rdunlap@infradead.org> Date: Fri, 11 Oct 2019 21:03:33 -0700 > From: Randy Dunlap <rdunlap@infradead.org> > > NET_VENDOR_BROADCOM is intended to control a kconfig menu only. > It should not have anything to do with code generation. > As such, it should not select DIMLIB for all drivers under > NET_VENDOR_BROADCOM. Instead each driver that needs DIMLIB should > select it (being the symbols SYSTEMPORT, BNXT, and BCMGENET). > > Link: https://lkml.kernel.org/r/alpine.DEB.2.21.1907021810220.13058@ramsan.of.borg/ > > Fixes: 4f75da3666c0 ("linux/dim: Move implementation to .c files") > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Applied and queued up for -stable, thanks.
--- linux-next-20191011.orig/drivers/net/ethernet/broadcom/Kconfig +++ linux-next-20191011/drivers/net/ethernet/broadcom/Kconfig @@ -8,7 +8,6 @@ config NET_VENDOR_BROADCOM default y depends on (SSB_POSSIBLE && HAS_DMA) || PCI || BCM63XX || \ SIBYTE_SB1xxx_SOC - select DIMLIB ---help--- If you have a network (Ethernet) chipset belonging to this class, say Y. @@ -69,6 +68,7 @@ config BCMGENET select FIXED_PHY select BCM7XXX_PHY select MDIO_BCM_UNIMAC + select DIMLIB help This driver supports the built-in Ethernet MACs found in the Broadcom BCM7xxx Set Top Box family chipset. @@ -188,6 +188,7 @@ config SYSTEMPORT select MII select PHYLIB select FIXED_PHY + select DIMLIB help This driver supports the built-in Ethernet MACs found in the Broadcom BCM7xxx Set Top Box family chipset using an internal @@ -200,6 +201,7 @@ config BNXT select LIBCRC32C select NET_DEVLINK select PAGE_POOL + select DIMLIB ---help--- This driver supports Broadcom NetXtreme-C/E 10/25/40/50 gigabit Ethernet cards. To compile this driver as a module, choose M here: