[v1,1/3] dt-bindings: net: bcmgenet add property for max DMA burst size
diff mbox series

Message ID 20191011184822.866-2-matthias.bgg@kernel.org
State Changes Requested
Headers show
Series
  • This series adds ethernet support for RPi4.
Related show

Checks

Context Check Description
robh/checkpatch success

Commit Message

Matthias Brugger Oct. 11, 2019, 6:48 p.m. UTC
From: Matthias Brugger <mbrugger@suse.com>

The maximal usable DMA burst size can vary in different SoCs.
Add a optional property to configure the DMA channels properly.

Signed-off-by: Matthias Brugger <mbrugger@suse.com>
---

 Documentation/devicetree/bindings/net/brcm,bcmgenet.txt | 2 ++
 1 file changed, 2 insertions(+)

Comments

Florian Fainelli Oct. 11, 2019, 7:07 p.m. UTC | #1
On 10/11/19 11:48 AM, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
> 
> The maximal usable DMA burst size can vary in different SoCs.
> Add a optional property to configure the DMA channels properly.
> 
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>

There are enough differences in the integration of GENET in 2711 (versus
any other STB chip where it has been used) that a brcm,bcm2711-genet-v5
compatible string would be in order. From there, you can derive the DMA
burst size without using additional properties.

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/net/brcm,bcmgenet.txt b/Documentation/devicetree/bindings/net/brcm,bcmgenet.txt
index 3956af1d30f3..10a7169ec902 100644
--- a/Documentation/devicetree/bindings/net/brcm,bcmgenet.txt
+++ b/Documentation/devicetree/bindings/net/brcm,bcmgenet.txt
@@ -30,6 +30,8 @@  Optional properties:
   See Documentation/devicetree/bindings/net/fixed-link.txt for information on
   the property specifics
 
+- dma-burst-sz: Maximal length of a burst.
+
 Required child nodes:
 
 - mdio bus node: this node should always be present regardless of the PHY