Message ID | 20111004041509.191082289@vyatta.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: Stephen Hemminger <shemminger@vyatta.com> Date: Mon, 03 Oct 2011 21:14:45 -0700 > This resolves a regression seen by some users of bridging. > Some users use the bridge like a dummy device. > They expect to be able to put an IPv6 address on the device > with no ports attached. Although there are better ways of doing > this, there is no reason to not allow it. > > Note: the bridge still will reflect the state of ports in the > bridge if there are any added. > > Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> Applied to 'net' and queued up for -stable. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- a/net/bridge/br_device.c 2011-09-01 08:52:27.596631192 -0700 +++ b/net/bridge/br_device.c 2011-09-01 09:01:03.256611801 -0700 @@ -91,7 +91,6 @@ static int br_dev_open(struct net_device { struct net_bridge *br = netdev_priv(dev); - netif_carrier_off(dev); netdev_update_features(dev); netif_start_queue(dev); br_stp_enable_bridge(br); @@ -108,8 +107,6 @@ static int br_dev_stop(struct net_device { struct net_bridge *br = netdev_priv(dev); - netif_carrier_off(dev); - br_stp_disable_bridge(br); br_multicast_stop(br);
This resolves a regression seen by some users of bridging. Some users use the bridge like a dummy device. They expect to be able to put an IPv6 address on the device with no ports attached. Although there are better ways of doing this, there is no reason to not allow it. Note: the bridge still will reflect the state of ports in the bridge if there are any added. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> --- This fix needs to go to stable as well since it has been reported as a regression. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html