resolv/tst-idna_name_classify: Isolate from system libraries
diff mbox series

Message ID 87sgnzjxiq.fsf@oldenburg2.str.redhat.com
State New
Headers show
Series
  • resolv/tst-idna_name_classify: Isolate from system libraries
Related show

Commit Message

Florian Weimer Oct. 11, 2019, 12:07 p.m. UTC
Loading NSS modules from static binaries uses installed system
libraries if LD_LIBRARY_PATH is not set.

2019-10-11  Florian Weimer  <fweimer@redhat.com>

	* inet/Makefile (tst-idna_name_classify-ENV): Set LD_LIBRARY_PATH.

Comments

Florian Weimer Oct. 30, 2019, 4:44 p.m. UTC | #1
* Florian Weimer:

> Loading NSS modules from static binaries uses installed system
> libraries if LD_LIBRARY_PATH is not set.
>
> 2019-10-11  Florian Weimer  <fweimer@redhat.com>
>
> 	* inet/Makefile (tst-idna_name_classify-ENV): Set LD_LIBRARY_PATH.
>
> diff --git a/inet/Makefile b/inet/Makefile
> index 1fda64abe7..33912340a2 100644
> --- a/inet/Makefile
> +++ b/inet/Makefile
> @@ -112,4 +112,8 @@ ifeq ($(build-static-nss),yes)
>  CFLAGS += -DSTATIC_NSS
>  endif
>  
> +# The test uses dlopen indirectly and would otherwise load system
> +# objects.
> +tst-idna_name_classify-ENV = \
> +  LD_LIBRARY_PATH=$(objpfx):$(common-objpfx):$(common-objpfx)elf
>  $(objpfx)tst-idna_name_classify.out: $(gen-locales)

I have pushed this (without the ChangeLog update).

Thanks,
Florian

Patch
diff mbox series

diff --git a/inet/Makefile b/inet/Makefile
index 1fda64abe7..33912340a2 100644
--- a/inet/Makefile
+++ b/inet/Makefile
@@ -112,4 +112,8 @@  ifeq ($(build-static-nss),yes)
 CFLAGS += -DSTATIC_NSS
 endif
 
+# The test uses dlopen indirectly and would otherwise load system
+# objects.
+tst-idna_name_classify-ENV = \
+  LD_LIBRARY_PATH=$(objpfx):$(common-objpfx):$(common-objpfx)elf
 $(objpfx)tst-idna_name_classify.out: $(gen-locales)