[net-next,v2] net: usb: ax88179_178a: write mac to hardware in get_mac_addr
diff mbox series

Message ID 1570712422-32397-1-git-send-email-pedro@pixelbox.red
State Accepted
Delegated to: David Miller
Headers show
Series
  • [net-next,v2] net: usb: ax88179_178a: write mac to hardware in get_mac_addr
Related show

Commit Message

Peter Fink Oct. 10, 2019, 1 p.m. UTC
From: Peter Fink <pfink@christ-es.de>

When the MAC address is supplied via device tree or a random
MAC is generated it has to be written to the asix chip in
order to receive any data.

Previously in 9fb137aef34e ("net: usb: ax88179_178a: allow
optionally getting mac address from device tree") this line was
omitted because it seemed to work perfectly fine without it.

But it was simply not detected because the chip keeps the mac
stored even beyond a reset and it was tested on a hardware
with an integrated UPS where the asix chip was permanently
powered on even throughout power cycles.

Fixes: 9fb137aef34e ("net: usb: ax88179_178a: allow optionally getting mac address from device tree")
Signed-off-by: Peter Fink <pfink@christ-es.de>
---
v1->v2: fix citation style and add 'fixes' tag

 drivers/net/usb/ax88179_178a.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

David Miller Oct. 12, 2019, 3:51 a.m. UTC | #1
From: Peter Fink <pedro@pixelbox.red>
Date: Thu, 10 Oct 2019 15:00:22 +0200

> From: Peter Fink <pfink@christ-es.de>
> 
> When the MAC address is supplied via device tree or a random
> MAC is generated it has to be written to the asix chip in
> order to receive any data.
> 
> Previously in 9fb137aef34e ("net: usb: ax88179_178a: allow
> optionally getting mac address from device tree") this line was
> omitted because it seemed to work perfectly fine without it.
> 
> But it was simply not detected because the chip keeps the mac
> stored even beyond a reset and it was tested on a hardware
> with an integrated UPS where the asix chip was permanently
> powered on even throughout power cycles.
> 
> Fixes: 9fb137aef34e ("net: usb: ax88179_178a: allow optionally getting mac address from device tree")
> Signed-off-by: Peter Fink <pfink@christ-es.de>

Applied, thank you.

Patch
diff mbox series

diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
index 5a58766..c5a6e75 100644
--- a/drivers/net/usb/ax88179_178a.c
+++ b/drivers/net/usb/ax88179_178a.c
@@ -1235,6 +1235,9 @@  static void ax88179_get_mac_addr(struct usbnet *dev)
 		netdev_info(dev->net, "invalid MAC address, using random\n");
 		eth_hw_addr_random(dev->net);
 	}
+
+	ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_NODE_ID, ETH_ALEN, ETH_ALEN,
+			  dev->net->dev_addr);
 }
 
 static int ax88179_bind(struct usbnet *dev, struct usb_interface *intf)