[28/29] can: j1939: fix memory leak if filters was set
diff mbox series

Message ID 20191010121750.27237-29-mkl@pengutronix.de
State RFC
Delegated to: David Miller
Headers show
  • [01/29] can: dev: add missing of_node_put() after calling of_get_child_by_name()
Related show

Commit Message

Marc Kleine-Budde Oct. 10, 2019, 12:17 p.m. UTC
From: Oleksij Rempel <o.rempel@pengutronix.de>

Filters array is coped from user space and linked to the j1939 socket.
On socket release this memory was not freed.

Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol")
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
 net/can/j1939/socket.c | 1 +
 1 file changed, 1 insertion(+)

diff mbox series

diff --git a/net/can/j1939/socket.c b/net/can/j1939/socket.c
index 5c6eabcb5df1..4d8ba701e15d 100644
--- a/net/can/j1939/socket.c
+++ b/net/can/j1939/socket.c
@@ -580,6 +580,7 @@  static int j1939_sk_release(struct socket *sock)
+	kfree(jsk->filters);
 	sock->sk = NULL;