diff mbox series

[02/29] can: gs_usb: gs_can_open(): prevent memory leak

Message ID	20191010121750.27237-3-mkl@pengutronix.de
State	RFC
Delegated to:	David Miller
Headers	show Return-Path: <netdev-owner@vger.kernel.org> From: Marc Kleine-Budde <mkl@pengutronix.de> To: netdev@vger.kernel.org, linux-can <linux-can@vger.kernel.org> Cc: davem@davemloft.net, kernel@pengutronix.de, jhofstee@victronenergy.com, =?utf-8?q?Martin_Hundeb=C3=B8ll?= <martin@geanix.com>, Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>, Navid Emamdoost <navid.emamdoost@gmail.com>, linux-stable <stable@vger.kernel.org>, Marc Kleine-Budde <mkl@pengutronix.de> Subject: [PATCH 02/29] can: gs_usb: gs_can_open(): prevent memory leak Date: Thu, 10 Oct 2019 14:17:23 +0200 Message-Id: <20191010121750.27237-3-mkl@pengutronix.de> In-Reply-To: <20191010121750.27237-1-mkl@pengutronix.de> References: <20191010121750.27237-1-mkl@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk
Series	[01/29] can: dev: add missing of_node_put() after calling of_get_child_by_name() \| expand [01/29] can: dev: add missing of_node_put() after calling of_get_child_by_name() [02/29] can: gs_usb: gs_can_open(): prevent memory leak [03/29] can: mcba_usb: fix use-after-free on disconnect [04/29] can: usb_8dev: fix use-after-free on disconnect [05/29] can: flexcan: disable completely the ECC mechanism [06/29] can: peak_usb: fix a potential out-of-sync while decoding packets [07/29] can: peak_usb: report bus recovery as well [08/29] can: c_can: c_can_poll(): only read status register after status IRQ [09/29] can: c_can: D_CAN: c_can_chip_config(): perform a sofware reset on open [10/29] can: c_can: C_CAN: add bus recovery events [11/29] can: xilinx_can: Fix flags field initialization for axi can [12/29] can: rx-offload: can_rx_offload_queue_sorted(): fix error handling, avoid skb mem leak [13/29] can: rx-offload: can_rx_offload_queue_tail(): fix error handling, avoid skb mem leak [14/29] can: rx-offload: can_rx_offload_offload_one(): do not increase the skb_queue beyond skb_que… [15/29] can: rx-offload: can_rx_offload_offload_one(): increment rx_fifo_errors on queue overflow o… [16/29] can: rx-offload: can_rx_offload_offload_one(): use ERR_PTR() to propagate error value in ca… [17/29] can: rx-offload: can_rx_offload_irq_offload_timestamp(): continue on error [18/29] can: rx-offload: can_rx_offload_irq_offload_fifo(): continue on error [19/29] can: flexcan: increase error counters if skb enqueueing via can_rx_offload_queue_sorted() f… [20/29] can: ti_hecc: ti_hecc_error(): increase error counters if skb enqueueing via can_rx_offload… [21/29] can: ti_hecc: ti_hecc_stop(): stop the CPK on down [22/29] can: ti_hecc: keep MIM and MD set [23/29] can: ti_hecc: release the mailbox a bit earlier [24/29] can: ti_hecc: add fifo underflow error reporting [25/29] can: ti_hecc: properly report state changes [26/29] can: ti_hecc: add missing state changes [27/29] can: j1939: fix resource leak of skb on error return paths [28/29] can: j1939: fix memory leak if filters was set [29/29] can: don't use deprecated license identifiers

Commit Message

Marc Kleine-Budde Oct. 10, 2019, 12:17 p.m. UTC

From: Navid Emamdoost <navid.emamdoost@gmail.com>

In gs_can_open() if usb_submit_urb() fails the allocated urb should be
released.

Fixes: d08e973a77d1 ("can: gs_usb: Added support for the GS_USB CAN devices")
Cc: linux-stable <stable@vger.kernel.org>
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
 drivers/net/can/usb/gs_usb.c | 1 +
 1 file changed, 1 insertion(+)

diff mbox series

Patch

diff --git a/drivers/net/can/usb/gs_usb.c b/drivers/net/can/usb/gs_usb.c
index bd6eb9967630..2f74f6704c12 100644
--- a/drivers/net/can/usb/gs_usb.c
+++ b/drivers/net/can/usb/gs_usb.c
@@ -623,6 +623,7 @@  static int gs_can_open(struct net_device *netdev)
 					   rc);
 
 				usb_unanchor_urb(urb);
+				usb_free_urb(urb);
 				break;
 			}