| Message ID | 5ca0ded44e4fe958c537d300a158045d81bbb076.1570699990.git.michal.simek@xilinx.com |
|---|---|
| State | Accepted |
| Commit | 44dccd592485e18f63bbbe5dc92cffb168fd9038 |
| Delegated to: | Michal Simek |
| Headers | show |
| Series | [U-Boot] firmware: zynqmp: Clean up zynqmp_power_probe | expand |
Hi, On 10/10/19 11:33, Michal Simek wrote: > Fix error debug messages to be more accurate and aligned with debug message > style in the whole file. > And do not initialize ret variable because it is initialized later on and > it is just additional step. > > Fixes: 1327d1678bd2 ("firmware: zynqmp: Add zynqmp-power support") > Reported-by: Luca Ceresoli <luca@lucaceresoli.net> > Signed-off-by: Michal Simek <michal.simek@xilinx.com> Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net>
čt 10. 10. 2019 v 11:33 odesílatel Michal Simek <michal.simek@xilinx.com> napsal: > > Fix error debug messages to be more accurate and aligned with debug message > style in the whole file. > And do not initialize ret variable because it is initialized later on and > it is just additional step. > > Fixes: 1327d1678bd2 ("firmware: zynqmp: Add zynqmp-power support") > Reported-by: Luca Ceresoli <luca@lucaceresoli.net> > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > drivers/firmware/firmware-zynqmp.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/firmware/firmware-zynqmp.c b/drivers/firmware/firmware-zynqmp.c > index 4911734f6c63..dea58b558102 100644 > --- a/drivers/firmware/firmware-zynqmp.c > +++ b/drivers/firmware/firmware-zynqmp.c > @@ -110,19 +110,19 @@ void zynqmp_pmufw_load_config_object(const void *cfg_obj, size_t size) > > static int zynqmp_power_probe(struct udevice *dev) > { > - int ret = 0; > + int ret; > > debug("%s, (dev=%p)\n", __func__, dev); > > ret = mbox_get_by_name(dev, "tx", &zynqmp_power.tx_chan); > if (ret) { > - debug("%s, cannot tx mailbox\n", __func__); > + debug("%s: Cannot find tx mailbox\n", __func__); > return ret; > } > > ret = mbox_get_by_name(dev, "rx", &zynqmp_power.rx_chan); > if (ret) { > - debug("%s, cannot rx mailbox\n", __func__); > + debug("%s: Cannot find rx mailbox\n", __func__); > return ret; > } > > -- > 2.17.1 > Applied. M
diff --git a/drivers/firmware/firmware-zynqmp.c b/drivers/firmware/firmware-zynqmp.c index 4911734f6c63..dea58b558102 100644 --- a/drivers/firmware/firmware-zynqmp.c +++ b/drivers/firmware/firmware-zynqmp.c @@ -110,19 +110,19 @@ void zynqmp_pmufw_load_config_object(const void *cfg_obj, size_t size) static int zynqmp_power_probe(struct udevice *dev) { - int ret = 0; + int ret; debug("%s, (dev=%p)\n", __func__, dev); ret = mbox_get_by_name(dev, "tx", &zynqmp_power.tx_chan); if (ret) { - debug("%s, cannot tx mailbox\n", __func__); + debug("%s: Cannot find tx mailbox\n", __func__); return ret; } ret = mbox_get_by_name(dev, "rx", &zynqmp_power.rx_chan); if (ret) { - debug("%s, cannot rx mailbox\n", __func__); + debug("%s: Cannot find rx mailbox\n", __func__); return ret; }
Fix error debug messages to be more accurate and aligned with debug message style in the whole file. And do not initialize ret variable because it is initialized later on and it is just additional step. Fixes: 1327d1678bd2 ("firmware: zynqmp: Add zynqmp-power support") Reported-by: Luca Ceresoli <luca@lucaceresoli.net> Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- drivers/firmware/firmware-zynqmp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)