[U-Boot,v2,3/6] arm: dts: k3-j721e-mcu-wakeup: Add HyperBus Controller node
diff mbox series

Message ID 20191010055207.26831-4-vigneshr@ti.com
State Superseded
Delegated to: Stefan Roese
Headers show
Series
  • J721e: Add HyperBus support
Related show

Commit Message

Vignesh Raghavendra Oct. 10, 2019, 5:52 a.m. UTC
Add DT node for HyperBus Memory Controller in the FSS. On J721e, its not
possible to use OSPI0 and HBMC simultaneously as they are muxed within
the Flash Subsystem hence disable HBMC by default as keep OSPI enabled.
Bootloader will fixup DT when it detects HyperFlash instead of OSPI.

Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
---
 arch/arm/dts/k3-j721e-mcu-wakeup.dtsi | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

Comments

Stefan Roese Oct. 23, 2019, 2:36 a.m. UTC | #1
Hi Vignesh,

On 10.10.19 07:52, Vignesh Raghavendra wrote:
> Add DT node for HyperBus Memory Controller in the FSS. On J721e, its not
> possible to use OSPI0 and HBMC simultaneously as they are muxed within
> the Flash Subsystem hence disable HBMC by default as keep OSPI enabled.
> Bootloader will fixup DT when it detects HyperFlash instead of OSPI.
> 
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> ---
>   arch/arm/dts/k3-j721e-mcu-wakeup.dtsi | 26 ++++++++++++++++++++++++++
>   1 file changed, 26 insertions(+)
> 
> diff --git a/arch/arm/dts/k3-j721e-mcu-wakeup.dtsi b/arch/arm/dts/k3-j721e-mcu-wakeup.dtsi
> index c217866e9a2b..8838771dc1a1 100644
> --- a/arch/arm/dts/k3-j721e-mcu-wakeup.dtsi
> +++ b/arch/arm/dts/k3-j721e-mcu-wakeup.dtsi
> @@ -80,4 +80,30 @@
>   		clocks = <&k3_clks 149 0>;
>   		clock-names = "fclk";
>   	};
> +
> +	fss: fss@47000000 {
> +		compatible = "syscon", "simple-mfd";
> +		reg = <0x0 0x47000000 0x0 0x100>;
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +
> +		hbmc_mux: hbmc-mux {
> +			compatible = "mmio-mux";
> +			#mux-control-cells = <1>;
> +			mux-reg-masks = <0x4 0x2>; /* HBMC select */
> +		};
> +
> +		hbmc: hyperbus@47034000 {
> +			compatible = "ti,j721e-hbmc", "ti,am654-hbmc";
> +			reg = <0x0 0x47034000 0x0 0x100>,
> +				<0x5 0x00000000 0x1 0x0000000>;
> +			power-domains = <&k3_pds 102 TI_SCI_PD_EXCLUSIVE>;
> +			#address-cells = <2>;
> +			#size-cells = <1>;
> +			mux-controls = <&hbmc_mux 0>;
> +			assigned-clocks = <&k3_clks 102 0>;
> +			assigned-clock-rates = <166666666>;
> +		};
> +	};
>   };
> 

This patch does not apply any more. Could you please rebase and
resubmit?

Thanks,
Stefan
Vignesh Raghavendra Oct. 23, 2019, 8:02 a.m. UTC | #2
Hi Stefan,

On 23/10/19 8:06 AM, Stefan Roese wrote:
> Hi Vignesh,
> 
> On 10.10.19 07:52, Vignesh Raghavendra wrote:
[...]
>> +
>> +        hbmc: hyperbus@47034000 {
>> +            compatible = "ti,j721e-hbmc", "ti,am654-hbmc";
>> +            reg = <0x0 0x47034000 0x0 0x100>,
>> +                <0x5 0x00000000 0x1 0x0000000>;
>> +            power-domains = <&k3_pds 102 TI_SCI_PD_EXCLUSIVE>;
>> +            #address-cells = <2>;
>> +            #size-cells = <1>;
>> +            mux-controls = <&hbmc_mux 0>;
>> +            assigned-clocks = <&k3_clks 102 0>;
>> +            assigned-clock-rates = <166666666>;
>> +        };
>> +    };
>>   };
>>
> 
> This patch does not apply any more. Could you please rebase and
> resubmit?
> 

I have rebased the patches and posted v3 here:
http://patchwork.ozlabs.org/project/uboot/list/?series=137974

Patch
diff mbox series

diff --git a/arch/arm/dts/k3-j721e-mcu-wakeup.dtsi b/arch/arm/dts/k3-j721e-mcu-wakeup.dtsi
index c217866e9a2b..8838771dc1a1 100644
--- a/arch/arm/dts/k3-j721e-mcu-wakeup.dtsi
+++ b/arch/arm/dts/k3-j721e-mcu-wakeup.dtsi
@@ -80,4 +80,30 @@ 
 		clocks = <&k3_clks 149 0>;
 		clock-names = "fclk";
 	};
+
+	fss: fss@47000000 {
+		compatible = "syscon", "simple-mfd";
+		reg = <0x0 0x47000000 0x0 0x100>;
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+
+		hbmc_mux: hbmc-mux {
+			compatible = "mmio-mux";
+			#mux-control-cells = <1>;
+			mux-reg-masks = <0x4 0x2>; /* HBMC select */
+		};
+
+		hbmc: hyperbus@47034000 {
+			compatible = "ti,j721e-hbmc", "ti,am654-hbmc";
+			reg = <0x0 0x47034000 0x0 0x100>,
+				<0x5 0x00000000 0x1 0x0000000>;
+			power-domains = <&k3_pds 102 TI_SCI_PD_EXCLUSIVE>;
+			#address-cells = <2>;
+			#size-cells = <1>;
+			mux-controls = <&hbmc_mux 0>;
+			assigned-clocks = <&k3_clks 102 0>;
+			assigned-clock-rates = <166666666>;
+		};
+	};
 };