UBUNTU: [Config] Re-enable ftrace support in the mac80211 layer

Submitted by Paolo Pisati on Oct. 3, 2011, 9:52 a.m.

Details

Message ID 1317635569-25911-2-git-send-email-paolo.pisati@canonical.com
State New
Headers show

Commit Message

Paolo Pisati Oct. 3, 2011, 9:52 a.m.
BugLink: http://bugs.launchpad.net/bugs/865171

Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
---
 debian.ti-omap4/config/config.common.ubuntu |   12 +++++++++++-
 1 files changed, 11 insertions(+), 1 deletions(-)

Comments

Andy Whitcroft Oct. 3, 2011, 12:51 p.m.
On Mon, Oct 03, 2011 at 11:52:49AM +0200, Paolo Pisati wrote:
> BugLink: http://bugs.launchpad.net/bugs/865171
> 
> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
> ---
>  debian.ti-omap4/config/config.common.ubuntu |   12 +++++++++++-
>  1 files changed, 11 insertions(+), 1 deletions(-)
> 
> diff --git a/debian.ti-omap4/config/config.common.ubuntu b/debian.ti-omap4/config/config.common.ubuntu
> index 57f20cb..65276ac 100644
> --- a/debian.ti-omap4/config/config.common.ubuntu
> +++ b/debian.ti-omap4/config/config.common.ubuntu
> @@ -1551,16 +1551,26 @@ CONFIG_M25PXX_USE_FAST_READ=y
>  CONFIG_MA600_DONGLE=m
>  CONFIG_MAC80211=y
>  CONFIG_MAC80211_DEBUGFS=y
> -# CONFIG_MAC80211_DEBUG_MENU is not set
> +# CONFIG_MAC80211_DEBUG_COUNTERS is not set
> +CONFIG_MAC80211_DEBUG_MENU=y
> +CONFIG_MAC80211_DRIVER_API_TRACER=y

I see that this is not turned on in master either.  So as we are this is
consistent.  Should we be turning this on on all oneiric branches ?

>  CONFIG_MAC80211_HAS_RC=y
> +# CONFIG_MAC80211_HT_DEBUG is not set
>  CONFIG_MAC80211_HWSIM=m
> +# CONFIG_MAC80211_IBSS_DEBUG is not set
>  CONFIG_MAC80211_LEDS=y
>  CONFIG_MAC80211_MESH=y
> +# CONFIG_MAC80211_NOINLINE is not set
>  CONFIG_MAC80211_RC_DEFAULT="minstrel_ht"
>  CONFIG_MAC80211_RC_DEFAULT_MINSTREL=y
>  CONFIG_MAC80211_RC_MINSTREL=y
>  CONFIG_MAC80211_RC_MINSTREL_HT=y
>  # CONFIG_MAC80211_RC_PID is not set
> +# CONFIG_MAC80211_TKIP_DEBUG is not set
> +# CONFIG_MAC80211_VERBOSE_DEBUG is not set
> +# CONFIG_MAC80211_VERBOSE_MHWMP_DEBUG is not set
> +# CONFIG_MAC80211_VERBOSE_MPL_DEBUG is not set
> +# CONFIG_MAC80211_VERBOSE_PS_DEBUG is not set
>  # CONFIG_MACH_CM_T35 is not set
>  # CONFIG_MACH_CM_T3517 is not set
>  # CONFIG_MACH_CRANEBOARD is not set

Otherwise it looks to only add a few trace points most seem to be in low
use paths.  I assume someone has confirmed there is no performance
overhead to having this on?

-apw
Paolo Pisati Oct. 3, 2011, 1:37 p.m.
On 10/03/2011 02:51 PM, Andy Whitcroft wrote:
> 
> I see that this is not turned on in master either.  So as we are this is
> consistent.  Should we be turning this on on all oneiric branches ?
[...]
> 
> Otherwise it looks to only add a few trace points most seem to be in low
> use paths.  I assume someone has confirmed there is no performance
> overhead to having this on?

This is (or better was) consistent with the set of options that we get
after every TI BSP import/defaultconfigs.

That being said, if we want to take this as an occasion to reduce the
skew between master and the arm topic branches, i'm ok with it.
Tim Gardner Oct. 3, 2011, 6:49 p.m.
On 10/03/2011 03:52 AM, Paolo Pisati wrote:
> BugLink: http://bugs.launchpad.net/bugs/865171
>
> Signed-off-by: Paolo Pisati<paolo.pisati@canonical.com>
> ---
>   debian.ti-omap4/config/config.common.ubuntu |   12 +++++++++++-
>   1 files changed, 11 insertions(+), 1 deletions(-)
>
> diff --git a/debian.ti-omap4/config/config.common.ubuntu b/debian.ti-omap4/config/config.common.ubuntu
> index 57f20cb..65276ac 100644
> --- a/debian.ti-omap4/config/config.common.ubuntu
> +++ b/debian.ti-omap4/config/config.common.ubuntu
> @@ -1551,16 +1551,26 @@ CONFIG_M25PXX_USE_FAST_READ=y
>   CONFIG_MA600_DONGLE=m
>   CONFIG_MAC80211=y
>   CONFIG_MAC80211_DEBUGFS=y
> -# CONFIG_MAC80211_DEBUG_MENU is not set
> +# CONFIG_MAC80211_DEBUG_COUNTERS is not set
> +CONFIG_MAC80211_DEBUG_MENU=y
> +CONFIG_MAC80211_DRIVER_API_TRACER=y
>   CONFIG_MAC80211_HAS_RC=y
> +# CONFIG_MAC80211_HT_DEBUG is not set
>   CONFIG_MAC80211_HWSIM=m
> +# CONFIG_MAC80211_IBSS_DEBUG is not set
>   CONFIG_MAC80211_LEDS=y
>   CONFIG_MAC80211_MESH=y
> +# CONFIG_MAC80211_NOINLINE is not set
>   CONFIG_MAC80211_RC_DEFAULT="minstrel_ht"
>   CONFIG_MAC80211_RC_DEFAULT_MINSTREL=y
>   CONFIG_MAC80211_RC_MINSTREL=y
>   CONFIG_MAC80211_RC_MINSTREL_HT=y
>   # CONFIG_MAC80211_RC_PID is not set
> +# CONFIG_MAC80211_TKIP_DEBUG is not set
> +# CONFIG_MAC80211_VERBOSE_DEBUG is not set
> +# CONFIG_MAC80211_VERBOSE_MHWMP_DEBUG is not set
> +# CONFIG_MAC80211_VERBOSE_MPL_DEBUG is not set
> +# CONFIG_MAC80211_VERBOSE_PS_DEBUG is not set
>   # CONFIG_MACH_CM_T35 is not set
>   # CONFIG_MACH_CM_T3517 is not set
>   # CONFIG_MACH_CRANEBOARD is not set

Patch hide | download patch | download mbox

diff --git a/debian.ti-omap4/config/config.common.ubuntu b/debian.ti-omap4/config/config.common.ubuntu
index 57f20cb..65276ac 100644
--- a/debian.ti-omap4/config/config.common.ubuntu
+++ b/debian.ti-omap4/config/config.common.ubuntu
@@ -1551,16 +1551,26 @@  CONFIG_M25PXX_USE_FAST_READ=y
 CONFIG_MA600_DONGLE=m
 CONFIG_MAC80211=y
 CONFIG_MAC80211_DEBUGFS=y
-# CONFIG_MAC80211_DEBUG_MENU is not set
+# CONFIG_MAC80211_DEBUG_COUNTERS is not set
+CONFIG_MAC80211_DEBUG_MENU=y
+CONFIG_MAC80211_DRIVER_API_TRACER=y
 CONFIG_MAC80211_HAS_RC=y
+# CONFIG_MAC80211_HT_DEBUG is not set
 CONFIG_MAC80211_HWSIM=m
+# CONFIG_MAC80211_IBSS_DEBUG is not set
 CONFIG_MAC80211_LEDS=y
 CONFIG_MAC80211_MESH=y
+# CONFIG_MAC80211_NOINLINE is not set
 CONFIG_MAC80211_RC_DEFAULT="minstrel_ht"
 CONFIG_MAC80211_RC_DEFAULT_MINSTREL=y
 CONFIG_MAC80211_RC_MINSTREL=y
 CONFIG_MAC80211_RC_MINSTREL_HT=y
 # CONFIG_MAC80211_RC_PID is not set
+# CONFIG_MAC80211_TKIP_DEBUG is not set
+# CONFIG_MAC80211_VERBOSE_DEBUG is not set
+# CONFIG_MAC80211_VERBOSE_MHWMP_DEBUG is not set
+# CONFIG_MAC80211_VERBOSE_MPL_DEBUG is not set
+# CONFIG_MAC80211_VERBOSE_PS_DEBUG is not set
 # CONFIG_MACH_CM_T35 is not set
 # CONFIG_MACH_CM_T3517 is not set
 # CONFIG_MACH_CRANEBOARD is not set