Message ID | 20191007203731.29166-1-arnout@mind.be |
---|---|
State | Accepted |
Headers | show |
Series | [v2] package/python-tornado: only available for Python 3 | expand |
On Mon, 7 Oct 2019 22:37:31 +0200 "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be> wrote: > Since the bump to 6.0.1, python-tornado has dropped support for Python 2 > and now needs Python >= 3.5 (cfr. setup.cfg). > > Apparently this is not checked by setuptools, and apparently > byte-compile is not done in the autobuilders, so there's not autobuild > failure. > > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> > Cc: Asaf Kahlon <asafka7@gmail.com> > Cc: Ryan Barnett <ryan.barnett@rockwellcollins.com> > Cc: Yegor Yefremov <yegorslists@googlemail.com> > -- > v2: also update reverse dependencies (Thomas) > --- > package/circus/Config.in | 6 +++--- > package/python-tomako/Config.in | 1 + > package/python-tornado/Config.in | 10 +++------- > 3 files changed, 7 insertions(+), 10 deletions(-) Applied to master, thanks. Thomas
Hi Arnout, So if there are other python programs in my build that require Python 2.7, I must stay with an earlier version of python-tornado. What is the recommended way to have this customization using br2_external for future builds? I can do it manually with git, but that is not a very future-proof way to downgrade a package. Steve On Mon, Oct 7, 2019 at 1:37 PM Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> wrote: > > Since the bump to 6.0.1, python-tornado has dropped support for Python 2 > and now needs Python >= 3.5 (cfr. setup.cfg). > > Apparently this is not checked by setuptools, and apparently > byte-compile is not done in the autobuilders, so there's not autobuild > failure. > > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> > Cc: Asaf Kahlon <asafka7@gmail.com> > Cc: Ryan Barnett <ryan.barnett@rockwellcollins.com> > Cc: Yegor Yefremov <yegorslists@googlemail.com> > -- > v2: also update reverse dependencies (Thomas) > --- > package/circus/Config.in | 6 +++--- > package/python-tomako/Config.in | 1 + > package/python-tornado/Config.in | 10 +++------- > 3 files changed, 7 insertions(+), 10 deletions(-) > > diff --git a/package/circus/Config.in b/package/circus/Config.in > index f1cd93c733..832b04dfa4 100644 > --- a/package/circus/Config.in > +++ b/package/circus/Config.in > @@ -1,6 +1,6 @@ > config BR2_PACKAGE_CIRCUS > bool "circus" > - depends on BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3 > + depends on BR2_PACKAGE_PYTHON3 # python-tornado > depends on BR2_INSTALL_LIBSTDCPP # pyzmq -> zeromq > depends on BR2_TOOLCHAIN_HAS_THREADS # pyzmq -> zeromq > select BR2_PACKAGE_PYTHON_IOWAIT # runtime > @@ -14,6 +14,6 @@ config BR2_PACKAGE_CIRCUS > > https://circus.readthedocs.org/en/latest/ > > -comment "circus needs Python and a toolchain w/ C++, threads" > +comment "circus needs Python 3 and a toolchain w/ C++, threads" > depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \ > - !(BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3) > + !BR2_PACKAGE_PYTHON3 > diff --git a/package/python-tomako/Config.in b/package/python-tomako/Config.in > index bd6d29982a..1521035bb6 100644 > --- a/package/python-tomako/Config.in > +++ b/package/python-tomako/Config.in > @@ -1,5 +1,6 @@ > config BR2_PACKAGE_PYTHON_TOMAKO > bool "python-tomako" > + depends on BR2_PACKAGE_PYTHON3 # python-tornado > select BR2_PACKAGE_PYTHON_TORNADO # runtime > select BR2_PACKAGE_PYTHON_MAKO # runtime > help > diff --git a/package/python-tornado/Config.in b/package/python-tornado/Config.in > index 1afbdc5729..e1bf8343f0 100644 > --- a/package/python-tornado/Config.in > +++ b/package/python-tornado/Config.in > @@ -1,12 +1,8 @@ > config BR2_PACKAGE_PYTHON_TORNADO > bool "python-tornado" > - select BR2_PACKAGE_PYTHON_ZLIB if BR2_PACKAGE_PYTHON > - select BR2_PACKAGE_PYTHON3_ZLIB if BR2_PACKAGE_PYTHON3 > - select BR2_PACKAGE_PYTHON_SSL if BR2_PACKAGE_PYTHON > - select BR2_PACKAGE_PYTHON3_SSL if BR2_PACKAGE_PYTHON3 > - select BR2_PACKAGE_PYTHON_SINGLEDISPATCH if BR2_PACKAGE_PYTHON # runtime > - select BR2_PACKAGE_PYTHON_BACKPORTS_ABC if BR2_PACKAGE_PYTHON # runtime > - select BR2_PACKAGE_PYTHON_CERTIFI if BR2_PACKAGE_PYTHON # runtime > + depends on BR2_PACKAGE_PYTHON3 > + select BR2_PACKAGE_PYTHON3_ZLIB > + select BR2_PACKAGE_PYTHON3_SSL > help > Tornado is a Python web framework and asynchronous networking > library, originally developed at FriendFeed. > -- > 2.21.0 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
>>>>> "Steve" == Steve Calfee <stevecalfee@gmail.com> writes: > Hi Arnout, > So if there are other python programs in my build that require Python > 2.7, I must stay with an earlier version of python-tornado. > What is the recommended way to have this customization using > br2_external for future builds? I can do it manually with git, but > that is not a very future-proof way to downgrade a package. You can basically copy the old package to your br2-external tree and rename to python2-tornado or similar, and change the references in your custom packages to it, but keep in mind that python 2.x is scheduled to become EOL by January: https://pythonclock.org/ So there is a real chance that python 2.x will be dropped by the time we do the next LTS release (2020.02) - So a better long term solution is to (help) port those python 2.x only python programs to python 3.x.
>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes: > Since the bump to 6.0.1, python-tornado has dropped support for Python 2 > and now needs Python >= 3.5 (cfr. setup.cfg). > Apparently this is not checked by setuptools, and apparently > byte-compile is not done in the autobuilders, so there's not autobuild > failure. > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> > Cc: Asaf Kahlon <asafka7@gmail.com> > Cc: Ryan Barnett <ryan.barnett@rockwellcollins.com> > Cc: Yegor Yefremov <yegorslists@googlemail.com> > -- > v2: also update reverse dependencies (Thomas) Committed to 2019.08.x, thanks.
diff --git a/package/circus/Config.in b/package/circus/Config.in index f1cd93c733..832b04dfa4 100644 --- a/package/circus/Config.in +++ b/package/circus/Config.in @@ -1,6 +1,6 @@ config BR2_PACKAGE_CIRCUS bool "circus" - depends on BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3 + depends on BR2_PACKAGE_PYTHON3 # python-tornado depends on BR2_INSTALL_LIBSTDCPP # pyzmq -> zeromq depends on BR2_TOOLCHAIN_HAS_THREADS # pyzmq -> zeromq select BR2_PACKAGE_PYTHON_IOWAIT # runtime @@ -14,6 +14,6 @@ config BR2_PACKAGE_CIRCUS https://circus.readthedocs.org/en/latest/ -comment "circus needs Python and a toolchain w/ C++, threads" +comment "circus needs Python 3 and a toolchain w/ C++, threads" depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \ - !(BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3) + !BR2_PACKAGE_PYTHON3 diff --git a/package/python-tomako/Config.in b/package/python-tomako/Config.in index bd6d29982a..1521035bb6 100644 --- a/package/python-tomako/Config.in +++ b/package/python-tomako/Config.in @@ -1,5 +1,6 @@ config BR2_PACKAGE_PYTHON_TOMAKO bool "python-tomako" + depends on BR2_PACKAGE_PYTHON3 # python-tornado select BR2_PACKAGE_PYTHON_TORNADO # runtime select BR2_PACKAGE_PYTHON_MAKO # runtime help diff --git a/package/python-tornado/Config.in b/package/python-tornado/Config.in index 1afbdc5729..e1bf8343f0 100644 --- a/package/python-tornado/Config.in +++ b/package/python-tornado/Config.in @@ -1,12 +1,8 @@ config BR2_PACKAGE_PYTHON_TORNADO bool "python-tornado" - select BR2_PACKAGE_PYTHON_ZLIB if BR2_PACKAGE_PYTHON - select BR2_PACKAGE_PYTHON3_ZLIB if BR2_PACKAGE_PYTHON3 - select BR2_PACKAGE_PYTHON_SSL if BR2_PACKAGE_PYTHON - select BR2_PACKAGE_PYTHON3_SSL if BR2_PACKAGE_PYTHON3 - select BR2_PACKAGE_PYTHON_SINGLEDISPATCH if BR2_PACKAGE_PYTHON # runtime - select BR2_PACKAGE_PYTHON_BACKPORTS_ABC if BR2_PACKAGE_PYTHON # runtime - select BR2_PACKAGE_PYTHON_CERTIFI if BR2_PACKAGE_PYTHON # runtime + depends on BR2_PACKAGE_PYTHON3 + select BR2_PACKAGE_PYTHON3_ZLIB + select BR2_PACKAGE_PYTHON3_SSL help Tornado is a Python web framework and asynchronous networking library, originally developed at FriendFeed.
Since the bump to 6.0.1, python-tornado has dropped support for Python 2 and now needs Python >= 3.5 (cfr. setup.cfg). Apparently this is not checked by setuptools, and apparently byte-compile is not done in the autobuilders, so there's not autobuild failure. Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Cc: Asaf Kahlon <asafka7@gmail.com> Cc: Ryan Barnett <ryan.barnett@rockwellcollins.com> Cc: Yegor Yefremov <yegorslists@googlemail.com> -- v2: also update reverse dependencies (Thomas) --- package/circus/Config.in | 6 +++--- package/python-tomako/Config.in | 1 + package/python-tornado/Config.in | 10 +++------- 3 files changed, 7 insertions(+), 10 deletions(-)