Patchwork hmp: re-enable trace-file command

login
register
mail settings
Submitter Michael Roth
Date Oct. 2, 2011, 1:44 p.m.
Message ID <1317563077-9717-1-git-send-email-mdroth@linux.vnet.ibm.com>
Download mbox | patch
Permalink /patch/117286/
State New
Headers show

Comments

Michael Roth - Oct. 2, 2011, 1:44 p.m.
Commit 31965ae27bc11e90674be12584bb201b83df5aef reverted a previous
renaming of CONFIG_SIMPLE_TRACE->CONFIG_TRACE_SIMPLE in a couple spots,
leading to trace-file currently being unavailable.

Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---
 hmp-commands.hx |    2 +-
 monitor.c       |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Stefan Hajnoczi - Oct. 3, 2011, 7:08 a.m.
On Sun, Oct 02, 2011 at 08:44:37AM -0500, Michael Roth wrote:
> Commit 31965ae27bc11e90674be12584bb201b83df5aef reverted a previous
> renaming of CONFIG_SIMPLE_TRACE->CONFIG_TRACE_SIMPLE in a couple spots,
> leading to trace-file currently being unavailable.
> 
> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> ---
>  hmp-commands.hx |    2 +-
>  monitor.c       |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Thanks, applied to the tracing patches tree:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/tracing

Stefan

Patch

diff --git a/hmp-commands.hx b/hmp-commands.hx
index 9e1cca8..844e6c9 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -194,7 +194,7 @@  STEXI
 changes status of a trace event
 ETEXI
 
-#if defined(CONFIG_SIMPLE_TRACE)
+#if defined(CONFIG_TRACE_SIMPLE)
     {
         .name       = "trace-file",
         .args_type  = "op:s?,arg:F?",
diff --git a/monitor.c b/monitor.c
index 8ec2c5e..4f5335e 100644
--- a/monitor.c
+++ b/monitor.c
@@ -605,7 +605,7 @@  static void do_trace_event_set_state(Monitor *mon, const QDict *qdict)
     }
 }
 
-#ifdef CONFIG_SIMPLE_TRACE
+#ifdef CONFIG_TRACE_SIMPLE
 static void do_trace_file(Monitor *mon, const QDict *qdict)
 {
     const char *op = qdict_get_try_str(qdict, "op");