| Message ID | 20191005215508.28754-1-mst@redhat.com |
|---|---|
| State | New |
| Headers | show |
On Sat, 5 Oct 2019 at 22:58, Michael S. Tsirkin <mst@redhat.com> wrote: > > A couple of tweaks to the bios table test weren't > reviewed yet but as they are really helpful to > the arm tests I'm pushing, and affecting only the > test so fairly benign (dropped assert + a comment), > I cut a corner and pushed them straight away. > Will be easy to tweak with a patch on top or revert. > > The following changes since commit 4f59102571fce49af180cfc6d4cdd2b5df7bdb14: > > Merge remote-tracking branch 'remotes/amarkovic/tags/mips-queue-oct-01-2019' into staging (2019-10-01 16:21:42 +0100) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream > > for you to fetch changes up to 9d59bed1da5e5815987879346cf708344060ea63: > > virtio: add vhost-user-fs-pci device (2019-10-05 17:43:55 -0400) > > ---------------------------------------------------------------- > virtio, vhost, acpi: features, fixes, tests > > Tests for arm/virt ACPI tables. > Virtio fs support (no migration). > A vhost-user reconnect bugfix. Hi -- this summary of the changes just says it has updates to the test code, but the patches include: > Shameer Kolothum (8): > hw/arm/virt: Enable device memory cold/hot plug with ACPI boot which is to say actually enabling the hotplug memory feature, not just tweaking tests. Did you mean to put the whole feature in this pullreq? (If you did, that's fine, it just doesn't match up with the cover letter so maybe it was an accident?) thanks -- PMM
On Mon, Oct 07, 2019 at 05:31:32PM +0100, Peter Maydell wrote: > On Sat, 5 Oct 2019 at 22:58, Michael S. Tsirkin <mst@redhat.com> wrote: > > > > A couple of tweaks to the bios table test weren't > > reviewed yet but as they are really helpful to > > the arm tests I'm pushing, and affecting only the > > test so fairly benign (dropped assert + a comment), > > I cut a corner and pushed them straight away. > > Will be easy to tweak with a patch on top or revert. > > > > The following changes since commit 4f59102571fce49af180cfc6d4cdd2b5df7bdb14: > > > > Merge remote-tracking branch 'remotes/amarkovic/tags/mips-queue-oct-01-2019' into staging (2019-10-01 16:21:42 +0100) > > > > are available in the Git repository at: > > > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream > > > > for you to fetch changes up to 9d59bed1da5e5815987879346cf708344060ea63: > > > > virtio: add vhost-user-fs-pci device (2019-10-05 17:43:55 -0400) > > > > ---------------------------------------------------------------- > > virtio, vhost, acpi: features, fixes, tests > > > > Tests for arm/virt ACPI tables. > > Virtio fs support (no migration). > > A vhost-user reconnect bugfix. > > Hi -- this summary of the changes just says it has > updates to the test code, but the patches include: > > > Shameer Kolothum (8): > > hw/arm/virt: Enable device memory cold/hot plug with ACPI boot > > which is to say actually enabling the hotplug memory feature, > not just tweaking tests. Did you mean to put the whole feature > in this pullreq? (If you did, that's fine, it just doesn't > match up with the cover letter so maybe it was an accident?) > > thanks > -- PMM Yes this was intentional. I meant I was asked to merge it because of the tests. But tests wouldn't pass without the feature :) I've updated the description. Pls pull.
On Sat, 5 Oct 2019 at 22:58, Michael S. Tsirkin <mst@redhat.com> wrote: > > A couple of tweaks to the bios table test weren't > reviewed yet but as they are really helpful to > the arm tests I'm pushing, and affecting only the > test so fairly benign (dropped assert + a comment), > I cut a corner and pushed them straight away. > Will be easy to tweak with a patch on top or revert. > > The following changes since commit 4f59102571fce49af180cfc6d4cdd2b5df7bdb14: > > Merge remote-tracking branch 'remotes/amarkovic/tags/mips-queue-oct-01-2019' into staging (2019-10-01 16:21:42 +0100) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream > > for you to fetch changes up to 9d59bed1da5e5815987879346cf708344060ea63: > > virtio: add vhost-user-fs-pci device (2019-10-05 17:43:55 -0400) > > ---------------------------------------------------------------- > virtio, vhost, acpi: features, fixes, tests > > Tests for arm/virt ACPI tables. > Virtio fs support (no migration). > A vhost-user reconnect bugfix. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > > ---------------------------------------------------------------- Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/4.2 for any user-visible changes. (I put in an entry for the Arm parts: * The virt board now supports memory hotplugging, when used with a UEFI guest BIOS and ACPI. ) thanks -- PMM
A couple of tweaks to the bios table test weren't reviewed yet but as they are really helpful to the arm tests I'm pushing, and affecting only the test so fairly benign (dropped assert + a comment), I cut a corner and pushed them straight away. Will be easy to tweak with a patch on top or revert. The following changes since commit 4f59102571fce49af180cfc6d4cdd2b5df7bdb14: Merge remote-tracking branch 'remotes/amarkovic/tags/mips-queue-oct-01-2019' into staging (2019-10-01 16:21:42 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up to 9d59bed1da5e5815987879346cf708344060ea63: virtio: add vhost-user-fs-pci device (2019-10-05 17:43:55 -0400) ---------------------------------------------------------------- virtio, vhost, acpi: features, fixes, tests Tests for arm/virt ACPI tables. Virtio fs support (no migration). A vhost-user reconnect bugfix. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> ---------------------------------------------------------------- Adrian Moreno (1): vhost-user: save features if the char dev is closed Dr. David Alan Gilbert (3): virtio: Add virtio_fs linux headers virtio: add vhost-user-fs base device virtio: add vhost-user-fs-pci device Eric Auger (1): hw/arm/virt: Add memory hotplug framework Michael S. Tsirkin (4): tests/acpi: add empty files tests: allow empty expected files tests: document how to update acpi tables tests/acpi: add expected tables for arm/virt Samuel Ortiz (2): hw/acpi: Do not create memory hotplug method when handler is not defined hw/acpi: Add ACPI Generic Event Device Support Shameer Kolothum (8): hw/acpi: Make ACPI IO address space configurable hw/arm/virt: Enable device memory cold/hot plug with ACPI boot hw/arm/virt-acpi-build: Add PC-DIMM in SRAT hw/arm: Factor out powerdown notifier from GPIO hw/arm: Use GED for system_powerdown event docs/specs: Add ACPI GED documentation tests: Update ACPI tables list for upcoming arm/virt tests tests: Add bios tests to arm/virt configure | 13 ++ include/hw/acpi/acpi_dev_interface.h | 1 + include/hw/acpi/generic_event_device.h | 103 +++++++++ include/hw/acpi/memory_hotplug.h | 9 +- include/hw/arm/virt.h | 5 + include/hw/i386/pc.h | 3 + include/hw/virtio/vhost-user-fs.h | 45 ++++ include/standard-headers/linux/virtio_fs.h | 19 ++ include/standard-headers/linux/virtio_ids.h | 2 + hw/acpi/generic_event_device.c | 311 ++++++++++++++++++++++++++++ hw/acpi/memory_hotplug.c | 43 ++-- hw/arm/virt-acpi-build.c | 35 +++- hw/arm/virt.c | 124 +++++++++-- hw/i386/acpi-build.c | 7 +- hw/i386/pc.c | 3 + hw/virtio/vhost-user-fs-pci.c | 85 ++++++++ hw/virtio/vhost-user-fs.c | 299 ++++++++++++++++++++++++++ net/vhost-user.c | 4 + tests/bios-tables-test.c | 81 +++++++- docs/specs/acpi_hw_reduced_hotplug.rst | 70 +++++++ docs/specs/index.rst | 1 + hw/acpi/Kconfig | 4 + hw/acpi/Makefile.objs | 1 + hw/arm/Kconfig | 4 + hw/virtio/Makefile.objs | 2 + tests/data/acpi/virt/APIC.memhp | Bin 0 -> 168 bytes tests/data/acpi/virt/APIC.numamem | Bin 0 -> 168 bytes tests/data/acpi/virt/DSDT | Bin 18476 -> 18470 bytes tests/data/acpi/virt/DSDT.memhp | Bin 0 -> 19807 bytes tests/data/acpi/virt/DSDT.numamem | Bin 0 -> 18470 bytes tests/data/acpi/virt/FACP.memhp | Bin 0 -> 268 bytes tests/data/acpi/virt/FACP.numamem | Bin 0 -> 268 bytes tests/data/acpi/virt/GTDT.memhp | Bin 0 -> 96 bytes tests/data/acpi/virt/GTDT.numamem | Bin 0 -> 96 bytes tests/data/acpi/virt/MCFG.memhp | Bin 0 -> 60 bytes tests/data/acpi/virt/MCFG.numamem | Bin 0 -> 60 bytes tests/data/acpi/virt/SLIT.memhp | Bin 0 -> 48 bytes tests/data/acpi/virt/SPCR.memhp | Bin 0 -> 80 bytes tests/data/acpi/virt/SPCR.numamem | Bin 0 -> 80 bytes tests/data/acpi/virt/SRAT.memhp | Bin 0 -> 186 bytes tests/data/acpi/virt/SRAT.numamem | Bin 0 -> 106 bytes 41 files changed, 1232 insertions(+), 42 deletions(-) create mode 100644 include/hw/acpi/generic_event_device.h create mode 100644 include/hw/virtio/vhost-user-fs.h create mode 100644 include/standard-headers/linux/virtio_fs.h create mode 100644 hw/acpi/generic_event_device.c create mode 100644 hw/virtio/vhost-user-fs-pci.c create mode 100644 hw/virtio/vhost-user-fs.c create mode 100644 docs/specs/acpi_hw_reduced_hotplug.rst create mode 100644 tests/data/acpi/virt/APIC.memhp create mode 100644 tests/data/acpi/virt/APIC.numamem create mode 100644 tests/data/acpi/virt/DSDT.memhp create mode 100644 tests/data/acpi/virt/DSDT.numamem create mode 100644 tests/data/acpi/virt/FACP.memhp create mode 100644 tests/data/acpi/virt/FACP.numamem create mode 100644 tests/data/acpi/virt/GTDT.memhp create mode 100644 tests/data/acpi/virt/GTDT.numamem create mode 100644 tests/data/acpi/virt/MCFG.memhp create mode 100644 tests/data/acpi/virt/MCFG.numamem create mode 100644 tests/data/acpi/virt/SLIT.memhp create mode 100644 tests/data/acpi/virt/SPCR.memhp create mode 100644 tests/data/acpi/virt/SPCR.numamem create mode 100644 tests/data/acpi/virt/SRAT.memhp create mode 100644 tests/data/acpi/virt/SRAT.numamem