diff mbox series

package/python-tornado: only available for Python 3

Message ID 20191005154222.27923-1-arnout@mind.be
State Changes Requested
Headers show
Series package/python-tornado: only available for Python 3 | expand

Commit Message

Arnout Vandecappelle Oct. 5, 2019, 3:42 p.m. UTC
Since the bump to 6.0.1, python-tornado has dropped support for Python 2
and now needs Python >= 3.5 (cfr. setup.cfg).

Apparently this is not checked by setuptools, and apparently
byte-compile is not done in the autobuilders, so there's not autobuild
failure.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Cc: Asaf Kahlon <asafka7@gmail.com>
Cc: Ryan Barnett <ryan.barnett@rockwellcollins.com>
Cc: Yegor Yefremov <yegorslists@googlemail.com>
---
 package/python-tornado/Config.in | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

Comments

Thomas Petazzoni Oct. 5, 2019, 8:39 p.m. UTC | #1
On Sat,  5 Oct 2019 17:42:22 +0200
"Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be> wrote:

> Since the bump to 6.0.1, python-tornado has dropped support for Python 2
> and now needs Python >= 3.5 (cfr. setup.cfg).
> 
> Apparently this is not checked by setuptools, and apparently
> byte-compile is not done in the autobuilders, so there's not autobuild
> failure.
> 
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Cc: Asaf Kahlon <asafka7@gmail.com>
> Cc: Ryan Barnett <ryan.barnett@rockwellcollins.com>
> Cc: Yegor Yefremov <yegorslists@googlemail.com>

You forgot the reverse dependencies of BR2_PACKAGE_PYTHON_TORNADO:
circus and python-tomako, both of which are available for both python2
and python3.

Thomas
diff mbox series

Patch

diff --git a/package/python-tornado/Config.in b/package/python-tornado/Config.in
index 1afbdc5729..e1bf8343f0 100644
--- a/package/python-tornado/Config.in
+++ b/package/python-tornado/Config.in
@@ -1,12 +1,8 @@ 
 config BR2_PACKAGE_PYTHON_TORNADO
 	bool "python-tornado"
-	select BR2_PACKAGE_PYTHON_ZLIB if BR2_PACKAGE_PYTHON
-	select BR2_PACKAGE_PYTHON3_ZLIB if BR2_PACKAGE_PYTHON3
-	select BR2_PACKAGE_PYTHON_SSL if BR2_PACKAGE_PYTHON
-	select BR2_PACKAGE_PYTHON3_SSL if BR2_PACKAGE_PYTHON3
-	select BR2_PACKAGE_PYTHON_SINGLEDISPATCH if BR2_PACKAGE_PYTHON # runtime
-	select BR2_PACKAGE_PYTHON_BACKPORTS_ABC	if BR2_PACKAGE_PYTHON # runtime
-	select BR2_PACKAGE_PYTHON_CERTIFI if BR2_PACKAGE_PYTHON # runtime
+	depends on BR2_PACKAGE_PYTHON3
+	select BR2_PACKAGE_PYTHON3_ZLIB
+	select BR2_PACKAGE_PYTHON3_SSL
 	help
 	  Tornado is a Python web framework and asynchronous networking
 	  library, originally developed at FriendFeed.