| Message ID | 20191005141913.22020-2-jagan@amarulasolutions.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [v10,1/6] dt-bindings: sun6i-dsi: Add A64 MIPI-DSI compatible | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
On Sat, Oct 05, 2019 at 07:49:08PM +0530, Jagan Teki wrote: > The MIPI DSI controller in Allwinner A64 is similar to A33. > > But unlike A33, A64 doesn't have DSI_SCLK gating so it is valid > to with separate compatible for A64 on the same driver. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > .../bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml b/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml > index dafc0980c4fa..cfcc84d38084 100644 > --- a/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml > +++ b/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml > @@ -15,7 +15,9 @@ properties: > "#size-cells": true > > compatible: > - const: allwinner,sun6i-a31-mipi-dsi > + enum: > + - const: allwinner,sun6i-a31-mipi-dsi > + - const: allwinner,sun50i-a64-mipi-dsi How did you test this? It will report an error when running the validation Maxime
On Mon, Oct 7, 2019 at 3:01 PM Maxime Ripard <mripard@kernel.org> wrote: > > On Sat, Oct 05, 2019 at 07:49:08PM +0530, Jagan Teki wrote: > > The MIPI DSI controller in Allwinner A64 is similar to A33. > > > > But unlike A33, A64 doesn't have DSI_SCLK gating so it is valid > > to with separate compatible for A64 on the same driver. > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > --- > > .../bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml b/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml > > index dafc0980c4fa..cfcc84d38084 100644 > > --- a/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml > > +++ b/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml > > @@ -15,7 +15,9 @@ properties: > > "#size-cells": true > > > > compatible: > > - const: allwinner,sun6i-a31-mipi-dsi > > + enum: > > + - const: allwinner,sun6i-a31-mipi-dsi > > + - const: allwinner,sun50i-a64-mipi-dsi > > How did you test this? It will report an error when running the > validation I did follow the v9 comments [1] and forgot to do dt-doc-validate. will send the v11 for this patch alone, will that be okay? [1] https://patchwork.freedesktop.org/patch/307499/
On Sun, Oct 13, 2019 at 10:32:18PM +0530, Jagan Teki wrote: > On Mon, Oct 7, 2019 at 3:01 PM Maxime Ripard <mripard@kernel.org> wrote: > > > > On Sat, Oct 05, 2019 at 07:49:08PM +0530, Jagan Teki wrote: > > > The MIPI DSI controller in Allwinner A64 is similar to A33. > > > > > > But unlike A33, A64 doesn't have DSI_SCLK gating so it is valid > > > to with separate compatible for A64 on the same driver. > > > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > > --- > > > .../bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml b/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml > > > index dafc0980c4fa..cfcc84d38084 100644 > > > --- a/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml > > > +++ b/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml > > > @@ -15,7 +15,9 @@ properties: > > > "#size-cells": true > > > > > > compatible: > > > - const: allwinner,sun6i-a31-mipi-dsi > > > + enum: > > > + - const: allwinner,sun6i-a31-mipi-dsi > > > + - const: allwinner,sun50i-a64-mipi-dsi > > > > How did you test this? It will report an error when running the > > validation > > I did follow the v9 comments [1] and forgot to do dt-doc-validate. > will send the v11 for this patch alone, will that be okay? > > [1] https://patchwork.freedesktop.org/patch/307499/ There's some changes to the DTSI to do as well, so please do them, check that the device trees are validated properly, and send a new version. Maxime
diff --git a/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml b/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml index dafc0980c4fa..cfcc84d38084 100644 --- a/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml +++ b/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml @@ -15,7 +15,9 @@ properties: "#size-cells": true compatible: - const: allwinner,sun6i-a31-mipi-dsi + enum: + - const: allwinner,sun6i-a31-mipi-dsi + - const: allwinner,sun50i-a64-mipi-dsi reg: maxItems: 1
The MIPI DSI controller in Allwinner A64 is similar to A33. But unlike A33, A64 doesn't have DSI_SCLK gating so it is valid to with separate compatible for A64 on the same driver. Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- .../bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)