Patchwork [google] Specify target as ix86 or x86_64 for test builtin_target.c (issue5174041)

login
register
mail settings
Submitter Sriraman Tallam
Date Sept. 30, 2011, 9:09 p.m.
Message ID <20110930210950.02D07B2190@azwildcat.mtv.corp.google.com>
Download mbox | patch
Permalink /patch/117215/
State New
Headers show

Comments

Sriraman Tallam - Sept. 30, 2011, 9:09 p.m.
* testsuite/gcc.dg/builtin_target.c: Specify target as ix86 or
	x86_64.


--
This patch is available for review at http://codereview.appspot.com/5174041
Sriraman Tallam - Sept. 30, 2011, 9:32 p.m.
This is now submitted.

Thanks,
-Sri.

On Fri, Sep 30, 2011 at 2:09 PM, Sriraman Tallam <tmsriram@google.com> wrote:
>        * testsuite/gcc.dg/builtin_target.c: Specify target as ix86 or
>        x86_64.
>
> Index: gcc.dg/builtin_target.c
> ===================================================================
> --- gcc.dg/builtin_target.c     (revision 179400)
> +++ gcc.dg/builtin_target.c     (working copy)
> @@ -1,6 +1,6 @@
>  /* This test checks if the __builtin_cpu_* calls are recognized. */
>
> -/* { dg-do run } */
> +/* { dg-do run { target i?86-*-* x86_64-*-* } } */
>
>  int
>  fn1 ()
>
> --
> This patch is available for review at http://codereview.appspot.com/5174041
>
Richard Henderson - Sept. 30, 2011, 9:33 p.m.
On 09/30/2011 02:09 PM, Sriraman Tallam wrote:
> 	* testsuite/gcc.dg/builtin_target.c: Specify target as ix86 or
> 	x86_64.
> 
> Index: gcc.dg/builtin_target.c
> ===================================================================
> --- gcc.dg/builtin_target.c	(revision 179400)
> +++ gcc.dg/builtin_target.c	(working copy)
> @@ -1,6 +1,6 @@
>  /* This test checks if the __builtin_cpu_* calls are recognized. */
>  
> -/* { dg-do run } */
> +/* { dg-do run { target i?86-*-* x86_64-*-* } } */

This is an indication that the test is in the wrong place.
It should be in gcc.target/i386/


r~

Patch

Index: gcc.dg/builtin_target.c
===================================================================
--- gcc.dg/builtin_target.c	(revision 179400)
+++ gcc.dg/builtin_target.c	(working copy)
@@ -1,6 +1,6 @@ 
 /* This test checks if the __builtin_cpu_* calls are recognized. */
 
-/* { dg-do run } */
+/* { dg-do run { target i?86-*-* x86_64-*-* } } */
 
 int
 fn1 ()