From patchwork Fri Oct 4 18:58:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Navid Emamdoost X-Patchwork-Id: 1172023 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="sO1FMEKy"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 46lK0d64jTz9sP7 for ; Sat, 5 Oct 2019 04:58:57 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727548AbfJDS64 (ORCPT ); Fri, 4 Oct 2019 14:58:56 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:42790 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725775AbfJDS64 (ORCPT ); Fri, 4 Oct 2019 14:58:56 -0400 Received: by mail-io1-f67.google.com with SMTP id n197so15738004iod.9; Fri, 04 Oct 2019 11:58:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=kXHET19Vk3ufWjPl9i1yNVAiht7vLl0NnWpu74eHgeU=; b=sO1FMEKyJTjFPQcT+L/dKuFzkgo57xekEfRmImYpxXqhSLbLZq3myaxr0l5m+/As5I KVp6eO7y1xFSP0u/UB6mwbeJrItmyVT+p2yBx3+m0y0OcoC9ES0mW7gP8Iw44ntYnWdr L6oFVYrSst1MzUSXjmAvQTq991IE+HccFFbYQnfZ7Nv0eikSKx+7X8if/KHnx3EO4/6l F/5DoyS5mVYBhEdpbz9vzNXlBww+GY1oEcVvrgGvs/CerJlfs+4HA+Oe16tIuXeDC6DL 8BmX5hI/pHpxoIluGvhNRlH/t20NqfhwtYi7/IuAISlcu7WPnfBAOcz0LQlu+d0kR6bg +I9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=kXHET19Vk3ufWjPl9i1yNVAiht7vLl0NnWpu74eHgeU=; b=jS7JqNUQRmvYj8LTTRhpdkgK4aMJpEIu76brlBNkrpdLkzbOjKYB9BvBnQW0vmWF22 wwrC6K8t1no3owW/YKCalsvrnF5j3M6iGeoqnh4DRm9IAr58JQlrQetw7VfOA8TXq6Yu dvT9yJf2HEA7d1u+jEdz8drctk8VgumKv+2/7mhesoT95kLmO/AMZzOlreYQ5QsPrak5 KbfsjolSEEfeXVwkcVpn8krJ7W/MGWL6tvZqqdcqyEF+w+K7YxL0OFUV9L56jThjH70f oX/OYHUTGwjxJLVf/PD6+tg5qxiS/fV+f9VL5IeO1gSUZORi8uhcelGWMZ5HFzzcWXnm xZMQ== X-Gm-Message-State: APjAAAXnLHMFYubFRDEv048VVabxpbPksQ52btz6+5XduFfT85/FREho O1kUfx3vZ6uRX/rV8u7SH8i7bL0uEGY= X-Google-Smtp-Source: APXvYqyPeetbm4o4ZccCpbFyoCJhYovBEFhTHkb31+QBJFPrTzJueRzkUOiLinOxqUk5c3x0b8V/Xg== X-Received: by 2002:a02:bb8f:: with SMTP id g15mr7167749jan.110.1570215535345; Fri, 04 Oct 2019 11:58:55 -0700 (PDT) Received: from cs-dulles.cs.umn.edu (cs-dulles.cs.umn.edu. [128.101.35.54]) by smtp.googlemail.com with ESMTPSA id c8sm3377684ile.9.2019.10.04.11.58.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2019 11:58:54 -0700 (PDT) From: Navid Emamdoost Cc: emamd001@umn.edu, kjlu@umn.edu, smccaman@umn.edu, Navid Emamdoost , Rob Herring , Frank Rowand , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] of: unittest: fix memory leak in unittest_data_add Date: Fri, 4 Oct 2019 13:58:43 -0500 Message-Id: <20191004185847.14074-1-navid.emamdoost@gmail.com> X-Mailer: git-send-email 2.17.1 To: unlisted-recipients:; (no To-header on input) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org In unittest_data_add, a copy buffer is created via kmemdup. This buffer is leaked if of_fdt_unflatten_tree fails. The release for the unittest_data buffer is added. Fixes: b951f9dc7f25 ("Enabling OF selftest to run without machine's devicetree") Signed-off-by: Navid Emamdoost Reviewed-by: Frank Rowand --- drivers/of/unittest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index 480a21e2ed39..92e895d86458 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -1207,6 +1207,7 @@ static int __init unittest_data_add(void) of_fdt_unflatten_tree(unittest_data, NULL, &unittest_data_node); if (!unittest_data_node) { pr_warn("%s: No tree to attach; not running tests\n", __func__); + kfree(unittest_data); return -ENODATA; }