Patchwork [U-Boot] I2C: mv_i2c: fix build issue when enable debug option

login
register
mail settings
Submitter Lei Wen
Date Sept. 30, 2011, 3:43 p.m.
Message ID <1317397428-4066-1-git-send-email-leiwen@marvell.com>
Download mbox | patch
Permalink /patch/117168/
State Accepted
Commit 2be1ed349ca268d3867840fd28960785fd3def0b
Delegated to: Heiko Schocher
Headers show

Comments

Lei Wen - Sept. 30, 2011, 3:43 p.m.
When DEBUG_I2C is open, the following build issue would shows up.

mv_i2c.c: In function 'i2c_transfer':
mv_i2c.c:257: error: 'ISR' undeclared (first use in this function)
mv_i2c.c:257: error: (Each undeclared identifier is reported only once
mv_i2c.c:257: error: for each function it appears in.)

Signed-off-by: Lei Wen <leiwen@marvell.com>
---
 drivers/i2c/mv_i2c.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Heiko Schocher - Oct. 3, 2011, 9:56 a.m.
Hello Lei,

Lei Wen wrote:
> When DEBUG_I2C is open, the following build issue would shows up.
> 
> mv_i2c.c: In function 'i2c_transfer':
> mv_i2c.c:257: error: 'ISR' undeclared (first use in this function)
> mv_i2c.c:257: error: (Each undeclared identifier is reported only once
> mv_i2c.c:257: error: for each function it appears in.)
> 
> Signed-off-by: Lei Wen <leiwen@marvell.com>
> ---
>  drivers/i2c/mv_i2c.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Applied to u-boot-i2c.git

Thanks!

bye,
Heiko

Patch

diff --git a/drivers/i2c/mv_i2c.c b/drivers/i2c/mv_i2c.c
index dcbe1ae..8eb30e7 100644
--- a/drivers/i2c/mv_i2c.c
+++ b/drivers/i2c/mv_i2c.c
@@ -253,7 +253,7 @@  transfer_error_bus_busy:
 		ret = -6; goto i2c_transfer_finish;
 
 i2c_transfer_finish:
-		PRINTD(("i2c_transfer: ISR: 0x%04x\n", ISR));
+		PRINTD(("i2c_transfer: ISR: 0x%04x\n", readl(&base->isr)));
 		i2c_reset();
 		return ret;
 }