| Message ID | 20191003230404.19384-15-philmd@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | hw: Split RTC devices from hw/timer/ to hw/rtc/ | expand |
Le 04/10/2019 à 01:04, Philippe Mathieu-Daudé a écrit : > The system <stdint.h> include is already provided by "osdep.h" > (the scripts/clean-includes file clean such headers). > > Commit 64552b6be47 suggests we don't need to include "hw/irq.h": > > Move the qemu_irq and qemu_irq_handler typedefs from hw/irq.h to > qemu/typedefs.h, and then include hw/irq.h only where it's still > needed. > > Reviewed-by: Cédric Le Goater <clg@kaod.org> > Reviewed-by: Alistair Francis <alistair.francis@wdc.com> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > include/hw/rtc/aspeed_rtc.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/include/hw/rtc/aspeed_rtc.h b/include/hw/rtc/aspeed_rtc.h > index 3fde854ad9..b94a710268 100644 > --- a/include/hw/rtc/aspeed_rtc.h > +++ b/include/hw/rtc/aspeed_rtc.h > @@ -8,9 +8,6 @@ > #ifndef HW_RTC_ASPEED_RTC_H > #define HW_RTC_ASPEED_RTC_H > > -#include <stdint.h> > - > -#include "hw/irq.h" > #include "hw/sysbus.h" > > typedef struct AspeedRtcState { > Applied to my trivial-patches branch. Thanks, Laurent
diff --git a/include/hw/rtc/aspeed_rtc.h b/include/hw/rtc/aspeed_rtc.h index 3fde854ad9..b94a710268 100644 --- a/include/hw/rtc/aspeed_rtc.h +++ b/include/hw/rtc/aspeed_rtc.h @@ -8,9 +8,6 @@ #ifndef HW_RTC_ASPEED_RTC_H #define HW_RTC_ASPEED_RTC_H -#include <stdint.h> - -#include "hw/irq.h" #include "hw/sysbus.h" typedef struct AspeedRtcState {
The system <stdint.h> include is already provided by "osdep.h" (the scripts/clean-includes file clean such headers). Commit 64552b6be47 suggests we don't need to include "hw/irq.h": Move the qemu_irq and qemu_irq_handler typedefs from hw/irq.h to qemu/typedefs.h, and then include hw/irq.h only where it's still needed. Reviewed-by: Cédric Le Goater <clg@kaod.org> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- include/hw/rtc/aspeed_rtc.h | 3 --- 1 file changed, 3 deletions(-)