[SRU,OEM-OSP1-B] spi-nor: intel-spi: Add support for Intel Comet Lake SPI serial flash
diff mbox series

Message ID 20191003175929.29165-1-tjaalton@ubuntu.com
State New
Headers show
Series
  • [SRU,OEM-OSP1-B] spi-nor: intel-spi: Add support for Intel Comet Lake SPI serial flash
Related show

Commit Message

Timo Aaltonen Oct. 3, 2019, 5:59 p.m. UTC
From: Mika Westerberg <mika.westerberg@linux.intel.com>

BugLink: http://bugs.launchpad.net/bugs/1843774

Intel Comet Lake has the same SPI serial flash controller as Ice Lake.
Add Comet Lake PCI ID to the driver list of supported devices.

Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
(cherry picked from commit e43f53c22a937d024f070907d02539e413f20c15)
Signed-off-by: Timo Aaltonen <timo.aaltonen@canonical.com>
---
 drivers/mtd/spi-nor/intel-spi-pci.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Timo Aaltonen Oct. 3, 2019, 6:20 p.m. UTC | #1
On 3.10.2019 20.59, Timo Aaltonen wrote:
> From: Mika Westerberg <mika.westerberg@linux.intel.com>
> 
> BugLink: http://bugs.launchpad.net/bugs/1843774
> 
> Intel Comet Lake has the same SPI serial flash controller as Ice Lake.
> Add Comet Lake PCI ID to the driver list of supported devices.
> 
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> (cherry picked from commit e43f53c22a937d024f070907d02539e413f20c15)
> Signed-off-by: Timo Aaltonen <timo.aaltonen@canonical.com>
> ---
>   drivers/mtd/spi-nor/intel-spi-pci.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mtd/spi-nor/intel-spi-pci.c b/drivers/mtd/spi-nor/intel-spi-pci.c
> index 872b40922608..bfbfc17ed6aa 100644
> --- a/drivers/mtd/spi-nor/intel-spi-pci.c
> +++ b/drivers/mtd/spi-nor/intel-spi-pci.c
> @@ -63,6 +63,7 @@ static void intel_spi_pci_remove(struct pci_dev *pdev)
>   }
>   
>   static const struct pci_device_id intel_spi_pci_ids[] = {
> +	{ PCI_VDEVICE(INTEL, 0x02a4), (unsigned long)&bxt_info },
>   	{ PCI_VDEVICE(INTEL, 0x18e0), (unsigned long)&bxt_info },
>   	{ PCI_VDEVICE(INTEL, 0x19e0), (unsigned long)&bxt_info },
>   	{ PCI_VDEVICE(INTEL, 0x34a4), (unsigned long)&bxt_info },
> 

applies to disco as well
Stefan Bader Oct. 8, 2019, 12:05 p.m. UTC | #2
On 03.10.19 20:20, Timo Aaltonen wrote:
> On 3.10.2019 20.59, Timo Aaltonen wrote:
>> From: Mika Westerberg <mika.westerberg@linux.intel.com>
>>
>> BugLink: http://bugs.launchpad.net/bugs/1843774
>>
>> Intel Comet Lake has the same SPI serial flash controller as Ice Lake.
>> Add Comet Lake PCI ID to the driver list of supported devices.
>>
>> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
>> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
>> (cherry picked from commit e43f53c22a937d024f070907d02539e413f20c15)
>> Signed-off-by: Timo Aaltonen <timo.aaltonen@canonical.com>
>> ---
>>   drivers/mtd/spi-nor/intel-spi-pci.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mtd/spi-nor/intel-spi-pci.c
>> b/drivers/mtd/spi-nor/intel-spi-pci.c
>> index 872b40922608..bfbfc17ed6aa 100644
>> --- a/drivers/mtd/spi-nor/intel-spi-pci.c
>> +++ b/drivers/mtd/spi-nor/intel-spi-pci.c
>> @@ -63,6 +63,7 @@ static void intel_spi_pci_remove(struct pci_dev *pdev)
>>   }
>>     static const struct pci_device_id intel_spi_pci_ids[] = {
>> +    { PCI_VDEVICE(INTEL, 0x02a4), (unsigned long)&bxt_info },
>>       { PCI_VDEVICE(INTEL, 0x18e0), (unsigned long)&bxt_info },
>>       { PCI_VDEVICE(INTEL, 0x19e0), (unsigned long)&bxt_info },
>>       { PCI_VDEVICE(INTEL, 0x34a4), (unsigned long)&bxt_info },
>>
> 
> applies to disco as well
> 
Then it would be better to re-submit as a separate mail, not a reply to a
submission which was only for the osp1 kernel. Because in a threaded view this
tends to be hidden.

-Stefan
Kleber Souza Oct. 17, 2019, 1:14 p.m. UTC | #3
On 03.10.19 20:20, Timo Aaltonen wrote:
> On 3.10.2019 20.59, Timo Aaltonen wrote:
>> From: Mika Westerberg <mika.westerberg@linux.intel.com>
>>
>> BugLink: http://bugs.launchpad.net/bugs/1843774
>>
>> Intel Comet Lake has the same SPI serial flash controller as Ice Lake.
>> Add Comet Lake PCI ID to the driver list of supported devices.
>>
>> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
>> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
>> (cherry picked from commit e43f53c22a937d024f070907d02539e413f20c15)
>> Signed-off-by: Timo Aaltonen <timo.aaltonen@canonical.com>

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

>> ---
>>   drivers/mtd/spi-nor/intel-spi-pci.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mtd/spi-nor/intel-spi-pci.c b/drivers/mtd/spi-nor/intel-spi-pci.c
>> index 872b40922608..bfbfc17ed6aa 100644
>> --- a/drivers/mtd/spi-nor/intel-spi-pci.c
>> +++ b/drivers/mtd/spi-nor/intel-spi-pci.c
>> @@ -63,6 +63,7 @@ static void intel_spi_pci_remove(struct pci_dev *pdev)
>>   }
>>   
>>   static const struct pci_device_id intel_spi_pci_ids[] = {
>> +	{ PCI_VDEVICE(INTEL, 0x02a4), (unsigned long)&bxt_info },
>>   	{ PCI_VDEVICE(INTEL, 0x18e0), (unsigned long)&bxt_info },
>>   	{ PCI_VDEVICE(INTEL, 0x19e0), (unsigned long)&bxt_info },
>>   	{ PCI_VDEVICE(INTEL, 0x34a4), (unsigned long)&bxt_info },
>>
> 
> applies to disco as well
>
Khaled Elmously Oct. 21, 2019, 3:05 p.m. UTC | #4
On 2019-10-03 21:20:45 , Timo Aaltonen wrote:
> On 3.10.2019 20.59, Timo Aaltonen wrote:
> > From: Mika Westerberg <mika.westerberg@linux.intel.com>
> > 
> > BugLink: http://bugs.launchpad.net/bugs/1843774
> > 
> > Intel Comet Lake has the same SPI serial flash controller as Ice Lake.
> > Add Comet Lake PCI ID to the driver list of supported devices.
> > 
> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> > Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> > Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> > (cherry picked from commit e43f53c22a937d024f070907d02539e413f20c15)
> > Signed-off-by: Timo Aaltonen <timo.aaltonen@canonical.com>
> > ---
> >   drivers/mtd/spi-nor/intel-spi-pci.c | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/mtd/spi-nor/intel-spi-pci.c b/drivers/mtd/spi-nor/intel-spi-pci.c
> > index 872b40922608..bfbfc17ed6aa 100644
> > --- a/drivers/mtd/spi-nor/intel-spi-pci.c
> > +++ b/drivers/mtd/spi-nor/intel-spi-pci.c
> > @@ -63,6 +63,7 @@ static void intel_spi_pci_remove(struct pci_dev *pdev)
> >   }
> >   static const struct pci_device_id intel_spi_pci_ids[] = {
> > +	{ PCI_VDEVICE(INTEL, 0x02a4), (unsigned long)&bxt_info },
> >   	{ PCI_VDEVICE(INTEL, 0x18e0), (unsigned long)&bxt_info },
> >   	{ PCI_VDEVICE(INTEL, 0x19e0), (unsigned long)&bxt_info },
> >   	{ PCI_VDEVICE(INTEL, 0x34a4), (unsigned long)&bxt_info },
> > 
> 
> applies to disco as well
> 

Acked-by: Khalid Elmously <khalid.elmously@canonical.com>
Kleber Souza Oct. 21, 2019, 3:09 p.m. UTC | #5
On 10/3/19 8:20 PM, Timo Aaltonen wrote:
> On 3.10.2019 20.59, Timo Aaltonen wrote:
>> From: Mika Westerberg <mika.westerberg@linux.intel.com>
>>
>> BugLink: http://bugs.launchpad.net/bugs/1843774
>>
>> Intel Comet Lake has the same SPI serial flash controller as Ice Lake.
>> Add Comet Lake PCI ID to the driver list of supported devices.
>>
>> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
>> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
>> (cherry picked from commit e43f53c22a937d024f070907d02539e413f20c15)
>> Signed-off-by: Timo Aaltonen <timo.aaltonen@canonical.com>
>> ---
>>   drivers/mtd/spi-nor/intel-spi-pci.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mtd/spi-nor/intel-spi-pci.c b/drivers/mtd/spi-nor/intel-spi-pci.c
>> index 872b40922608..bfbfc17ed6aa 100644
>> --- a/drivers/mtd/spi-nor/intel-spi-pci.c
>> +++ b/drivers/mtd/spi-nor/intel-spi-pci.c
>> @@ -63,6 +63,7 @@ static void intel_spi_pci_remove(struct pci_dev *pdev)
>>   }
>>   
>>   static const struct pci_device_id intel_spi_pci_ids[] = {
>> +	{ PCI_VDEVICE(INTEL, 0x02a4), (unsigned long)&bxt_info },
>>   	{ PCI_VDEVICE(INTEL, 0x18e0), (unsigned long)&bxt_info },
>>   	{ PCI_VDEVICE(INTEL, 0x19e0), (unsigned long)&bxt_info },
>>   	{ PCI_VDEVICE(INTEL, 0x34a4), (unsigned long)&bxt_info },
>>
> 
> applies to disco as well
> 

Applied to disco/master-next branch.

Thanks,
Kleber

Patch
diff mbox series

diff --git a/drivers/mtd/spi-nor/intel-spi-pci.c b/drivers/mtd/spi-nor/intel-spi-pci.c
index 872b40922608..bfbfc17ed6aa 100644
--- a/drivers/mtd/spi-nor/intel-spi-pci.c
+++ b/drivers/mtd/spi-nor/intel-spi-pci.c
@@ -63,6 +63,7 @@  static void intel_spi_pci_remove(struct pci_dev *pdev)
 }
 
 static const struct pci_device_id intel_spi_pci_ids[] = {
+	{ PCI_VDEVICE(INTEL, 0x02a4), (unsigned long)&bxt_info },
 	{ PCI_VDEVICE(INTEL, 0x18e0), (unsigned long)&bxt_info },
 	{ PCI_VDEVICE(INTEL, 0x19e0), (unsigned long)&bxt_info },
 	{ PCI_VDEVICE(INTEL, 0x34a4), (unsigned long)&bxt_info },