Patchwork [U-Boot,4/6] da850: revert cache disable patch

login
register
mail settings
Submitter nagabhushana.netagunte@ti.com
Date Sept. 30, 2011, 11:24 a.m.
Message ID <1317381867-18981-5-git-send-email-nagabhushana.netagunte@ti.com>
Download mbox | patch
Permalink /patch/117101/
State Superseded
Headers show

Comments

nagabhushana.netagunte@ti.com - Sept. 30, 2011, 11:24 a.m.
From: Nagabhushana Netagunte <nagabhushana.netagunte@ti.com>

revert commit bd65d006a6088bcb857e079447d7549e2cd7054d as cache
disabling is no more needed. Subsequent patches to new cache
management framework has fixed EMAC issue with cache coherency.

Signed-off-by: Nagabhushana Netagunte <nagabhushana.netagunte@ti.com>
---
 include/configs/da850_l138evm.h |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
Laurence Withers - Sept. 30, 2011, 9:48 p.m.
On Fri, Sep 30, 2011 at 04:54:25PM +0530, nagabhushana.netagunte@ti.com wrote:
> From: Nagabhushana Netagunte <nagabhushana.netagunte@ti.com>
> 
> revert commit bd65d006a6088bcb857e079447d7549e2cd7054d as cache
> disabling is no more needed. Subsequent patches to new cache
> management framework has fixed EMAC issue with cache coherency.
> 
> Signed-off-by: Nagabhushana Netagunte <nagabhushana.netagunte@ti.com>
> ---
>  include/configs/da850_l138evm.h |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/include/configs/da850_l138evm.h b/include/configs/da850_l138evm.h
> index 347893c..0bd630f 100644
> --- a/include/configs/da850_l138evm.h
> +++ b/include/configs/da850_l138evm.h
> @@ -43,9 +43,6 @@
>  #define CONFIG_SYS_HZ			1000
>  #define CONFIG_SKIP_LOWLEVEL_INIT
>  #define CONFIG_SYS_TEXT_BASE		0xc1080000
> -#define CONFIG_SYS_ICACHE_OFF
> -#define CONFIG_SYS_DCACHE_OFF
> -#define CONFIG_SYS_L2CACHE_OFF
>  
>  /*
>   * Memory Info

Am I correct in thinking that what you mean is that caches are now disabled
by default, and therefore you don't need to explicitly disable them? I guess
so, since I couldn't find any posted patches to fix the EMAC driver (though I
would be very glad if I was wrong about this!).

If so, we haven't actually "fixed EMAC issue with cache coherency" - the
driver is still broken if caches are enabled, and the commit message should
reflect that. The same would apply to the dm644X and dm36x cache disable
patches.

Bye for now,
nagabhushana.netagunte@ti.com - Oct. 4, 2011, 1:47 p.m.
Hi Laurence,

On Sat, Oct 01, 2011 at 03:18:44, Laurence Withers wrote:
> On Fri, Sep 30, 2011 at 04:54:25PM +0530, nagabhushana.netagunte@ti.com wrote:
> > From: Nagabhushana Netagunte <nagabhushana.netagunte@ti.com>
> > 
> > revert commit bd65d006a6088bcb857e079447d7549e2cd7054d as cache 
> > disabling is no more needed. Subsequent patches to new cache 
> > management framework has fixed EMAC issue with cache coherency.
> > 
> > Signed-off-by: Nagabhushana Netagunte <nagabhushana.netagunte@ti.com>
> > ---
> >  include/configs/da850_l138evm.h |    3 ---
> >  1 files changed, 0 insertions(+), 3 deletions(-)
> > 
> > diff --git a/include/configs/da850_l138evm.h 
> > b/include/configs/da850_l138evm.h index 347893c..0bd630f 100644
> > --- a/include/configs/da850_l138evm.h
> > +++ b/include/configs/da850_l138evm.h
> > @@ -43,9 +43,6 @@
> >  #define CONFIG_SYS_HZ			1000
> >  #define CONFIG_SKIP_LOWLEVEL_INIT
> >  #define CONFIG_SYS_TEXT_BASE		0xc1080000
> > -#define CONFIG_SYS_ICACHE_OFF
> > -#define CONFIG_SYS_DCACHE_OFF
> > -#define CONFIG_SYS_L2CACHE_OFF
> >  
> >  /*
> >   * Memory Info
> 
> Am I correct in thinking that what you mean is that caches are now disabled by default, and therefore you don't need to explicitly disable them? I guess so, since I couldn't find any posted patches to fix the EMAC driver (though I would be very glad if I was wrong about this!).
That is right. We will definitely come back to fixing EMAC after come time.
> 
> If so, we haven't actually "fixed EMAC issue with cache coherency" - the driver is still broken if caches are enabled, and the commit message should reflect that. The same would apply to the dm644X and dm36x cache disable patches.
Sure. Will correct that.

Thx,
 Nag
> 
> Bye for now,
> -- 
> Laurence Withers, <lwithers@guralp.com>                http://www.guralp.com/
> Direct tel:+447753988197 or tel:+443333408643               Software Engineer
> General support queries: <support@guralp.com>         CMG-DCM CMG-EAM CMG-NAM
>

Patch

diff --git a/include/configs/da850_l138evm.h b/include/configs/da850_l138evm.h
index 347893c..0bd630f 100644
--- a/include/configs/da850_l138evm.h
+++ b/include/configs/da850_l138evm.h
@@ -43,9 +43,6 @@ 
 #define CONFIG_SYS_HZ			1000
 #define CONFIG_SKIP_LOWLEVEL_INIT
 #define CONFIG_SYS_TEXT_BASE		0xc1080000
-#define CONFIG_SYS_ICACHE_OFF
-#define CONFIG_SYS_DCACHE_OFF
-#define CONFIG_SYS_L2CACHE_OFF
 
 /*
  * Memory Info