From patchwork Wed Oct 2 12:29:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Szyprowski X-Patchwork-Id: 1170636 X-Patchwork-Delegate: lukma@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="lGsyidG/"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 46jwSS30JLz9sPL for ; Wed, 2 Oct 2019 22:29:44 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 88192C21DDC; Wed, 2 Oct 2019 12:29:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=SPF_HELO_PASS, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 0C8BBC21C3F; Wed, 2 Oct 2019 12:29:37 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 47FAEC21C3F; Wed, 2 Oct 2019 12:29:35 +0000 (UTC) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by lists.denx.de (Postfix) with ESMTPS id 5E93CC21C38 for ; Wed, 2 Oct 2019 12:29:34 +0000 (UTC) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20191002122932euoutp01565181632b58c9239a441d1ea56a9981~J1E0CPpr72165221652euoutp01U for ; Wed, 2 Oct 2019 12:29:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20191002122932euoutp01565181632b58c9239a441d1ea56a9981~J1E0CPpr72165221652euoutp01U DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1570019372; bh=t4NSpQwv6lr/CLfwDj92evRl30nRlGHFDx6EZRjc/Uc=; h=From:To:Cc:Subject:Date:References:From; b=lGsyidG//IQUYmEXe3arCUDyqYA1kTq5A/0PNIv0S0KXz/qqazXuyne12MRkMrb8p kQtsqmm3OD7b5C0g823OMS/IVg10p5xN8wHXc/8Hm8foww9Qd7p8gx3iTvdOArWRC8 mBHSx8UFBfNdWYsUjburavg8BWeWfdk4X8Fqd6T0= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20191002122931eucas1p245671fb3d20f88184a3b21f8e004856d~J1EzmGEDY0428304283eucas1p2m; Wed, 2 Oct 2019 12:29:31 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id AD.8D.04469.B28949D5; Wed, 2 Oct 2019 13:29:31 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20191002122931eucas1p24269d2878dd33ba62677d492fe88e07d~J1EzH-XZS0644906449eucas1p2b; Wed, 2 Oct 2019 12:29:31 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20191002122931eusmtrp289358881e0d70e2b4dbd949a1faab714~J1EzHY4-_2036120361eusmtrp2x; Wed, 2 Oct 2019 12:29:31 +0000 (GMT) X-AuditID: cbfec7f2-54fff70000001175-8e-5d94982b66a4 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 20.C9.04166.B28949D5; Wed, 2 Oct 2019 13:29:31 +0100 (BST) Received: from AMDC2765.digital.local (unknown [106.120.51.73]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20191002122930eusmtip21992e8dd435221961ed7c924eeb27797~J1Eywr54p2388323883eusmtip2a; Wed, 2 Oct 2019 12:29:30 +0000 (GMT) From: Marek Szyprowski To: u-boot@lists.denx.de Date: Wed, 2 Oct 2019 14:29:21 +0200 Message-Id: <20191002122921.18693-1-m.szyprowski@samsung.com> X-Mailer: git-send-email 2.17.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrIIsWRmVeSWpSXmKPExsWy7djPc7raM6bEGvR/0LXYOGM9q8WNX22s Fs/fXWayWHvkLrvFjMkv2Sze7u1kd2DzmDfrBIvH2Ts7GD36tqxiDGCO4rJJSc3JLEst0rdL 4MpYfGMyS8E01oqLx/YzNjBOZ+li5OSQEDCR+P/pGmMXIxeHkMAKRonFkw6zgiSEBL4wSrQe 4IZIfGaU2Pd9MlzHpT2tLBCJ5YwSJ2+9gGoH6vh+bilYO5uAoUTX2y42EFtEQELiV/9VsCJm gTuMEhtPgyzk5BAWcJFY/a4bbCyLgKpEy4PLYHFeAVuJtz+WsUOsk5dYveEAM0izhMABNokt 309AJVwkzu5ezwphC0u8Or4FKi4j8X/nfCaIhmZGiYfn1rJDOD2MEpebZjBCVFlLHD5+Eaib A+gmTYn1u/RBTAkBR4k3a9whTD6JG28FQYqZgcxJ26YzQ4R5JTrahCBmqEnMOr4ObuvBC5eY IWwPiUdzIaElJBAr0TdrJ+MERrlZCKsWMDKuYhRPLS3OTU8tNsxLLdcrTswtLs1L10vOz93E CIz40/+Of9rB+PVS0iFGAQ5GJR7eGyGTY4VYE8uKK3MPMUpwMCuJ8Nr8mRQrxJuSWFmVWpQf X1Sak1p8iFGag0VJnLea4UG0kEB6YklqdmpqQWoRTJaJg1OqgXGiYZzIDbuqK31c01+WdTlO P1c9J1ZJUT/f9pyyTdmOA+YN9Tsv8LP5+wpeE0w8fPLAk9a+bp5js1pZb7g+1LGuTpwWzPfv ttiuzeeXXd8fe/7te9ZbgX/+ua6bNsNW5okjv8ryIm+B3zevi01Oay16fJCP+6T8TT1T7r3f oyrXW8lfiLsefU6JpTgj0VCLuag4EQA5CtJ+9AIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrBLMWRmVeSWpSXmKPExsVy+t/xe7raM6bEGjzuFLHYOGM9q8WNX22s Fs/fXWayWHvkLrvFjMkv2Sze7u1kd2DzmDfrBIvH2Ts7GD36tqxiDGCO0rMpyi8tSVXIyC8u sVWKNrQw0jO0tNAzMrHUMzQ2j7UyMlXSt7NJSc3JLEst0rdL0MtYfGMyS8E01oqLx/YzNjBO Z+li5OSQEDCRuLSnFcjm4hASWMoosf/8DjaIhIzEyWkNrBC2sMSfa11sEEWfGCVavm5mBkmw CRhKdL3tAmsQEZCQ+NV/lRGkiFngHqPEysn7wIqEBVwkVr/rBlvHIqAq0fLgMiOIzStgK/H2 xzJ2iA3yEqs3HGCewMizgJFhFaNIamlxbnpusaFecWJucWleul5yfu4mRmCobTv2c/MOxksb gw8xCnAwKvHwNgRNjhViTSwrrsw9xCjBwawkwmvzZ1KsEG9KYmVValF+fFFpTmrxIUZToOUT maVEk/OBcZBXEm9oamhuYWlobmxubGahJM7bIXAwRkggPbEkNTs1tSC1CKaPiYNTqoGRwaIt LnzuksWXX/B9XqNxpeLTZpUDU/8zP8haldC1uMTk7Cu/iL3JrLl5eWy7V+673M3zNn1dvyan wh7X3WuY+NMqLz9JiT/WIvlhsdeesvnlk+YvdHy+UkVybkxc6ptZVVt3nentlb+k0uG9Wenz xOUH9Mzq36yrC6jZXThjiaBwQWnhCVUGJZbijERDLeai4kQAmwD0eUsCAAA= X-CMS-MailID: 20191002122931eucas1p24269d2878dd33ba62677d492fe88e07d X-Msg-Generator: CA X-RootMTR: 20191002122931eucas1p24269d2878dd33ba62677d492fe88e07d X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20191002122931eucas1p24269d2878dd33ba62677d492fe88e07d References: Cc: Bartlomiej Zolnierkiewicz , Marek Szyprowski Subject: [U-Boot] [PATCH] thor: fix error path after g_dnl_register() failure X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Set command return value and perform needed cleanup when g_dnl_register() function fails. Signed-off-by: Marek Szyprowski --- cmd/thordown.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cmd/thordown.c b/cmd/thordown.c index dd0544d475..8dae024e31 100644 --- a/cmd/thordown.c +++ b/cmd/thordown.c @@ -40,7 +40,8 @@ int do_thor_down(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) ret = g_dnl_register("usb_dnl_thor"); if (ret) { pr_err("g_dnl_register failed %d\n", ret); - return ret; + ret = CMD_RET_FAILURE; + goto exit; } ret = thor_init();