| Message ID | 20191002102328.5196-5-joel@jms.id.au |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | Tacoma device tree fixes | expand |
On 10/2/19 5:23 AM, Joel Stanley wrote: > Required to provide the host firmware to on Tacoma. Reviewed-by: Eddie James <eajames@linux.ibm.com> > > Signed-off-by: Joel Stanley <joel@jms.id.au> > --- > arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts > index 02eeea6a9bd2..55d5227caf69 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts > @@ -22,6 +22,17 @@ > device_type = "memory"; > reg = <0x80000000 0x40000000>; > }; > + > + reserved-memory { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + flash_memory: region@98000000 { > + no-map; > + reg = <0x98000000 0x2000000>; /* 32M */ > + }; > + }; > }; > > &fmc { > @@ -447,3 +458,9 @@ > &vuart1 { > status = "okay"; > }; > + > +&lpc_ctrl { > + status = "okay"; > + memory-region = <&flash_memory>; > + flash = <&spi1>; > +};
On Wed, 2 Oct 2019, at 19:53, Joel Stanley wrote: > Required to provide the host firmware to on Tacoma. > > Signed-off-by: Joel Stanley <joel@jms.id.au> > --- > arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts > b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts > index 02eeea6a9bd2..55d5227caf69 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts > @@ -22,6 +22,17 @@ > device_type = "memory"; > reg = <0x80000000 0x40000000>; > }; > + > + reserved-memory { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + flash_memory: region@98000000 { > + no-map; > + reg = <0x98000000 0x2000000>; /* 32M */ Should put this at 0xba000000 if we're going to use 32M, or if you want to use 64M like Rainier then 0xb8000000. 0x98000000 isn't wrong but it fragments the address space more than necessary. Andrew
On Thu, 3 Oct 2019 at 00:06, Andrew Jeffery <andrew@aj.id.au> wrote: > > + flash_memory: region@98000000 { > > + no-map; > > + reg = <0x98000000 0x2000000>; /* 32M */ > > Should put this at 0xba000000 if we're going to use 32M, or if you want to > use 64M like Rainier then 0xb8000000. > > 0x98000000 isn't wrong but it fragments the address space more than > necessary. Good point. I'll move it to 0xba000000. Thanks for the review.
diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts index 02eeea6a9bd2..55d5227caf69 100644 --- a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts +++ b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts @@ -22,6 +22,17 @@ device_type = "memory"; reg = <0x80000000 0x40000000>; }; + + reserved-memory { + #address-cells = <1>; + #size-cells = <1>; + ranges; + + flash_memory: region@98000000 { + no-map; + reg = <0x98000000 0x2000000>; /* 32M */ + }; + }; }; &fmc { @@ -447,3 +458,9 @@ &vuart1 { status = "okay"; }; + +&lpc_ctrl { + status = "okay"; + memory-region = <&flash_memory>; + flash = <&spi1>; +};
Required to provide the host firmware to on Tacoma. Signed-off-by: Joel Stanley <joel@jms.id.au> --- arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)