Patchwork [1/2] ppc/e500_pci: Fix code style

login
register
mail settings
Submitter Liu Yu-B13201
Date Sept. 30, 2011, 3:52 a.m.
Message ID <1317354770-21531-1-git-send-email-yu.liu@freescale.com>
Download mbox | patch
Permalink /patch/117035/
State New
Headers show

Comments

Liu Yu-B13201 - Sept. 30, 2011, 3:52 a.m.
Put trailing statements on next line.

Signed-off-by: Liu Yu <yu.liu@freescale.com>
---
 hw/ppce500_pci.c |   76 +++++++++++++++++++++++++++++++++++++++--------------
 1 files changed, 56 insertions(+), 20 deletions(-)
Andreas Färber - Oct. 1, 2011, 1:05 p.m.
Am 30.09.2011 um 05:52 schrieb Liu Yu:

> Put trailing statements on next line.
>
> Signed-off-by: Liu Yu <yu.liu@freescale.com>

Reviewed-by: Andreas Färber <andreas.faerber@web.de>

Not only fixes Coding Style but also improves readability by  
consistent indentation IMO.

Note that there are also three superfluous semicolons after the  
closing braces following the sections touched herein.

Andreas

Patch

diff --git a/hw/ppce500_pci.c b/hw/ppce500_pci.c
index 2db365d..0ece422 100644
--- a/hw/ppce500_pci.c
+++ b/hw/ppce500_pci.c
@@ -98,11 +98,20 @@  static uint32_t pci_reg_read4(void *opaque, target_phys_addr_t addr)
     case PPCE500_PCI_OW3:
     case PPCE500_PCI_OW4:
         switch (addr & 0xC) {
-        case PCI_POTAR: value = pci->pob[(addr >> 5) & 0x7].potar; break;
-        case PCI_POTEAR: value = pci->pob[(addr >> 5) & 0x7].potear; break;
-        case PCI_POWBAR: value = pci->pob[(addr >> 5) & 0x7].powbar; break;
-        case PCI_POWAR: value = pci->pob[(addr >> 5) & 0x7].powar; break;
-        default: break;
+        case PCI_POTAR:
+            value = pci->pob[(addr >> 5) & 0x7].potar;
+            break;
+        case PCI_POTEAR:
+            value = pci->pob[(addr >> 5) & 0x7].potear;
+            break;
+        case PCI_POWBAR:
+            value = pci->pob[(addr >> 5) & 0x7].powbar;
+            break;
+        case PCI_POWAR:
+            value = pci->pob[(addr >> 5) & 0x7].powar;
+            break;
+        default:
+            break;
         }
         break;
 
@@ -110,11 +119,20 @@  static uint32_t pci_reg_read4(void *opaque, target_phys_addr_t addr)
     case PPCE500_PCI_IW2:
     case PPCE500_PCI_IW1:
         switch (addr & 0xC) {
-        case PCI_PITAR: value = pci->pib[(addr >> 5) & 0x3].pitar; break;
-        case PCI_PIWBAR: value = pci->pib[(addr >> 5) & 0x3].piwbar; break;
-        case PCI_PIWBEAR: value = pci->pib[(addr >> 5) & 0x3].piwbear; break;
-        case PCI_PIWAR: value = pci->pib[(addr >> 5) & 0x3].piwar; break;
-        default: break;
+        case PCI_PITAR:
+            value = pci->pib[(addr >> 5) & 0x3].pitar;
+            break;
+        case PCI_PIWBAR:
+            value = pci->pib[(addr >> 5) & 0x3].piwbar;
+            break;
+        case PCI_PIWBEAR:
+            value = pci->pib[(addr >> 5) & 0x3].piwbear;
+            break;
+        case PCI_PIWAR:
+            value = pci->pib[(addr >> 5) & 0x3].piwar;
+            break;
+        default:
+            break;
         };
         break;
 
@@ -154,11 +172,20 @@  static void pci_reg_write4(void *opaque, target_phys_addr_t addr,
     case PPCE500_PCI_OW3:
     case PPCE500_PCI_OW4:
         switch (addr & 0xC) {
-        case PCI_POTAR: pci->pob[(addr >> 5) & 0x7].potar = value; break;
-        case PCI_POTEAR: pci->pob[(addr >> 5) & 0x7].potear = value; break;
-        case PCI_POWBAR: pci->pob[(addr >> 5) & 0x7].powbar = value; break;
-        case PCI_POWAR: pci->pob[(addr >> 5) & 0x7].powar = value; break;
-        default: break;
+        case PCI_POTAR:
+            pci->pob[(addr >> 5) & 0x7].potar = value;
+            break;
+        case PCI_POTEAR:
+            pci->pob[(addr >> 5) & 0x7].potear = value;
+            break;
+        case PCI_POWBAR:
+            pci->pob[(addr >> 5) & 0x7].powbar = value;
+            break;
+        case PCI_POWAR:
+            pci->pob[(addr >> 5) & 0x7].powar = value;
+            break;
+        default:
+            break;
         };
         break;
 
@@ -166,11 +193,20 @@  static void pci_reg_write4(void *opaque, target_phys_addr_t addr,
     case PPCE500_PCI_IW2:
     case PPCE500_PCI_IW1:
         switch (addr & 0xC) {
-        case PCI_PITAR: pci->pib[(addr >> 5) & 0x3].pitar = value; break;
-        case PCI_PIWBAR: pci->pib[(addr >> 5) & 0x3].piwbar = value; break;
-        case PCI_PIWBEAR: pci->pib[(addr >> 5) & 0x3].piwbear = value; break;
-        case PCI_PIWAR: pci->pib[(addr >> 5) & 0x3].piwar = value; break;
-        default: break;
+        case PCI_PITAR:
+            pci->pib[(addr >> 5) & 0x3].pitar = value;
+            break;
+        case PCI_PIWBAR:
+            pci->pib[(addr >> 5) & 0x3].piwbar = value;
+            break;
+        case PCI_PIWBEAR:
+            pci->pib[(addr >> 5) & 0x3].piwbear = value;
+            break;
+        case PCI_PIWAR:
+            pci->pib[(addr >> 5) & 0x3].piwar = value;
+            break;
+        default:
+            break;
         };
         break;