diff mbox series

[3/8] mcf5208: fix leak from qemu_allocate_irqs

Message ID 1569936988-635-4-git-send-email-pbonzini@redhat.com
State New
Headers show
Series fix various memory leaks (but not all) | expand

Commit Message

Paolo Bonzini Oct. 1, 2019, 1:36 p.m. UTC 
The array returned by qemu_allocate_irqs is malloced, free it.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/m68k/mcf5208.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Thomas Huth Oct. 1, 2019, 2:28 p.m. UTC | #1 
On 01/10/2019 15.36, Paolo Bonzini wrote:
> The array returned by qemu_allocate_irqs is malloced, free it.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  hw/m68k/mcf5208.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/hw/m68k/mcf5208.c b/hw/m68k/mcf5208.c
> index 012710d..60c5802 100644
> --- a/hw/m68k/mcf5208.c
> +++ b/hw/m68k/mcf5208.c
> @@ -273,6 +273,8 @@ static void mcf5208evb_init(MachineState *machine)
>                       0xfc030000, pic + 36);
>      }
>  
> +    g_free(pic);
> +
>      /*  0xfc000000 SCM.  */
>      /*  0xfc004000 XBS.  */
>      /*  0xfc008000 FlexBus CS.  */
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>
diff mbox series

Patch

diff --git a/hw/m68k/mcf5208.c b/hw/m68k/mcf5208.c
index 012710d..60c5802 100644
--- a/hw/m68k/mcf5208.c
+++ b/hw/m68k/mcf5208.c
@@ -273,6 +273,8 @@  static void mcf5208evb_init(MachineState *machine)
                      0xfc030000, pic + 36);
     }
 
+    g_free(pic);
+
     /*  0xfc000000 SCM.  */
     /*  0xfc004000 XBS.  */
     /*  0xfc008000 FlexBus CS.  */